From: Rhyland Klein <rklein@nvidia.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: max77620: Fix FPS switch statements
Date: Wed, 1 Jun 2016 11:29:29 -0400 [thread overview]
Message-ID: <55393f24-75ce-67b3-2933-3b7aeccb12ce@nvidia.com> (raw)
In-Reply-To: <20160531073022.GA1729@dell>
On 5/31/2016 3:30 AM, Lee Jones wrote:
> On Fri, 27 May 2016, Rhyland Klein wrote:
>
>> On 5/12/2016 1:52 PM, Laxman Dewangan wrote:
>>>
>>> On Thursday 12 May 2016 11:15 PM, Rhyland Klein wrote:
>>>> When configuring FPS during probe, assuming a DT node is present for
>>>> FPS, the code can run into a problem with the switch statements in
>>>> max77620_config_fps() and max77620_get_fps_period_reg_value(). Namely,
>>>> in the case of chip->chip_id == MAX77620, it will set
>>>> fps_[mix|max]_period but then fall through to the default switch case
>>>> and return -EINVAL. Returning this from max77620_config_fps() will
>>>> cause probe to fail.
>>>>
>>>
>>> Thanks for fixes.
>>> Missed when converting if-else to switch.
>>>
>>> Reviewed-by: Laxman Dewangan <ldewangan@nvidia.com>
>>>
>>
>> Lee, I noticed this hasn't been merged yet, but without it platforms
>> using the max77620 can easily (if it has FPS nodes) fail to probe. Is
>> there anything blocking it?
>
> Yes, it was sent too late in the cycle.
>
Ok, thanks.
-rhyland
--
nvpublic
next prev parent reply other threads:[~2016-06-01 15:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 17:45 [PATCH] mfd: max77620: Fix FPS switch statements Rhyland Klein
2016-05-12 17:52 ` Laxman Dewangan
2016-05-27 20:31 ` Rhyland Klein
2016-05-31 7:30 ` Lee Jones
2016-06-01 15:29 ` Rhyland Klein [this message]
2016-06-06 15:32 ` Thierry Reding
2016-06-07 8:05 ` Lee Jones
2016-06-14 16:50 ` Rhyland Klein
2016-06-15 6:11 ` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55393f24-75ce-67b3-2933-3b7aeccb12ce@nvidia.com \
--to=rklein@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).