From: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
To: Leon Romanovsky <leon@kernel.org>, Gal Pressman <galpress@amazon.com>
Cc: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Adit Ranadive <aditr@vmware.com>,
Ariel Elior <aelior@marvell.com>,
Bernard Metzler <bmt@zurich.ibm.com>,
Christian Benvenuti <benve@cisco.com>,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
Michal Kalderon <mkalderon@marvell.com>,
Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>,
Mustafa Ismail <mustafa.ismail@intel.com>,
Naresh Kumar PBS <nareshkumar.pbs@broadcom.com>,
Nelson Escobar <neescoba@cisco.com>,
Potnuri Bharat Teja <bharat@chelsio.com>,
Selvin Xavier <selvin.xavier@broadcom.com>,
Shiraz Saleem <shiraz.saleem@intel.com>,
Steve Wise <larrystevenwise@gmail.com>,
VMware PV-Drivers <pv-drivers@vmware.com>,
Weihang Li <liweihang@huawei.com>,
Wenpeng Liang <liangwenpeng@huawei.com>,
Yishai Hadas <yishaih@nvidia.com>,
Zhu Yanjun <zyjzyj2000@gmail.com>
Subject: Re: [PATCH rdma-next 8/9] RDMA: Globally allocate and release QP memory
Date: Wed, 21 Jul 2021 14:05:34 -0400 [thread overview]
Message-ID: <5539c203-0d3b-6296-7554-143e7afb6e34@cornelisnetworks.com> (raw)
In-Reply-To: <YPaKu4ppS0Bz6fW1@unreal>
On 7/20/21 4:35 AM, Leon Romanovsky wrote:
> On Mon, Jul 19, 2021 at 04:42:11PM +0300, Gal Pressman wrote:
>> On 18/07/2021 15:00, Leon Romanovsky wrote:
>>> From: Leon Romanovsky <leonro@nvidia.com>
>>>
>>> Convert QP object to follow IB/core general allocation scheme.
>>> That change allows us to make sure that restrack properly kref
>>> the memory.
>>>
>>> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
>>
>> EFA and core parts look good to me.
>> Reviewed-by: Gal Pressman <galpress@amazon.com>
>> Tested-by: Gal Pressman <galpress@amazon.com>
Leon, I pulled your tree and tested, things look good so far.
For rdmavt and core:
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Tested-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
> Thanks a lot.
>
>>
>>> +static inline void *rdma_zalloc_obj(struct ib_device *dev, size_t size,
>>> + gfp_t gfp, bool is_numa_aware)
>>> +{
>>> + if (is_numa_aware && dev->ops.get_numa_node)
>>
>> Honestly I think it's better to return an error if a numa aware allocation is
>> requested and get_numa_node is not provided.
>
> We don't want any driver to use and implement ".get_numa_node()" callback.
>
> Initially, I thought about adding WARN_ON(driver_id != HFI && .get_numa_node)
> to the device.c, but decided to stay with comment in ib_verbs.h only.
Maybe you could update that comment and add that it's for performance? This way
its clear we are different for a reason. I'd be fine adding a WARN_ON_ONCE like
you mention here. I don't think we need to fail the call but drawing attention
to it would not necessarily be a bad thing. Either way, RB/TB for me stands.
-Denny
next prev parent reply other threads:[~2021-07-21 18:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-18 12:00 [PATCH rdma-next 0/9] QP allocation changes Leon Romanovsky
2021-07-18 12:00 ` [PATCH rdma-next 1/9] RDMA/hns: Don't skip IB creation flow for regular RC QP Leon Romanovsky
2021-07-18 12:00 ` [PATCH rdma-next 2/9] RDMA/hns: Don't overwrite supplied QP attributes Leon Romanovsky
2021-07-18 12:00 ` [PATCH rdma-next 3/9] RDMA/efa: Remove double QP type assignment Leon Romanovsky
2021-07-19 13:40 ` Gal Pressman
2021-07-18 12:00 ` [PATCH rdma-next 4/9] RDMA/mlx5: Cancel pkey work before destroying device resources Leon Romanovsky
2021-07-18 12:00 ` [PATCH rdma-next 5/9] RDMA/mlx5: Delete device resource mutex that didn't protect anything Leon Romanovsky
2021-07-18 12:00 ` [PATCH rdma-next 6/9] RDMA/mlx5: Rework custom driver QP type creation Leon Romanovsky
2021-07-18 12:00 ` [PATCH rdma-next 7/9] RDMA/rdmavt: Decouple QP and SGE lists allocations Leon Romanovsky
2021-07-18 12:00 ` [PATCH rdma-next 8/9] RDMA: Globally allocate and release QP memory Leon Romanovsky
2021-07-19 13:42 ` Gal Pressman
2021-07-20 8:35 ` Leon Romanovsky
2021-07-21 18:05 ` Dennis Dalessandro [this message]
2021-07-22 7:05 ` Leon Romanovsky
2021-07-22 7:59 ` Wenpeng Liang
2021-07-22 8:16 ` Leon Romanovsky
2021-07-22 8:08 ` Wenpeng Liang
2021-07-18 12:00 ` [PATCH rdma-next 9/9] RDMA/mlx5: Drop in-driver verbs object creations Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5539c203-0d3b-6296-7554-143e7afb6e34@cornelisnetworks.com \
--to=dennis.dalessandro@cornelisnetworks.com \
--cc=aditr@vmware.com \
--cc=aelior@marvell.com \
--cc=benve@cisco.com \
--cc=bharat@chelsio.com \
--cc=bmt@zurich.ibm.com \
--cc=dledford@redhat.com \
--cc=galpress@amazon.com \
--cc=jgg@nvidia.com \
--cc=larrystevenwise@gmail.com \
--cc=leon@kernel.org \
--cc=liangwenpeng@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=liweihang@huawei.com \
--cc=mike.marciniszyn@cornelisnetworks.com \
--cc=mkalderon@marvell.com \
--cc=mustafa.ismail@intel.com \
--cc=nareshkumar.pbs@broadcom.com \
--cc=neescoba@cisco.com \
--cc=pv-drivers@vmware.com \
--cc=selvin.xavier@broadcom.com \
--cc=shiraz.saleem@intel.com \
--cc=yishaih@nvidia.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).