From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751767AbbD3OTH (ORCPT ); Thu, 30 Apr 2015 10:19:07 -0400 Received: from foss.arm.com ([217.140.101.70]:35953 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751734AbbD3OTE (ORCPT ); Thu, 30 Apr 2015 10:19:04 -0400 Message-ID: <554239D5.4080301@arm.com> Date: Thu, 30 Apr 2015 15:19:01 +0100 From: Sudeep Holla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Rob Herring CC: Sudeep Holla , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Russell King , Catalin Marinas , Daniel Lezcano , Thomas Gleixner , Arnd Bergmann , Olof Johansson Subject: Re: [PATCH 1/2] ARM: simplify timer initialisation and remove arm_timer.h inclusion References: <1430390662-18246-1-git-send-email-sudeep.holla@arm.com> <1430390662-18246-2-git-send-email-sudeep.holla@arm.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/04/15 15:09, Rob Herring wrote: > On Thu, Apr 30, 2015 at 5:44 AM, Sudeep Holla wrote: >> The header asm/hardware/arm_timer.h is included in various machine >> specific files to access TIMER_CTRL and initialise to a known state. >> However that's not required as the clock{source,event} driver timer-sp >> initialises all the timer being used. > > I believe the idea is not to initialize the timers being used, but the > ones not being used and perhaps left running by the bootloader. Cases > where the interrupt is shared could cause a problem. > Ah OK, makes sense. I will wait for Russell to confirm. The main idea was to keep the header file having offsets local to driver/clocksource and avoid sharing it in include/linux but looks like that's not possible. Regards, Sudeep