From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751119AbbEAXee (ORCPT ); Fri, 1 May 2015 19:34:34 -0400 Received: from mail-pd0-f179.google.com ([209.85.192.179]:35558 "EHLO mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750778AbbEAXeb (ORCPT ); Fri, 1 May 2015 19:34:31 -0400 Message-ID: <55440D7D.4060504@gmail.com> Date: Fri, 01 May 2015 16:34:21 -0700 From: Florian Fainelli User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Vivien Didelot , netdev@vger.kernel.org CC: linux-kernel@vger.kernel.org, "David S. Miller" , Guenter Roeck , Andrew Lunn , kernel@savoirfairelinux.com Subject: Re: [PATCH 1/3] net: dsa: introduce module_switch_driver macro References: <1430518155-29565-1-git-send-email-vivien.didelot@savoirfairelinux.com> In-Reply-To: <1430518155-29565-1-git-send-email-vivien.didelot@savoirfairelinux.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/05/15 15:09, Vivien Didelot wrote: > This commit introduces a new module_switch_driver macro, similar to > module_platform_driver and such, to reduce boilerplate when declaring > DSA switch drivers. > > In order to use the module_driver macro, register_switch_driver needed > to be changed to return an int instead of void, so make it return 0. Do we get much benefit from having this change, the diffstat looks pretty neutral, ultimately register_switch_driver() might be gone (see: http://www.spinics.net/lists/netdev/msg326900.html) and mv88e6xxx cannot be converted to it due to how it is designed. This is not a strong objection though, the changes look fine to me. > > Signed-off-by: Vivien Didelot > --- > include/net/dsa.h | 13 ++++++++++++- > net/dsa/dsa.c | 4 +++- > 2 files changed, 15 insertions(+), 2 deletions(-) > > diff --git a/include/net/dsa.h b/include/net/dsa.h > index fbca63b..927f16a 100644 > --- a/include/net/dsa.h > +++ b/include/net/dsa.h > @@ -11,6 +11,7 @@ > #ifndef __LINUX_NET_DSA_H > #define __LINUX_NET_DSA_H > > +#include > #include > #include > #include > @@ -304,8 +305,18 @@ struct dsa_switch_driver { > unsigned char *addr, bool *is_static); > }; > > -void register_switch_driver(struct dsa_switch_driver *type); > +int register_switch_driver(struct dsa_switch_driver *type); > void unregister_switch_driver(struct dsa_switch_driver *type); > + > +/* module_switch_driver() - Helper macro for drivers that don't do anything > + * special in module init/exit. This eliminates a lot of boilerplate. Each > + * module may only use this macro once, and calling it replaces module_init() > + * and module_exit() > + */ > +#define module_switch_driver(__switch_driver) \ > + module_driver(__switch_driver, register_switch_driver, \ > + unregister_switch_driver) > + > struct mii_bus *dsa_host_dev_to_mii_bus(struct device *dev); > > static inline void *ds_to_priv(struct dsa_switch *ds) > diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c > index e6f6cc3..9630522 100644 > --- a/net/dsa/dsa.c > +++ b/net/dsa/dsa.c > @@ -31,11 +31,13 @@ char dsa_driver_version[] = "0.1"; > static DEFINE_MUTEX(dsa_switch_drivers_mutex); > static LIST_HEAD(dsa_switch_drivers); > > -void register_switch_driver(struct dsa_switch_driver *drv) > +int register_switch_driver(struct dsa_switch_driver *drv) > { > mutex_lock(&dsa_switch_drivers_mutex); > list_add_tail(&drv->list, &dsa_switch_drivers); > mutex_unlock(&dsa_switch_drivers_mutex); > + > + return 0; > } > EXPORT_SYMBOL_GPL(register_switch_driver); > > -- Florian