From: Guenter Roeck <linux@roeck-us.net>
To: Colin King <colin.king@canonical.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][usb-next] USB: typec: fsusb302: remove unused variables snk_pdo and toggling_mode_name
Date: Mon, 6 Aug 2018 08:47:43 -0700 [thread overview]
Message-ID: <554613b4-daec-7db6-d770-7e222ab8d23b@roeck-us.net> (raw)
In-Reply-To: <20180806111414.9436-1-colin.king@canonical.com>
On 08/06/2018 04:14 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variables snk_pdo and toggling_mode_name are defined but are not used and
> hence can be removed.
>
> Cleans up clang warnings:
> warning: 'snk_pdo' defined but not used [-Wunused-const-variable=]
> warning: 'toggling_mode_name' defined but not used [-Wunused-const-variable=]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/usb/typec/fusb302/fusb302.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/usb/typec/fusb302/fusb302.c b/drivers/usb/typec/fusb302/fusb302.c
> index 82bed9810be6..ad7cfed1cea7 100644
> --- a/drivers/usb/typec/fusb302/fusb302.c
> +++ b/drivers/usb/typec/fusb302/fusb302.c
> @@ -48,13 +48,6 @@ enum toggling_mode {
> TOGGLING_MODE_SRC,
> };
>
> -static const char * const toggling_mode_name[] = {
> - [TOGGLINE_MODE_OFF] = "toggling_OFF",
> - [TOGGLING_MODE_DRP] = "toggling_DRP",
> - [TOGGLING_MODE_SNK] = "toggling_SNK",
> - [TOGGLING_MODE_SRC] = "toggling_SRC",
> -};
> -
> enum src_current_status {
> SRC_CURRENT_DEFAULT,
> SRC_CURRENT_MEDIUM,
> @@ -1178,10 +1171,6 @@ static const u32 src_pdo[] = {
> PDO_FIXED(5000, 400, PDO_FIXED_FLAGS),
> };
>
> -static const u32 snk_pdo[] = {
> - PDO_FIXED(5000, 400, PDO_FIXED_FLAGS),
> -};
> -
> static const struct tcpc_config fusb302_tcpc_config = {
> .src_pdo = src_pdo,
> .nr_src_pdo = ARRAY_SIZE(src_pdo),
>
prev parent reply other threads:[~2018-08-06 15:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 11:14 [PATCH][usb-next] USB: typec: fsusb302: remove unused variables snk_pdo and toggling_mode_name Colin King
2018-08-06 12:11 ` Heikki Krogerus
2018-08-06 15:47 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554613b4-daec-7db6-d770-7e222ab8d23b@roeck-us.net \
--to=linux@roeck-us.net \
--cc=colin.king@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).