linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: uml-devel <user-mode-linux-devel@lists.sourceforge.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	markus.stenberg@iki.fi
Subject: Re: [PATCH] hostfs: Use correct mask for file mode
Date: Mon, 04 May 2015 15:25:30 +0200	[thread overview]
Message-ID: <5547734A.6070702@nod.at> (raw)
In-Reply-To: <CAMuHMdVEJPoBJmMV7EPLNBunpER86ZXKGSTfVDhR3y6GYM-xrg@mail.gmail.com>

Am 04.05.2015 um 15:22 schrieb Geert Uytterhoeven:
> On Mon, May 4, 2015 at 2:53 PM, Richard Weinberger <richard@nod.at> wrote:
>> --- a/fs/hostfs/hostfs_kern.c
>> +++ b/fs/hostfs/hostfs_kern.c
>> @@ -581,7 +581,7 @@ static int hostfs_create(struct inode *dir, struct dentry *dentry, umode_t mode,
>>         if (name == NULL)
>>                 goto out_put;
>>
>> -       fd = file_create(name, mode & S_IFMT);
>> +       fd = file_create(name, mode & 0777);
> 
> "(S_IRWXU | S_IRWXG | S_IRWXO)"?

I thought about that too but did not see a real benefit
as 0777 is well known and self describing.

Thanks,
//richard

      reply	other threads:[~2015-05-04 13:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-04 12:53 [PATCH] hostfs: Use correct mask for file mode Richard Weinberger
2015-05-04 13:22 ` Geert Uytterhoeven
2015-05-04 13:25   ` Richard Weinberger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5547734A.6070702@nod.at \
    --to=richard@nod.at \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus.stenberg@iki.fi \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).