From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Liu Ying <Ying.Liu@freescale.com>, <linux-fbdev@vger.kernel.org>
Cc: Peter Chen <peter.chen@freescale.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Fabio Estevam <fabio.estevam@freescale.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH v4] video: mxsfb: Make sure axi clock is enabled when accessing registers
Date: Thu, 7 May 2015 14:00:26 +0300 [thread overview]
Message-ID: <554B45CA.2010103@ti.com> (raw)
In-Reply-To: <1428036665-14454-1-git-send-email-Ying.Liu@freescale.com>
[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]
On 03/04/15 07:51, Liu Ying wrote:
> The LCDIF engines embedded in i.MX6sl and i.MX6sx SoCs need the axi clock
> as the engine's system clock. The clock should be enabled when accessing
> LCDIF registers, otherwise the kernel would hang up. We should also keep
> the clock enabled when the engine is being active to scan out frames from
> memory. This patch makes sure the axi clock is enabled when accessing
> registers so that the kernel hang up issue can be fixed.
>
> Reported-by: Peter Chen <peter.chen@freescale.com>
> Tested-by: Peter Chen <peter.chen@freescale.com>
> Cc: <stable@vger.kernel.org> # 3.19+
> Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
> ---
> v3->v4:
> * To address Tomi's comment, enable/disable the axi clock in
> mxsfb_pan_display() directly instead of checking the host->enabled flag.
>
> v2->v3:
> * To address Tomi's comment, improve the commit message only.
>
> v1->v2:
> * Add 'Tested-by: Peter Chen <peter.chen@freescale.com>' tag.
> * Add 'Cc: <stable@vger.kernel.org> # 3.19+' tag.
>
> drivers/video/fbdev/mxsfb.c | 68 +++++++++++++++++++++++++++++++++++----------
> 1 file changed, 54 insertions(+), 14 deletions(-)
Thanks, queued for 4.2.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-05-07 11:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 4:51 [PATCH v4] video: mxsfb: Make sure axi clock is enabled when accessing registers Liu Ying
2015-05-07 11:00 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554B45CA.2010103@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=Ying.Liu@freescale.com \
--cc=fabio.estevam@freescale.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.chen@freescale.com \
--cc=plagnioj@jcrosoft.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).