* [PATCH 1/1] ARM: dts: Make DP a consumer of DISP1 power domain on Exynos5420
@ 2015-04-12 20:30 Javier Martinez Canillas
2015-04-13 10:59 ` Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Javier Martinez Canillas @ 2015-04-12 20:30 UTC (permalink / raw)
To: Kukjin Kim
Cc: Doug Anderson, Olof Johansson, Krzysztof Kozlowski,
Andrzej Hajda, Kevin Hilman, Tyler Baker, linux-arm-kernel,
linux-samsung-soc, linux-kernel, Javier Martinez Canillas
Commit ea08de16eb1b ("ARM: dts: Add DISP1 power domain for exynos5420")
added a device node for the Exynos5420 DISP1 power domain but dit not
make the DP controller a consumer of that power domain.
This causes an "Unhandled fault: imprecise external abort" error if the
exynos-dp driver tries to access the DP controller registers and the PD
was turned off. This lead to a kernel panic and a complete system hang.
Make the DP controller device node a consumer of the DISP1 power domain
to ensure that the PD is turned on when the exynos-dp driver is probed.
Fixes: ea08de16eb1b ("ARM: dts: Add DISP1 power domain for exynos5420")
Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
---
Hello,
This latent bug was not exposed before since drivers for other devices
marked as DISP1 power domain consumers were probed before exynos-dp so
the PD was already on which made possible to access the DP registers.
But "regulator: Defer lookup of supply to regulator_get" [0] that is in
linux-next from a couple of days now, changed the order on which the
drivers' probes succeed so the PD was disabled during exynos-dp probe.
Exynos5420 machines with a display such as the Exynos5420 Peach Pit and
Exynos5800 Peach Pi were failing to boot due this issue, i.e: [1].
Olof,
Could you please confirm $subject fixes the issue catched by your farm?
Krzysztof,
This patch conflicts with your Exynos5 phandle notation cleanup [2] but
I preferred to send it on top of linux-next instead of making your series
a dependency since it fixes a very important bug that had caused -next to
be broken on these matchines for days now.
Thanks a lot and best regards,
Javier
[0]: https://lkml.org/lkml/2015/3/24/1167
[1]: http://arm-soc.lixom.net/bootlogs/next/next-20150409/pi-arm-exynos_defconfig.html
[2]: https://lkml.org/lkml/2015/4/12/49
arch/arm/boot/dts/exynos5420.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index f67b23f303c3..45317538bbae 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -536,6 +536,7 @@
clock-names = "dp";
phys = <&dp_phy>;
phy-names = "dp";
+ power-domains = <&disp_pd>;
};
mipi_phy: video-phy@10040714 {
--
2.1.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] ARM: dts: Make DP a consumer of DISP1 power domain on Exynos5420
2015-04-12 20:30 [PATCH 1/1] ARM: dts: Make DP a consumer of DISP1 power domain on Exynos5420 Javier Martinez Canillas
@ 2015-04-13 10:59 ` Krzysztof Kozlowski
2015-04-16 7:40 ` Javier Martinez Canillas
2015-05-08 17:32 ` Kukjin Kim
2 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2015-04-13 10:59 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: Kukjin Kim, Doug Anderson, Olof Johansson, Krzysztof Kozlowski,
Andrzej Hajda, Kevin Hilman, Tyler Baker, linux-arm-kernel,
linux-samsung-soc, linux-kernel
2015-04-13 5:30 GMT+09:00 Javier Martinez Canillas
<javier.martinez@collabora.co.uk>:
> Commit ea08de16eb1b ("ARM: dts: Add DISP1 power domain for exynos5420")
> added a device node for the Exynos5420 DISP1 power domain but dit not
> make the DP controller a consumer of that power domain.
>
> This causes an "Unhandled fault: imprecise external abort" error if the
> exynos-dp driver tries to access the DP controller registers and the PD
> was turned off. This lead to a kernel panic and a complete system hang.
>
> Make the DP controller device node a consumer of the DISP1 power domain
> to ensure that the PD is turned on when the exynos-dp driver is probed.
>
> Fixes: ea08de16eb1b ("ARM: dts: Add DISP1 power domain for exynos5420")
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
>
> Hello,
>
> This latent bug was not exposed before since drivers for other devices
> marked as DISP1 power domain consumers were probed before exynos-dp so
> the PD was already on which made possible to access the DP registers.
>
> But "regulator: Defer lookup of supply to regulator_get" [0] that is in
> linux-next from a couple of days now, changed the order on which the
> drivers' probes succeed so the PD was disabled during exynos-dp probe.
>
> Exynos5420 machines with a display such as the Exynos5420 Peach Pit and
> Exynos5800 Peach Pi were failing to boot due this issue, i.e: [1].
>
> Olof,
>
> Could you please confirm $subject fixes the issue catched by your farm?
>
> Krzysztof,
>
> This patch conflicts with your Exynos5 phandle notation cleanup [2] but
> I preferred to send it on top of linux-next instead of making your series
> a dependency since it fixes a very important bug that had caused -next to
> be broken on these matchines for days now.
Sure, I don't mind. My patchset is just a cleanup so it can wait and
should not block important stuff.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] ARM: dts: Make DP a consumer of DISP1 power domain on Exynos5420
2015-04-12 20:30 [PATCH 1/1] ARM: dts: Make DP a consumer of DISP1 power domain on Exynos5420 Javier Martinez Canillas
2015-04-13 10:59 ` Krzysztof Kozlowski
@ 2015-04-16 7:40 ` Javier Martinez Canillas
2015-04-30 0:32 ` Javier Martinez Canillas
2015-05-08 17:32 ` Kukjin Kim
2 siblings, 1 reply; 8+ messages in thread
From: Javier Martinez Canillas @ 2015-04-16 7:40 UTC (permalink / raw)
To: Kukjin Kim
Cc: Doug Anderson, Olof Johansson, Krzysztof Kozlowski,
Andrzej Hajda, Kevin Hilman, Tyler Baker, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Hello Kukjin,
On 04/12/2015 10:30 PM, Javier Martinez Canillas wrote:
> Commit ea08de16eb1b ("ARM: dts: Add DISP1 power domain for exynos5420")
> added a device node for the Exynos5420 DISP1 power domain but dit not
> make the DP controller a consumer of that power domain.
>
> This causes an "Unhandled fault: imprecise external abort" error if the
> exynos-dp driver tries to access the DP controller registers and the PD
> was turned off. This lead to a kernel panic and a complete system hang.
>
> Make the DP controller device node a consumer of the DISP1 power domain
> to ensure that the PD is turned on when the exynos-dp driver is probed.
>
> Fixes: ea08de16eb1b ("ARM: dts: Add DISP1 power domain for exynos5420")
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Any comments about this patch?
It's very trivial but fixes a very important regression on Exynos5420 boards
with display panel and Peach Pit and Pi have been broken since next-20150401.
This [0] is the Peach Pit boot log with yesteday's linux-next for example.
Best regards,
Javier
[0]: http://arm-soc.lixom.net/bootlogs/next/next-20150415/pit-arm-exynos_defconfig.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] ARM: dts: Make DP a consumer of DISP1 power domain on Exynos5420
2015-04-16 7:40 ` Javier Martinez Canillas
@ 2015-04-30 0:32 ` Javier Martinez Canillas
2015-04-30 0:36 ` Kukjin Kim
0 siblings, 1 reply; 8+ messages in thread
From: Javier Martinez Canillas @ 2015-04-30 0:32 UTC (permalink / raw)
To: Kukjin Kim, kgene.kim
Cc: Doug Anderson, Olof Johansson, Krzysztof Kozlowski,
Andrzej Hajda, Kevin Hilman, Tyler Baker, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Hello Kukjin,
On 04/16/2015 09:40 AM, Javier Martinez Canillas wrote:
>
> On 04/12/2015 10:30 PM, Javier Martinez Canillas wrote:
>> Commit ea08de16eb1b ("ARM: dts: Add DISP1 power domain for exynos5420")
>> added a device node for the Exynos5420 DISP1 power domain but dit not
>> make the DP controller a consumer of that power domain.
>>
>> This causes an "Unhandled fault: imprecise external abort" error if the
>> exynos-dp driver tries to access the DP controller registers and the PD
>> was turned off. This lead to a kernel panic and a complete system hang.
>>
>> Make the DP controller device node a consumer of the DISP1 power domain
>> to ensure that the PD is turned on when the exynos-dp driver is probed.
>>
>> Fixes: ea08de16eb1b ("ARM: dts: Add DISP1 power domain for exynos5420")
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>
> Any comments about this patch?
>
> It's very trivial but fixes a very important regression on Exynos5420 boards
> with display panel and Peach Pit and Pi have been broken since next-20150401.
>
> This [0] is the Peach Pit boot log with yesteday's linux-next for example.
>
> Best regards,
> Javier
>
> [0]: http://arm-soc.lixom.net/bootlogs/next/next-20150415/pit-arm-exynos_defconfig.html
>
It has been many weeks since this patch has been posted and linux-next
is still broken:
http://arm-soc.lixom.net/bootlogs/next/next-20150429/pi-arm-exynos_defconfig.html
Could you please apply $subject to fix the imprecise external abort issue.
Best regards,
Javier
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH 1/1] ARM: dts: Make DP a consumer of DISP1 power domain on Exynos5420
2015-04-30 0:32 ` Javier Martinez Canillas
@ 2015-04-30 0:36 ` Kukjin Kim
2015-04-30 15:43 ` Kevin Hilman
2015-05-04 15:57 ` Kevin Hilman
0 siblings, 2 replies; 8+ messages in thread
From: Kukjin Kim @ 2015-04-30 0:36 UTC (permalink / raw)
To: 'Javier Martinez Canillas', 'Kukjin Kim'
Cc: 'Doug Anderson', 'Olof Johansson',
'Krzysztof Kozlowski', 'Andrzej Hajda',
'Kevin Hilman', 'Tyler Baker',
linux-arm-kernel, linux-samsung-soc, linux-kernel
Javier Martinez Canillas wrote:
>
> Hello Kukjin,
>
Hi,
> On 04/16/2015 09:40 AM, Javier Martinez Canillas wrote:
> >
> > On 04/12/2015 10:30 PM, Javier Martinez Canillas wrote:
> >> Commit ea08de16eb1b ("ARM: dts: Add DISP1 power domain for exynos5420")
> >> added a device node for the Exynos5420 DISP1 power domain but dit not
> >> make the DP controller a consumer of that power domain.
> >>
> >> This causes an "Unhandled fault: imprecise external abort" error if the
> >> exynos-dp driver tries to access the DP controller registers and the PD
> >> was turned off. This lead to a kernel panic and a complete system hang.
> >>
> >> Make the DP controller device node a consumer of the DISP1 power domain
> >> to ensure that the PD is turned on when the exynos-dp driver is probed.
> >>
> >> Fixes: ea08de16eb1b ("ARM: dts: Add DISP1 power domain for exynos5420")
> >> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> >
> > Any comments about this patch?
> >
> > It's very trivial but fixes a very important regression on Exynos5420 boards
> > with display panel and Peach Pit and Pi have been broken since next-20150401.
> >
> > This [0] is the Peach Pit boot log with yesteday's linux-next for example.
> >
> > Best regards,
> > Javier
> >
> > [0]: http://arm-soc.lixom.net/bootlogs/next/next-20150415/pit-arm-exynos_defconfig.html
> >
>
> It has been many weeks since this patch has been posted and linux-next
> is still broken:
>
> http://arm-soc.lixom.net/bootlogs/next/next-20150429/pi-arm-exynos_defconfig.html
>
> Could you please apply $subject to fix the imprecise external abort issue.
>
Sure I'll in this weekend.
Thanks for your gentle reminder ;-)
- Kukjin
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] ARM: dts: Make DP a consumer of DISP1 power domain on Exynos5420
2015-04-30 0:36 ` Kukjin Kim
@ 2015-04-30 15:43 ` Kevin Hilman
2015-05-04 15:57 ` Kevin Hilman
1 sibling, 0 replies; 8+ messages in thread
From: Kevin Hilman @ 2015-04-30 15:43 UTC (permalink / raw)
To: Kukjin Kim
Cc: 'Javier Martinez Canillas', 'Doug Anderson',
'Olof Johansson', 'Krzysztof Kozlowski',
'Andrzej Hajda', 'Tyler Baker',
linux-arm-kernel, linux-samsung-soc, linux-kernel
Kukjin Kim <kgene@kernel.org> writes:
> Javier Martinez Canillas wrote:
>>
>> Hello Kukjin,
>>
> Hi,
>
>> On 04/16/2015 09:40 AM, Javier Martinez Canillas wrote:
>> >
>> > On 04/12/2015 10:30 PM, Javier Martinez Canillas wrote:
>> >> Commit ea08de16eb1b ("ARM: dts: Add DISP1 power domain for exynos5420")
>> >> added a device node for the Exynos5420 DISP1 power domain but dit not
>> >> make the DP controller a consumer of that power domain.
>> >>
>> >> This causes an "Unhandled fault: imprecise external abort" error if the
>> >> exynos-dp driver tries to access the DP controller registers and the PD
>> >> was turned off. This lead to a kernel panic and a complete system hang.
>> >>
>> >> Make the DP controller device node a consumer of the DISP1 power domain
>> >> to ensure that the PD is turned on when the exynos-dp driver is probed.
>> >>
>> >> Fixes: ea08de16eb1b ("ARM: dts: Add DISP1 power domain for exynos5420")
>> >> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>> >
>> > Any comments about this patch?
>> >
>> > It's very trivial but fixes a very important regression on Exynos5420 boards
>> > with display panel and Peach Pit and Pi have been broken since next-20150401.
>> >
>> > This [0] is the Peach Pit boot log with yesteday's linux-next for example.
>> >
>> > Best regards,
>> > Javier
>> >
>> > [0]: http://arm-soc.lixom.net/bootlogs/next/next-20150415/pit-arm-exynos_defconfig.html
>> >
>>
>> It has been many weeks since this patch has been posted and linux-next
>> is still broken:
>>
>> http://arm-soc.lixom.net/bootlogs/next/next-20150429/pi-arm-exynos_defconfig.html
>>
>> Could you please apply $subject to fix the imprecise external abort issue.
>>
> Sure I'll in this weekend.
>
> Thanks for your gentle reminder ;-)
Tested-by: Kevin Hilman <khilman@linaro.org>
I confirm that this patch fixes the imprecise aborts (and sometimes
kernel panics) that I'm seeing on exynos5800-peach-pi with linux-next.
Kevin
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] ARM: dts: Make DP a consumer of DISP1 power domain on Exynos5420
2015-04-30 0:36 ` Kukjin Kim
2015-04-30 15:43 ` Kevin Hilman
@ 2015-05-04 15:57 ` Kevin Hilman
1 sibling, 0 replies; 8+ messages in thread
From: Kevin Hilman @ 2015-05-04 15:57 UTC (permalink / raw)
To: Kukjin Kim
Cc: Javier Martinez Canillas, Doug Anderson, Olof Johansson,
Krzysztof Kozlowski, Andrzej Hajda, Kevin Hilman, Tyler Baker,
linux-arm-kernel, linux-samsung-soc, lkml
Hi Kukjin,
On Wed, Apr 29, 2015 at 5:36 PM, Kukjin Kim <kgene@kernel.org> wrote:
[...]
>>
>> Could you please apply $subject to fix the imprecise external abort issue.
>>
> Sure I'll in this weekend.
This patch is still not in linux-next.
Also I think this fix is needed as a fix for mainline v4.1-rc as well,
where the same is happening.
Krzysztof has generously offered to help collecting/queuing/submitting
patches to help improve the maintenance of exynos. Please work
closely with him share the responsibility of improving the state of
mainline exynos support.
Thanks,
Kevin
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] ARM: dts: Make DP a consumer of DISP1 power domain on Exynos5420
2015-04-12 20:30 [PATCH 1/1] ARM: dts: Make DP a consumer of DISP1 power domain on Exynos5420 Javier Martinez Canillas
2015-04-13 10:59 ` Krzysztof Kozlowski
2015-04-16 7:40 ` Javier Martinez Canillas
@ 2015-05-08 17:32 ` Kukjin Kim
2 siblings, 0 replies; 8+ messages in thread
From: Kukjin Kim @ 2015-05-08 17:32 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: Kukjin Kim, Doug Anderson, Olof Johansson, Krzysztof Kozlowski,
Andrzej Hajda, Kevin Hilman, Tyler Baker, linux-arm-kernel,
linux-samsung-soc, linux-kernel
On 04/13/15 05:30, Javier Martinez Canillas wrote:
> Commit ea08de16eb1b ("ARM: dts: Add DISP1 power domain for exynos5420")
> added a device node for the Exynos5420 DISP1 power domain but dit not
> make the DP controller a consumer of that power domain.
>
> This causes an "Unhandled fault: imprecise external abort" error if the
> exynos-dp driver tries to access the DP controller registers and the PD
> was turned off. This lead to a kernel panic and a complete system hang.
>
> Make the DP controller device node a consumer of the DISP1 power domain
> to ensure that the PD is turned on when the exynos-dp driver is probed.
>
> Fixes: ea08de16eb1b ("ARM: dts: Add DISP1 power domain for exynos5420")
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
>
> Hello,
>
> This latent bug was not exposed before since drivers for other devices
> marked as DISP1 power domain consumers were probed before exynos-dp so
> the PD was already on which made possible to access the DP registers.
>
> But "regulator: Defer lookup of supply to regulator_get" [0] that is in
> linux-next from a couple of days now, changed the order on which the
> drivers' probes succeed so the PD was disabled during exynos-dp probe.
>
> Exynos5420 machines with a display such as the Exynos5420 Peach Pit and
> Exynos5800 Peach Pi were failing to boot due this issue, i.e: [1].
>
> Olof,
>
> Could you please confirm $subject fixes the issue catched by your farm?
>
> Krzysztof,
>
> This patch conflicts with your Exynos5 phandle notation cleanup [2] but
> I preferred to send it on top of linux-next instead of making your series
> a dependency since it fixes a very important bug that had caused -next to
> be broken on these matchines for days now.
>
> Thanks a lot and best regards,
> Javier
>
> [0]: https://lkml.org/lkml/2015/3/24/1167
> [1]: http://arm-soc.lixom.net/bootlogs/next/next-20150409/pi-arm-exynos_defconfig.html
> [2]: https://lkml.org/lkml/2015/4/12/49
>
> arch/arm/boot/dts/exynos5420.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index f67b23f303c3..45317538bbae 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -536,6 +536,7 @@
> clock-names = "dp";
> phys = <&dp_phy>;
> phy-names = "dp";
> + power-domains = <&disp_pd>;
> };
>
> mipi_phy: video-phy@10040714 {
Sorry for the late response. I've applied in -fixes and will be sent to
arm-soc soon. Thanks.
- Kukjin
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-05-08 17:33 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-12 20:30 [PATCH 1/1] ARM: dts: Make DP a consumer of DISP1 power domain on Exynos5420 Javier Martinez Canillas
2015-04-13 10:59 ` Krzysztof Kozlowski
2015-04-16 7:40 ` Javier Martinez Canillas
2015-04-30 0:32 ` Javier Martinez Canillas
2015-04-30 0:36 ` Kukjin Kim
2015-04-30 15:43 ` Kevin Hilman
2015-05-04 15:57 ` Kevin Hilman
2015-05-08 17:32 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).