From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753176AbbEHXhl (ORCPT ); Fri, 8 May 2015 19:37:41 -0400 Received: from mga09.intel.com ([134.134.136.24]:23964 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752165AbbEHXhk (ORCPT ); Fri, 8 May 2015 19:37:40 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,393,1427785200"; d="scan'208";a="723088175" Message-ID: <554D48C2.4070402@linux.intel.com> Date: Sat, 09 May 2015 07:37:38 +0800 From: "Lu, Baolu" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Greg Kroah-Hartman CC: Mathias Nyman , Alan Stern , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/3] usb: xhci: remove stop device and ring doorbell in hub control and bus suspend References: <1431080788-20674-1-git-send-email-baolu.lu@linux.intel.com> <1431080788-20674-4-git-send-email-baolu.lu@linux.intel.com> <20150508110112.GB30150@kroah.com> In-Reply-To: <20150508110112.GB30150@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/08/2015 07:01 PM, Greg Kroah-Hartman wrote: > On Fri, May 08, 2015 at 06:26:28PM +0800, Lu Baolu wrote: >> There is no need to call xhci_stop_device() and xhci_ring_device() in >> hub control and bus suspend functions since all device suspend and >> resume have been notified through device_suspend/device_resume interfaces. > Does this mean that after patch 2, things are broken and require this > patch to prevent problems? No. things work well without patch 3. "stop device" and "ring doorbell" operations in hub control and bus suspend is harmless, but duplicated and unnecessary, so I remove them. > > I don't want to have any patch to make the system unstable. > > thanks, > > greg k-h Thank you, Baolu > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > >