From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753150AbdKIPxw (ORCPT ); Thu, 9 Nov 2017 10:53:52 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:59911 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753090AbdKIPxr (ORCPT ); Thu, 9 Nov 2017 10:53:47 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20171109155345epoutp0126189677a355de4d62d86c890aa35292~1ddk0MPSy2885028850epoutp01G X-AuditID: b6c32a48-8edff7000000103e-5a-5a047a0809d0 From: Bartlomiej Zolnierkiewicz To: Colin King Cc: Maik Broemme , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video: fbdev: intelfb: remove redundant variables Date: Thu, 09 Nov 2017 16:53:42 +0100 Message-id: <5552409.pVDogND5TS@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20171106131711.6499-1-colin.king@canonical.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrPIsWRmVeSWpSXmKPExsWy7bCmmS5HFUuUwaRdOha/V/eyWVz5+p7N YustaYsTfR9YLS7vmsNm8eskkwObx6yGXjaP6z9vMHnc7z7O5PF5k1wASxSXTUpqTmZZapG+ XQJXxo5zS5kKVrJVPNn6gqWBcTFrFyMnh4SAicTWX6/Zuhi5OIQEdjBKvF63gRHC+c4ocWbt emaYqnXf/rJAJDYwSpy4NosZwvnKKPFz9l4mkCo2ASuJie2rgNo5OEQENCXOnysCCTMLLGeU aL+jCmILC7hJfPx6D2woi4CqxMv+P4wgNi9Q+d+V/8BOEhXwktiyrx1sJKeArcSFjYfYIGoE JX5MvscCMVNeYt/+qawQto7E2WPrwK6WENjAJtG++xcbxNUuEktnPYWyhSVeHd/CDmFLSzxb tZERwp7OKLH9twRE82ZGiVW7J0AVWUscPn4RagOfRMfhv+wgj0kI8Ep0tAlBlHhIPN07DxpC jhLdzyB2CQlMYJR43qs8gVF2FpK7ZyG5exaSuxcwMq9iFEstKM5NTy02KjDRK07MLS7NS9dL zs/dxAhOBloeOxgPnPM5xCjAwajEw/tiFXOUEGtiWXFl7iFGCQ5mJRFe0xyWKCHelMTKqtSi /Pii0pzU4kOM0hwsSuK8dduuRQgJpCeWpGanphakFsFkmTg4pRoYzc/8LE599mnOS+bzps8W zblqVTxtv/uctfVHmHi9zydPUHgUGlZdPod/f87pp+pXZuicX9hWlrR8VVBcjur3ia1OXoHq G+6k6DzVeeKye0as+zk7n18ixdz7et2SYy+l6V+3D61laX2sPddknrA938vMzj82r8oOfK50 14u+cD3QjvfFhmscSizFGYmGWsxFxYkAGqYqowIDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJLMWRmVeSWpSXmKPExsVy+t9jQV2OKpYog3/fWCx+r+5ls7jy9T2b xdZb0hYn+j6wWlzeNYfN4tdJJgc2j1kNvWwe13/eYPK4332cyePzJrkAligum5TUnMyy1CJ9 uwSujB3nljIVrGSreLL1BUsD42LWLkZODgkBE4l13/6ydDFycQgJrGOU+L3kMyOE85VR4ujJ zUwgVWwCVhIT21cBJTg4RAQ0Jc6fKwKpYRZYzijx9FQfG0iNsICbxMev95hBbBYBVYmX/X8Y QWxeoPq/K/+BbRMV8JLYsq8dbCangK3EhY2H2CCWTWKUmLpxCwtEg6DEj8n3wGxmAXmJffun skLYWhLrdx5nmsDIPwtJ2SwkZbOQlC1gZF7FKJlaUJybnltsVGCUl1quV5yYW1yal66XnJ+7 iREYwNsOa/XvYHy8JP4QowAHoxIPr8Na5igh1sSy4srcQ4wSHMxKIrymOSxRQrwpiZVVqUX5 8UWlOanFhxilOViUxHn5849FCgmkJ5akZqemFqQWwWSZODilGhj9g19ZMnUcSczkFzyvZrQ8 7Pl9pxjpyZyBH1mWT/3UdevAcWWfHydKqs1Z1uhx3Yj7uGFulfz7v6bG06Jv+l1utpPX1r2k HvLXXY696+aPsFmK2qomJiuOmoqrvexReyV/+/oFoeXljdf5um6xaKkuYsy6Py3+7Law/PtH JtbemFUzZbGT2CUlluKMREMt5qLiRACQJRKWXAIAAA== X-CMS-MailID: 20171109155344epcas2p35b98914dbf5703dec1ad15bf98290b64 X-Msg-Generator: CA CMS-TYPE: 102P X-CMS-RootMailID: 20171106131737epcas3p2c8da62f9f262825461ca244b597a863f X-RootMTR: 20171106131737epcas3p2c8da62f9f262825461ca244b597a863f References: <20171106131711.6499-1-colin.king@canonical.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, November 06, 2017 01:17:11 PM Colin King wrote: > From: Colin Ian King > > Variables err_max, err_target and f_best are being assigned values but > these are never read, hence they are redundant variables and can be > removed. Cleans up clang warnings: > > drivers/video/fbdev/intelfb/intelfbhw.c:946:2: warning: Value stored to > 'err_max' is never read > drivers/video/fbdev/intelfb/intelfbhw.c:947:2: warning: Value stored to > 'err_target' is never read > drivers/video/fbdev/intelfb/intelfbhw.c:995:6: warning: Value stored to > 'f_best' is never read > > Signed-off-by: Colin Ian King Patch queued for 4.15, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics