From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Len Brown <lenb@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
microblaze-uclinux@itee.uq.edu.au
Subject: Re: [PATCH] microblaze idle: Fix compile error
Date: Thu, 21 Feb 2013 17:25:17 +0100 [thread overview]
Message-ID: <5556573.chQEm97ICB@vostro.rjw.lan> (raw)
In-Reply-To: <1361441731-19900-1-git-send-email-lars@metafoo.de>
On Thursday, February 21, 2013 11:15:31 AM Lars-Peter Clausen wrote:
> Commit def8203 ("microblaze idle: delete pm_idle") introduced the following
> compile error:
>
> arch/microblaze/kernel/process.c: In function 'cpu_idle':
> arch/microblaze/kernel/process.c:100: error: 'idle' undeclared (first use in this function)
> arch/microblaze/kernel/process.c:100: error: (Each undeclared identifier is reported only once
> arch/microblaze/kernel/process.c:100: error: for each function it appears in.)
> arch/microblaze/kernel/process.c:106: error: implicit declaration of function 'idle'
>
> This patch fixes it.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Applied to linux-pm.git/linux-next, I'm going to push it to Linus later this
week.
Thanks,
Rafael
> ---
> arch/microblaze/kernel/process.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/arch/microblaze/kernel/process.c b/arch/microblaze/kernel/process.c
> index 6ff2dcf..08f8734 100644
> --- a/arch/microblaze/kernel/process.c
> +++ b/arch/microblaze/kernel/process.c
> @@ -97,13 +97,10 @@ void cpu_idle(void)
>
> /* endless idle loop with no priority at all */
> while (1) {
> - if (!idle)
> - idle = default_idle;
> -
> tick_nohz_idle_enter();
> rcu_idle_enter();
> while (!need_resched())
> - idle();
> + default_idle();
> rcu_idle_exit();
> tick_nohz_idle_exit();
>
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2013-02-21 16:18 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-10 5:58 pm_idle cleanup patch series Len Brown
2013-02-10 5:58 ` [PATCH 01/16] APM idle: register apm_cpu_idle via cpuidle Len Brown
2013-02-10 5:58 ` [PATCH 02/16] x86 idle: rename global pm_idle to static x86_idle Len Brown
2013-02-10 5:58 ` [PATCH 03/16] sh idle: rename global pm_idle to static sh_idle Len Brown
2013-02-10 5:58 ` [PATCH 04/16] sparc idle: rename pm_idle to sparc_idle Len Brown
2013-02-10 23:08 ` David Miller
2013-02-10 5:58 ` [PATCH 05/16] blackfin idle: delete pm_idle Len Brown
2013-02-18 16:28 ` Lars-Peter Clausen
2013-02-20 17:53 ` Len Brown
2013-02-20 19:52 ` Rafael J. Wysocki
2013-02-20 19:53 ` Lars-Peter Clausen
2013-02-20 19:59 ` Rafael J. Wysocki
2013-02-20 20:21 ` Lars-Peter Clausen
2013-02-20 21:18 ` Rafael J. Wysocki
2013-02-21 9:56 ` [PATCH] blackfin idle: Fix compile error Lars-Peter Clausen
2013-02-21 16:24 ` Rafael J. Wysocki
2013-02-10 5:58 ` [PATCH 06/16] ARM idle: delete pm_idle Len Brown
2013-02-11 16:02 ` Catalin Marinas
2013-02-11 16:11 ` Russell King - ARM Linux
2013-02-11 22:42 ` Len Brown
2013-02-12 22:04 ` Kevin Hilman
2013-02-10 5:58 ` [PATCH 07/16] ARM64 " Len Brown
2013-02-12 11:03 ` Catalin Marinas
2013-02-10 5:58 ` [PATCH 08/16] cris idle: delete idle and pm_idle Len Brown
2013-02-11 8:42 ` Jesper Nilsson
2013-02-10 5:58 ` [PATCH 09/16] ia64 idle: delete pm_idle Len Brown
2013-02-21 10:15 ` Lars-Peter Clausen
2013-03-26 3:12 ` Brown, Len
2013-03-26 4:29 ` [PATCH] ia64 idle: delete (*idle)() Len Brown
2013-02-10 5:58 ` [PATCH 10/16] m32r idle: delete pm_idle, and other dead idle code Len Brown
2013-02-10 5:58 ` [PATCH 11/16] microblaze idle: delete pm_idle Len Brown
2013-02-21 10:15 ` [PATCH] microblaze idle: Fix compile error Lars-Peter Clausen
2013-02-21 16:25 ` Rafael J. Wysocki [this message]
2013-02-10 5:58 ` [PATCH 12/16] mn10300 idle: delete pm_idle Len Brown
2013-02-10 5:58 ` [PATCH 13/16] openrisc " Len Brown
2013-02-10 17:31 ` [ORLinux] " Jonas Bonn
2013-02-10 5:58 ` [PATCH 14/16] unicore32 idle: delete stray pm_idle comment Len Brown
2013-02-10 5:58 ` [PATCH 15/16] PM idle: remove global declaration of pm_idle Len Brown
2013-02-10 5:58 ` [PATCH 16/16] xen idle: make xen-specific macro xen-specific Len Brown
2013-02-11 9:18 ` [PATCH 01/16] APM idle: register apm_cpu_idle via cpuidle Daniel Lezcano
2013-02-11 22:50 ` Len Brown
2013-02-11 23:03 ` APM: Request to Test Len Brown
2013-02-11 23:03 ` [PATCH v2] APM idle: register apm_cpu_idle via cpuidle Len Brown
2013-02-12 15:00 ` Daniel Lezcano
2013-02-18 13:30 ` Jiri Kosina
2013-02-20 17:48 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5556573.chQEm97ICB@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=lars@metafoo.de \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=microblaze-uclinux@itee.uq.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).