From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754559AbbERSV1 (ORCPT ); Mon, 18 May 2015 14:21:27 -0400 Received: from mail-pd0-f173.google.com ([209.85.192.173]:35801 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753857AbbERSVY (ORCPT ); Mon, 18 May 2015 14:21:24 -0400 Message-ID: <555A2DA1.1000802@plumgrid.com> Date: Mon, 18 May 2015 11:21:21 -0700 From: Alexei Starovoitov User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Wang Nan , paulus@samba.org, a.p.zijlstra@chello.nl, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org, jolsa@kernel.org, dsahern@gmail.com, daniel@iogearbox.net, brendan.d.gregg@gmail.com, masami.hiramatsu.pt@hitachi.com CC: lizefan@huawei.com, linux-kernel@vger.kernel.org, pi3orama@163.com Subject: Re: [RFC PATCH v3 11/37] bpf tools: Iterate over ELF sections to collect information References: <1431860222-61636-1-git-send-email-wangnan0@huawei.com> <1431860222-61636-12-git-send-email-wangnan0@huawei.com> In-Reply-To: <1431860222-61636-12-git-send-email-wangnan0@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/17/15 3:56 AM, Wang Nan wrote: > bpf_obj_elf_collect() is introduced to iterate over each elf sections > to collection informations in eBPF object files. This function will > futher enhanced to collect license, kernel version, programs, configs > and map information. > > Signed-off-by: Wang Nan ... > + if (gelf_getshdr(scn, &sh) != &sh) { > + pr_warning("failed to get section header" > + " from %s\n", obj->path); please don't wrap strings. Here and in all other patches.