From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754760AbbERSgM (ORCPT ); Mon, 18 May 2015 14:36:12 -0400 Received: from mail-ig0-f180.google.com ([209.85.213.180]:35237 "EHLO mail-ig0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754469AbbERSgK (ORCPT ); Mon, 18 May 2015 14:36:10 -0400 Message-ID: <555A3117.2000708@plumgrid.com> Date: Mon, 18 May 2015 11:36:07 -0700 From: Alexei Starovoitov User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Wang Nan , paulus@samba.org, a.p.zijlstra@chello.nl, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org, jolsa@kernel.org, dsahern@gmail.com, daniel@iogearbox.net, brendan.d.gregg@gmail.com, masami.hiramatsu.pt@hitachi.com CC: lizefan@huawei.com, linux-kernel@vger.kernel.org, pi3orama@163.com Subject: Re: [RFC PATCH v3 19/37] bpf tools: Clear libelf and ELF parsing resrouce to finish opening References: <1431860222-61636-1-git-send-email-wangnan0@huawei.com> <1431860222-61636-20-git-send-email-wangnan0@huawei.com> In-Reply-To: <1431860222-61636-20-git-send-email-wangnan0@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/17/15 3:56 AM, Wang Nan wrote: > After all eBPF programs in an object file are loaded, related ELF > information is useless. Close the object file and free those memory. > > Signed-off-by: Wang Nan > --- > tools/lib/bpf/libbpf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c > index ded96cb..9ed8cca 100644 > --- a/tools/lib/bpf/libbpf.c > +++ b/tools/lib/bpf/libbpf.c > @@ -687,8 +687,8 @@ struct bpf_object *bpf_open_object(const char *path) > if (bpf_obj_validate(obj)) > goto out; > > + bpf_obj_clear_elf(obj); > return obj; > - > out: > bpf_close_object(obj); > return NULL; > looks like a bug in some previous patch in the same set. Should be squashed with that patch?