From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932850AbbERUvm (ORCPT ); Mon, 18 May 2015 16:51:42 -0400 Received: from mail-pd0-f176.google.com ([209.85.192.176]:34674 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932494AbbERUvj (ORCPT ); Mon, 18 May 2015 16:51:39 -0400 Message-ID: <555A50D8.1040202@plumgrid.com> Date: Mon, 18 May 2015 13:51:36 -0700 From: Alexei Starovoitov User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Arnaldo Carvalho de Melo CC: Wang Nan , paulus@samba.org, a.p.zijlstra@chello.nl, mingo@redhat.com, namhyung@kernel.org, jolsa@kernel.org, dsahern@gmail.com, daniel@iogearbox.net, brendan.d.gregg@gmail.com, masami.hiramatsu.pt@hitachi.com, lizefan@huawei.com, linux-kernel@vger.kernel.org, pi3orama@163.com Subject: Re: [RFC PATCH v3 12/37] bpf tools: Collect version and license from ELF sections References: <1431860222-61636-1-git-send-email-wangnan0@huawei.com> <1431860222-61636-13-git-send-email-wangnan0@huawei.com> <555A2F05.207@plumgrid.com> <20150518203431.GF18563@kernel.org> In-Reply-To: <20150518203431.GF18563@kernel.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/18/15 1:34 PM, Arnaldo Carvalho de Melo wrote: > > So, lets take a look at: tools/include/linux/kernel.h... bummer, that > one wasn't yet moved from tools/perf/util/include/linux/kernel.h there. > Will do, and then it has this: > > #ifndef min > #define min(x, y) ({ \ > typeof(x) _min1 = (x); \ > typeof(y) _min2 = (y); \ > (void) (&_min1 == &_min2); \ > _min1 < _min2 ? _min1 : _min2; }) > #endif > > We should minimize this mess :-) > yes. that's even better! Thanks!