From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932401AbbESM2P (ORCPT <rfc822;w@1wt.eu>);
	Tue, 19 May 2015 08:28:15 -0400
Received: from mailout4.samsung.com ([203.254.224.34]:42227 "EHLO
	mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754956AbbESM2J (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 19 May 2015 08:28:09 -0400
X-AuditID: cbfee68e-f79c56d000006efb-10-555b2c574a1d
Message-id: <555B2C56.8080105@samsung.com>
Date: Tue, 19 May 2015 21:28:06 +0900
From: Chanwoo Choi <cw00.choi@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106
 Thunderbird/17.0.2
MIME-version: 1.0
To: cw00.choi@samsung.com, Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Chanwoo Choi <cwchoi00@gmail.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
        Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
        gg@slimlogic.co.uk, Kishon Vijay Abraham I <kishon@ti.com>,
        jaewon02.kim@samsung.com, Roger Quadros <rogerq@ti.com>,
        "Pallala, Ramakrishna" <ramakrishna.pallala@intel.com>,
        george.cherian@ti.com, Felipe Balbi <balbi@ti.com>,
        Aaro Koskinen <aaro.koskinen@iki.fi>
Subject: Re: [PATCH 1/2] extcon: Use the unique id for external connector
 instead of string
References: <1431700278-30465-1-git-send-email-cw00.choi@samsung.com>
 <1431700278-30465-2-git-send-email-cw00.choi@samsung.com>
 <CAJKOXPfP0j9g-UkDPu26XjpKgRwMrdL6p99TykVQUHk6k0VDsg@mail.gmail.com>
 <CAGTfZH0ZHJGMM1OwEQXrA5NdJhK-iWdzxwFBDx+q62H3rdFsog@mail.gmail.com>
In-reply-to: <CAGTfZH0ZHJGMM1OwEQXrA5NdJhK-iWdzxwFBDx+q62H3rdFsog@mail.gmail.com>
Content-type: text/plain; charset=UTF-8
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrAIsWRmVeSWpSXmKPExsWyRsSkQDdcJzrUYO4zLYs1LxwsDt6vt/g3
	5Qa7xfUvz1ktnh3Vtjh1cDmrRf8WF4sdDUdYLV6/MLS48LSHzeLyrjlsFrcbV7BZLHxzk8mi
	55GWA5/Hzll32T0Of13I4rF4z0smj5cTf7N59G1ZxegxdcpfRo/jN7YzeXzeJBfAEcVlk5Ka
	k1mWWqRvl8CVsfbSKZaCBq6KC2t3szYw/mHvYuTgkBAwkTj4UqeLkRPIFJO4cG89WxcjF4eQ
	wFJGiRf79rJBJEwk3i1ewwqRmM4o8X/1QRYI5wGjxOe2bkaQSbwCWhKHT+uDNLAIqEocXbMI
	rJkNKLz/xQ0wW1QgTGLl9CssIDavgKDEj8n3wGwRAQ+Jvf13GEFmMgtcYZb48KOXESQhLBAr
	0T1tDiPEsn4miS/b94NN4hQIltj3ZxVYN7OAusSkeYuYIWx5ic1r3jKDNEgITOWQ2Hv+GTPE
	SQIS3yYfYoH4WVZi0wFmiNckJQ6uuMEygVFsFpKjZiEZOwvJ2AWMzKsYRVMLkguKk9KLjPSK
	E3OLS/PS9ZLzczcxAiP69L9nfTsYbx6wPsQowMGoxMMbUR8VKsSaWFZcmXuI0RToionMUqLJ
	+cC0kVcSb2hsZmRhamJqbGRuaaYkzpsg9TNYSCA9sSQ1OzW1ILUovqg0J7X4ECMTB6dUA+PG
	xCtV4V+9+w5Wbjf5UJe35v7sw9Jfvy56uabJ7X2q2OyqEN2/SdY6221qBeru7V92b0brS4Uv
	uzTlFwsrtoZ9Krhfu7fFc2Zh0P/51h8vuQZoNC0+PKek6AI7Q/7EH57WrGGij6X/79+kVBF/
	wVZmaUv65LmMOSrrtDKTvnyRu/yG58xRj71KLMUZiYZazEXFiQBYNUXJ4wIAAA==
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNKsWRmVeSWpSXmKPExsVy+t9jQd1wnehQg7V3VCzWvHCwOHi/3uLf
	lBvsFte/PGe1eHZU2+LUweWsFv1bXCx2NBxhtXj9wtDiwtMeNovLu+awWdxuXMFmsfDNTSaL
	nkdaDnweO2fdZfc4/HUhi8fiPS+ZPF5O/M3m0bdlFaPH1Cl/GT2O39jO5PF5k1wAR1QDo01G
	amJKapFCal5yfkpmXrqtkndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO0M1KCmWJOaVA
	oYDE4mIlfTtME0JD3HQtYBojdH1DguB6jAzQQMIaxoy1l06xFDRwVVxYu5u1gfEPexcjJ4eE
	gInEu8VrWCFsMYkL99azdTFycQgJTGeU+L/6IAuE84BR4nNbN2MXIwcHr4CWxOHT+iANLAKq
	EkfXLGIDsdmAwvtf3ACzRQXCJFZOv8ICYvMKCEr8mHwPzBYR8JDY23+HEWQms8AVZokPP3oZ
	QRLCArES3dPmMEIs62eS+LJ9P9gkToFgiX1/VoF1MwuoS0yat4gZwpaX2LzmLfMERoFZSJbM
	QlI2C0nZAkbmVYyiqQXJBcVJ6bmGesWJucWleel6yfm5mxjBCeOZ1A7GlQ0WhxgFOBiVeHgj
	6qNChVgTy4orcw8xSnAwK4nwinNHhwrxpiRWVqUW5ccXleakFh9iNAWGwURmKdHkfGAyyyuJ
	NzQ2MTOyNDI3tDAyNlcS5z2Z7xMqJJCeWJKanZpakFoE08fEwSnVwJidVX7ZRfrhBfuih5ef
	TtB8PMNzxgpT68q1isIXHJ7lhjanHT10eVnM4+LWMpU41z8Zp3ZV/339tojjwqu6xZuuR5fN
	kxJZ9/zOo+/rtuqsNnWcdsZx8Y7oPtfohKPpe+Ykyty/IrVsJ7vSwU2/N76077ZQ37ZHIn5J
	j2Z7m6altMTuGVzycVxKLMUZiYZazEXFiQC+keH9LgMAAA==
DLP-Filter: Pass
X-MTR: 20000000000000000@CPGS
X-CFilter-Loop: Reflected
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Krzysztof,

>>> +
>>> +       if (i == edev->max_supported)
>>> +               return -EINVAL;
>>>
>>>         if (index < 0 || (edev->max_supported && edev->max_supported <= index))
>>>                 return -EINVAL;
>>> @@ -605,7 +644,7 @@ static void dummy_sysfs_dev_release(struct device *dev)
>>>   *
>>>   * Return the pointer of extcon device if success or ERR_PTR(err) if fail
>>>   */
>>> -struct extcon_dev *extcon_dev_allocate(const char **supported_cable)
>>> +struct extcon_dev *extcon_dev_allocate(const enum extcon *supported_cable)
>>
>> I think you also have to update the documentation. At least for
>> {devm}_extcon_dev_allocate but maybe in other places too. Previously
>> the documentation states that supported_cable is an array of strings.
>> Additionally AFAIU now it must end with EXTCON_NONE. This
>> sentinel-like info must be clearly documented.

As you commented, extcon must need to document the update and usage method of extcon core.
The mainline kernel includes only the 'Documentation/extcon/porting-android-switch-class'.
Namely, the mainline kernel have not included the document showing the usage method of extcon core.

So, I'll make the proper document for extcon core as later job.

Thanks,
Chanwoo Choi