From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756114AbbESNog (ORCPT ); Tue, 19 May 2015 09:44:36 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:52881 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754103AbbESNoe (ORCPT ); Tue, 19 May 2015 09:44:34 -0400 X-Auth-Info: 31oyEJ0IvQfrkCk3HzZLs4d8h8/5K2DSa+fw8dT/Op4= Message-ID: <555B3E3A.8000605@denx.de> Date: Tue, 19 May 2015 15:44:26 +0200 From: Heiko Schocher Reply-To: hs@denx.de Organization: DENX Software Engineering User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Philipp Zabel CC: Shawn Guo , linux-kernel@vger.kernel.org, Shawn Guo , Sascha Hauer , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2] arm, imx6, dts: add DT for aristainetos2 board References: <1431334974-27531-1-git-send-email-hs@denx.de> <20150518113135.GD1071@dragon> <555AE192.8010700@denx.de> <1432025280.3182.6.camel@pengutronix.de> In-Reply-To: <1432025280.3182.6.camel@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Philipp, Am 19.05.2015 10:48, schrieb Philipp Zabel: > Hi Heiko, Shawn, > > Am Dienstag, den 19.05.2015, 09:09 +0200 schrieb Heiko Schocher: > [...] >>> What is this? I failed to find it in Documentation/devicetree/bindings/ >> >> Ah, this is not documentated, see commit: >> >> commit 628f435be4359e6ae8ecfdda9b492053be76a057 >> Author: Philipp Zabel >> Date: Tue Feb 25 11:55:04 2014 +0100 >> >> imx-drm: parallel-display: Add drm_panel support >> >> added Philipp to cc ... > > This was meant to be a temporary solution to connect a drm_panel to the > parallel-display when the of-graph bindings were not yet available. > I'd very much prefer to switch to the common of-graph bindings similarly > to the LDB driver instead. Could you check if this would work for you: Yes, your patch works for me (with appropriate changes in the dts file) You can add my Tested-by: Heiko Schocher for this patch, thanks! @Shawn: How do I proceed now with my patch for the aristainetos2 board support? Should I base my v3 of the aristainetos2 on this patch, or should I wait with this change, until the patch from Philipp is accepted and post a follow up? bye, Heiko > > -----8<----- > From: Philipp Zabel > Subject: [PATCH] drm/imx: parallel-display: fix drm_panel support > > The parallel-display driver used an undocumented, non-standard property > "fsl,panel" to optionally associate with a drm_panel device. This patch > fixes the driver to use the OF graph bindings, just as the LDB driver: > > parallel-display { > compatible = "fsl,imx-parallel-display"; > ... > > port@1 { > reg = <1>; > > parallel_out: endpoint { > remote_endpoint = <&panel_in>; > }; > }; > }; > > panel { > ... > > port { > panel_in: endpoint { > remote-endpoint = <¶llel_out>; > }; > }; > }; > > Signed-off-by: Philipp Zabel > --- > .../devicetree/bindings/drm/imx/fsl-imx-drm.txt | 26 ++++++++++++++++++++-- > drivers/gpu/drm/imx/parallel-display.c | 21 ++++++++++++----- > 2 files changed, 39 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/drm/imx/fsl-imx-drm.txt b/Documentation/devicetree/bindings/drm/imx/fsl-imx-drm.txt > index e75f0e5..971c3ee 100644 > --- a/Documentation/devicetree/bindings/drm/imx/fsl-imx-drm.txt > +++ b/Documentation/devicetree/bindings/drm/imx/fsl-imx-drm.txt > @@ -65,8 +65,10 @@ Optional properties: > - edid: verbatim EDID data block describing attached display. > - ddc: phandle describing the i2c bus handling the display data > channel > -- port: A port node with endpoint definitions as defined in > +- port@[0-1]: Port nodes with endpoint definitions as defined in > Documentation/devicetree/bindings/media/video-interfaces.txt. > + Port 0 is the input port connected to the IPU display interface, > + port 1 is the output port connected to a panel. > > example: > > @@ -75,9 +77,29 @@ display@di0 { > edid = [edid-data]; > interface-pix-fmt = "rgb24"; > > - port { > + port@0 { > + reg = <0>; > + > display_in: endpoint { > remote-endpoint = <&ipu_di0_disp0>; > }; > }; > + > + port@1 { > + reg = <1>; > + > + display_out: endpoint { > + remote-endpoint = <&panel_in>; > + }; > + }; > +}; > + > +panel { > + ... > + > + port { > + panel_in: endpoint { > + remote-endpoint = <&display_out>; > + }; > + }; > }; > diff --git a/drivers/gpu/drm/imx/parallel-display.c b/drivers/gpu/drm/imx/parallel-display.c > index 74a9ce4..b4deb9c 100644 > --- a/drivers/gpu/drm/imx/parallel-display.c > +++ b/drivers/gpu/drm/imx/parallel-display.c > @@ -21,6 +21,7 @@ > #include > #include > #include