From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Chanwoo Choi <cwchoi00@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"myungjoo.ham@samsung.com" <myungjoo.ham@samsung.com>,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
gg@slimlogic.co.uk, Kishon Vijay Abraham I <kishon@ti.com>,
jaewon02.kim@samsung.com, Roger Quadros <rogerq@ti.com>,
"Pallala, Ramakrishna" <ramakrishna.pallala@intel.com>,
george.cherian@ti.com, Felipe Balbi <balbi@ti.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>
Subject: Re: [PATCH 1/2] extcon: Use the unique id for external connector instead of string
Date: Wed, 20 May 2015 12:24:40 +0900 [thread overview]
Message-ID: <555BFE78.2000503@samsung.com> (raw)
In-Reply-To: <555B2C56.8080105@samsung.com>
On 19.05.2015 21:28, Chanwoo Choi wrote:
> Hi Krzysztof,
>
>>>> +
>>>> + if (i == edev->max_supported)
>>>> + return -EINVAL;
>>>>
>>>> if (index < 0 || (edev->max_supported && edev->max_supported <= index))
>>>> return -EINVAL;
>>>> @@ -605,7 +644,7 @@ static void dummy_sysfs_dev_release(struct device *dev)
>>>> *
>>>> * Return the pointer of extcon device if success or ERR_PTR(err) if fail
>>>> */
>>>> -struct extcon_dev *extcon_dev_allocate(const char **supported_cable)
>>>> +struct extcon_dev *extcon_dev_allocate(const enum extcon *supported_cable)
>>>
>>> I think you also have to update the documentation. At least for
>>> {devm}_extcon_dev_allocate but maybe in other places too. Previously
>>> the documentation states that supported_cable is an array of strings.
>>> Additionally AFAIU now it must end with EXTCON_NONE. This
>>> sentinel-like info must be clearly documented.
>
> As you commented, extcon must need to document the update and usage method of extcon core.
> The mainline kernel includes only the 'Documentation/extcon/porting-android-switch-class'.
> Namely, the mainline kernel have not included the document showing the usage method of extcon core.
I mean documentation for the function. The kerneldoc above functions says:
* @supported_cable: Array of supported cable names ending with NULL.
* If supported_cable is NULL, cable name related APIs
* are disabled.
AFAIU now the supported cable must end with EXTCON_NONE. Is it correct?
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-05-20 3:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 14:31 [PATCH 0/2] extcon: Use the unique id for each cable and update the extcon notifier Chanwoo Choi
2015-05-15 14:31 ` [PATCH 1/2] extcon: Use the unique id for external connector instead of string Chanwoo Choi
2015-05-15 14:49 ` Roger Quadros
2015-05-15 15:16 ` Charles Keepax
2015-05-15 15:57 ` Pallala, Ramakrishna
2015-05-17 7:10 ` Krzysztof Kozlowski
2015-05-17 7:53 ` Chanwoo Choi
2015-05-17 9:09 ` Krzysztof Kozlowski
2015-05-19 12:28 ` Chanwoo Choi
2015-05-20 3:24 ` Krzysztof Kozlowski [this message]
2015-05-20 3:48 ` Chanwoo Choi
2015-05-15 14:31 ` [PATCH 2/2] extcon: Update the prototype of extcon_register_notifier() with enum extcon Chanwoo Choi
2015-05-17 7:41 ` Krzysztof Kozlowski
2015-05-17 7:58 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555BFE78.2000503@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=aaro.koskinen@iki.fi \
--cc=balbi@ti.com \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=cw00.choi@samsung.com \
--cc=cwchoi00@gmail.com \
--cc=george.cherian@ti.com \
--cc=gg@slimlogic.co.uk \
--cc=jaewon02.kim@samsung.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=ramakrishna.pallala@intel.com \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).