From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753193AbbETKSG (ORCPT ); Wed, 20 May 2015 06:18:06 -0400 Received: from bhuna.collabora.co.uk ([93.93.135.160]:54070 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751423AbbETKSE (ORCPT ); Wed, 20 May 2015 06:18:04 -0400 Message-ID: <555C5F55.9010507@collabora.co.uk> Date: Wed, 20 May 2015 12:17:57 +0200 From: Javier Martinez Canillas User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.2.0 MIME-Version: 1.0 To: Krzysztof Kozlowski , Mark Brown CC: Kukjin Kim , Olof Johansson , Doug Anderson , David Hendricks , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Simon Glass Subject: Re: [RFC PATCH 2/4] ARM: dts: Add SPI flash node for Peach boards References: <1432042454-19234-1-git-send-email-javier.martinez@collabora.co.uk> <1432042454-19234-3-git-send-email-javier.martinez@collabora.co.uk> <555C0179.8040102@samsung.com> In-Reply-To: <555C0179.8040102@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof, On 05/20/2015 05:37 AM, Krzysztof Kozlowski wrote: > On 19.05.2015 22:34, Javier Martinez Canillas wrote: >> From: Simon Glass >> >> Peach Pit and Pi machines have a SPI flash memory that is used to >> store firmware and different system parameters and data. >> >> Add information about the SPI flash chip so that user-space tools >> can access it. >> >> Signed-off-by: Simon Glass >> Reviewed-by: Doug Anderson >> Signed-off-by: Javier Martinez Canillas > > Acked-by: Krzysztof Kozlowski > > I assume this can go through samsung-soc tree (after documenting new > compatible)? > Yes, I mentioned in the cover letter that patch #1 should go through the spi tree and #2-4 through the linux-samsung tree. I can split in two series once I post as proper patches to make it more clear. > The exynos5800-peach-pi.dts and exynos5420-peach-pit.dts have a lot of > common nodes. I wonder if there is a common part which could have its > own dtsi? Like exynos4412-odroid-common.dtsi? > We discussed in the past about having a common .dtsi [0]. I'm not a huge fan of a common .dtsi and I prefer to instead split common dts fragments in a .dtsi that can be included in different dts. That also better reflects what happens at the hw level IMHO since a board may reuse a IP block. Doug Anderson seems to agree with me [1]. > Best regards, > Krzysztof > Best regards, Javier [0]: https://lkml.org/lkml/2014/6/26/271 [1]: https://lkml.org/lkml/2014/6/26/555