From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756390AbbEUUgr (ORCPT ); Thu, 21 May 2015 16:36:47 -0400 Received: from mail-by2on0104.outbound.protection.outlook.com ([207.46.100.104]:20814 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755772AbbEUUgp (ORCPT ); Thu, 21 May 2015 16:36:45 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; arm.com; dkim=none (message not signed) header.d=none; X-WSS-ID: 0NOPVX5-07-NYC-02 X-M-MSG: Message-ID: <555E41D8.2000504@amd.com> Date: Thu, 21 May 2015 15:36:40 -0500 From: Suravee Suthikulpanit User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: , , , , , CC: , , , , , , , , , , , , , Subject: Re: [PATCH v2 0/7] Watchdog: introduce ARM SBSA watchdog driver References: <=fu.wei@linaro.org> <1432197156-16947-1-git-send-email-fu.wei@linaro.org> In-Reply-To: <1432197156-16947-1-git-send-email-fu.wei@linaro.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD046;1:Z08GJhOvvV7Vf/PLrMR4NBaw1nAoJba/1mSwhkUP9N4/YTF7zV96tG2eL/Q9l2V0dwHpd6iYL7DceKdUbexWnvKanm5RLvjXcWyek7DZDLyW39zZvjV9MEbCZ3k2+HogQHnl8TMXh5Bqw+yu9RwzuhD++9xtvgQkRyjEtzn822m55pOQQokxxnYXmy6cWL6Rq2jGwcIpnpEg7xzbNpWMhiie6lRlQnEYHpk1uOabD5QB+CeZpcvhyBo/Nm8wwCdDm02I7T79epER1wa/Tdb+YelpVkRoUWuVYULmFJqL2XvNSmnDOgtCDBMn3IjJJR/1 X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(428002)(51704005)(164054003)(54534003)(479174004)(24454002)(189002)(199003)(59896002)(23746002)(50986999)(83506001)(5001770100001)(5001860100001)(46102003)(5001830100001)(64126003)(80316001)(4001540100001)(4001350100001)(97736004)(19580405001)(19580395003)(2950100001)(68736005)(62966003)(77156002)(65806001)(77096005)(64706001)(86362001)(92566002)(87936001)(101416001)(36756003)(33656002)(47776003)(50466002)(106466001)(65956001)(54356999)(65816999)(87266999)(53416004)(2201001)(76176999)(189998001)(105586002)(2101003)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:CO1PR02MB079;H:atltwp01.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CO1PR02MB079; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:CO1PR02MB079;BCL:0;PCL:0;RULEID:;SRVR:CO1PR02MB079; X-Forefront-PRVS: 0583A86C08 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2015 20:36:41.8657 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR02MB079 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For patch 1,4,5,6,and 7, I have tested this on AMD Seattle platform. Tested-by: Suravee Suthikulpanit Thanks, Suravee On 5/21/15 03:32, fu.wei@linaro.org wrote: > From: Fu Wei > > This patchset: > > (1)Export "arch_timer_get_rate" in arm_arch_timer.c for the > other drivers, like SBSA watchdog driver > > (2)Introduce Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt > for FDT info of SBSA Generic Watchdog, and give two examples of > adding SBSA Generic Watchdog device node into the dts files: > foundation-v8.dts and amd-seattle-soc.dtsi. > > (3)Introduce "pretimeout" into the watchdog framework, and update > Documentation/watchdog/watchdog-kernel-api.txt to introduce: > (1)the new elements in the watchdog_device and watchdog_ops struct; > (2)the new API "watchdog_init_timeouts". > > (4)Introduce ARM SBSA watchdog driver: > a.Use linux kernel watchdog framework; > b.Work with FDT on ARM64; > c.Use "pretimeout" in watchdog framework; > d.In first timeout(WS0), do panic to save system context; > e.Support geting timeout and pretimeout from parameter and FDT > at the driver init stage. > > (5)Parse SBSA Generic Watchdog Structure in GTDT table of ACPI, > and create a platform device with that information. > This platform device can be used by This Watchdog driver. > > This patchset has been tested with watchdog daemon > (ACPI/FDT, module/build-in) on the following platforms: > (1)ARM Foundation v8 model > (2)AMD Seattle B0 > > Changelog: > v2: Improve watchdog-kernel-api.txt documentation for pretimeout support. > Export "arch_timer_get_rate" in arm_arch_timer.c. > Add watchdog_init_timeouts API for pretimeout support in framework. > Improve suspend and resume foundation in driver > Improve timeout/pretimeout values init code in driver. > Delete unnecessary items of the sbsa_gwdt struct and #define. > Delete all unnecessary debug info in driver. > Fix 64bit division bug. > Use the arch_timer interface to get watchdog clock rate. > Add MODULE_DEVICE_TABLE for platform device id. > Fix typoes. > > v1: The first version upstream patchset to linux mailing list > > Fu Wei (7): > clocksource: export "arch_timer_get_rate" for the other drivers > Documentation: add sbsa-gwdt.txt documentation > ARM64: add SBSA Generic Watchdog device node in foundation-v8.dts > ARM64: add SBSA Generic Watchdog device node in amd-seattle-soc.dtsi > Watchdog: introduce "pretimeout" into framework > Watchdog: introduce ARM SBSA watchdog driver > ACPI: import watchdog info of GTDT into platform device > > .../devicetree/bindings/watchdog/sbsa-gwdt.txt | 36 ++ > Documentation/watchdog/watchdog-kernel-api.txt | 62 ++- > arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi | 11 + > arch/arm64/boot/dts/arm/foundation-v8.dts | 10 + > arch/arm64/kernel/acpi.c | 136 ++++++ > drivers/clocksource/arm_arch_timer.c | 1 + > drivers/watchdog/Kconfig | 12 + > drivers/watchdog/Makefile | 1 + > drivers/watchdog/sbsa_gwdt.c | 476 +++++++++++++++++++++ > drivers/watchdog/watchdog_core.c | 103 +++-- > drivers/watchdog/watchdog_dev.c | 48 +++ > include/linux/watchdog.h | 30 +- > 12 files changed, 891 insertions(+), 35 deletions(-) > create mode 100644 Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt > create mode 100644 drivers/watchdog/sbsa_gwdt.c >