From: Daniel Thompson <daniel.thompson@linaro.org>
To: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: "Maxime Ripard" <maxime.ripard@free-electrons.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Andreas Färber" <afaerber@suse.de>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Stefan Agner" <stefan@agner.ch>,
"Peter Meerwald" <pmeerw@pmeerw.net>,
"Paul Bolle" <pebolle@tiscali.nl>,
"Peter Hurley" <peter@hurleysoftware.com>,
"Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Russell King" <linux@arm.linux.org.uk>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Joe Perches" <joe@perches.com>,
"Vladimir Zapolskiy" <vladimir_zapolskiy@mentor.com>,
"Lee Jones" <lee.jones@linaro.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jslaby@suse.cz>,
"Andrew Morton" <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
"Mauro Carvalho Chehab" <mchehab@osg.samsung.com>,
"Antti Palosaari" <crope@iki.fi>, "Tejun Heo" <tj@kernel.org>,
"Will Deacon" <will.deacon@arm.com>,
"Nikolay Borisov" <Nikolay.Borisov@arm.com>,
"Rusty Russell" <rusty@rustcorp.com.au>,
"Kees Cook" <keescook@chromium.org>,
"Michal Marek" <mmarek@suse.cz>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>,
"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>,
"Nicolae Rosia" <nicolae.rosia@gmail.com>,
"Kamil Lulko" <rev13@wp.pl>
Subject: Re: [PATCH v8 14/16] ARM: dts: Introduce STM32F429 MCU
Date: Fri, 22 May 2015 13:43:43 +0100 [thread overview]
Message-ID: <555F247F.9060100@linaro.org> (raw)
In-Reply-To: <CALszF6CQ1_HQXJ8=vgytvVo2t4_ue5_nsE06HPyHMzSLrntqKg@mail.gmail.com>
On 22/05/15 13:32, Maxime Coquelin wrote:
> 2015-05-22 12:07 GMT+02:00 Philipp Zabel <p.zabel@pengutronix.de>:
>> And that's how I'd expect it to be described by the device tree:
>>
>> rcc: rcc@40023800 {
>> compatible = "st,stm32-rcc";
>> reg = <0x40023800 0xc0>;
>> };
>>
>
> Doing that, since this register bank contains both reset and clock
> registers, the reset device cannot get the IO resource at probe time
> because the clock driver has already reserved it.
> Daniel, who has started to work on the clock driver is facing this issue.
> This is why I proposed this binding for "reg" property.
Temporarily I've kept things working for me by avoiding
of_io_request_and_map() in the clock driver (I am using raw of_iomap()
instead).
I view this as a hack rather than a solution!
Note that, with or without the hack, I do hope to be able to post the
clock driver this weekend. I am acutely aware that at the moment we are
discussing code I haven't posted yet.
> We could think of creating a MFD driver, but the problem is that clock
> need to be intialized before a MFD device can be probed.
>
> Maybe there is a way to have you binding working properly, but I
> haven't found one for now.
I guess a driver doesn't *have* to reserve all the register space
described in DT. The driver could replace of_io_request_and_map() with
lower level calls.
Thus if we wanted to keep this detail out of DT then I guess the two
drivers could simply make an agreement not to request registers they do
not use.
next prev parent reply other threads:[~2015-05-22 12:43 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-09 7:53 [PATCH v8 00/16] Add support to STMicroelectronics STM32 family Maxime Coquelin
2015-05-09 7:53 ` [PATCH v8 01/16] scripts: link-vmlinux: Don't pass page offset to kallsyms if XIP Kernel Maxime Coquelin
2015-05-18 11:47 ` Maxime Coquelin
2015-05-20 23:04 ` Andreas Färber
2015-05-21 5:40 ` Michal Marek
2015-05-21 7:42 ` Maxime Coquelin
2015-05-22 20:20 ` Andreas Färber
2015-05-09 7:53 ` [PATCH v8 02/16] ARM: ARMv7-M: Enlarge vector table up to 256 entries Maxime Coquelin
2015-05-09 7:53 ` [PATCH v8 03/16] dt-bindings: Document the ARM System timer bindings Maxime Coquelin
2015-05-09 7:53 ` [PATCH v8 04/16] clocksource/drivers: Add ARM System timer driver Maxime Coquelin
2015-05-18 11:55 ` Maxime Coquelin
2015-05-18 12:49 ` Daniel Lezcano
2015-05-18 12:57 ` Maxime Coquelin
2015-05-09 7:53 ` [PATCH v8 05/16] dt-bindings: mfd: Add STM32F4 RCC numeric constants into DT include file Maxime Coquelin
2015-05-09 7:53 ` [PATCH v8 06/16] dt-bindings: Document the STM32 reset bindings Maxime Coquelin
2015-05-09 7:53 ` [PATCH v8 07/16] drivers: reset: Add STM32 reset driver Maxime Coquelin
2015-05-20 23:45 ` Andreas Färber
2015-05-21 7:46 ` Maxime Coquelin
2015-05-21 17:58 ` Andreas Färber
2015-05-21 19:57 ` Maxime Coquelin
2015-05-21 22:01 ` Andreas Färber
2015-05-22 14:04 ` Maxime Coquelin
2015-05-09 7:53 ` [PATCH v8 08/16] dt-bindings: Document the STM32 timer bindings Maxime Coquelin
2015-05-09 7:53 ` [PATCH v8 09/16] clockevents/drivers: Add STM32 Timer driver Maxime Coquelin
2015-05-18 13:10 ` Daniel Lezcano
2015-05-18 14:03 ` Maxime Coquelin
2015-05-19 8:16 ` Daniel Lezcano
2015-05-19 8:55 ` Maxime Coquelin
2015-05-19 9:06 ` Daniel Lezcano
2015-05-19 9:44 ` Maxime Coquelin
2015-05-19 9:59 ` Daniel Lezcano
2015-05-19 10:02 ` Maxime Coquelin
2015-05-19 10:55 ` Arnd Bergmann
2015-05-19 13:42 ` Maxime Coquelin
2015-05-19 13:49 ` Daniel Lezcano
2015-05-19 14:05 ` Arnd Bergmann
2015-05-19 14:41 ` Maxime Coquelin
2015-05-19 14:50 ` Russell King - ARM Linux
2015-05-19 15:34 ` Maxime Coquelin
2015-05-19 15:03 ` Daniel Lezcano
2015-05-19 12:56 ` Thomas Gleixner
2015-05-19 13:00 ` Russell King - ARM Linux
2015-05-19 13:17 ` Maxime Coquelin
2015-05-09 7:53 ` [PATCH v8 10/16] dt-bindings: Document the STM32 USART bindings Maxime Coquelin
2015-05-09 7:53 ` [PATCH v8 11/16] serial: stm32-usart: Add STM32 USART Driver Maxime Coquelin
2015-05-09 10:07 ` Andy Shevchenko
2015-05-09 7:53 ` [PATCH v8 12/16] ARM: Add STM32 family machine Maxime Coquelin
2015-05-15 19:57 ` Arnd Bergmann
2015-05-09 7:53 ` [PATCH v8 13/16] ARM: dts: Add ARM System timer as clocksource in armv7m Maxime Coquelin
2015-05-15 19:59 ` Arnd Bergmann
2015-05-09 7:53 ` [PATCH v8 14/16] ARM: dts: Introduce STM32F429 MCU Maxime Coquelin
2015-05-12 21:21 ` Arnd Bergmann
2015-05-13 11:45 ` Maxime Coquelin
2015-05-13 12:58 ` Daniel Thompson
2015-05-13 13:27 ` Arnd Bergmann
[not found] ` <55536BC2.30603@linaro.org>
2015-05-13 15:28 ` Arnd Bergmann
2015-05-13 16:29 ` Maxime Coquelin
2015-05-13 16:37 ` Arnd Bergmann
2015-05-13 16:54 ` Maxime Coquelin
2015-05-13 19:11 ` Arnd Bergmann
2015-05-20 16:17 ` Maxime Coquelin
[not found] ` <20150521185122.GD8557@lukather>
2015-05-21 20:10 ` Maxime Coquelin
2015-05-23 8:28 ` Maxime Ripard
2015-05-26 9:25 ` Maxime Coquelin
[not found] ` <1432285588.3929.28.camel@pengutronix.de>
[not found] ` <20150522091822.GF8557@lukather>
[not found] ` <1432289231.3929.60.camel@pengutronix.de>
[not found] ` <CALszF6CQ1_HQXJ8=vgytvVo2t4_ue5_nsE06HPyHMzSLrntqKg@mail.gmail.com>
2015-05-22 12:43 ` Daniel Thompson [this message]
[not found] ` <555F2A8A.5020205@suse.de>
2015-05-22 13:57 ` Maxime Coquelin
2015-05-22 14:06 ` Andreas Färber
2015-05-22 14:14 ` Daniel Thompson
2015-05-13 19:29 ` Daniel Thompson
2015-05-13 19:37 ` Arnd Bergmann
2015-05-14 16:34 ` Maxime Coquelin
2015-05-14 19:38 ` Daniel Thompson
2015-05-18 12:21 ` Maxime Coquelin
2015-05-09 7:53 ` [PATCH v8 15/16] ARM: configs: Add STM32 defconfig Maxime Coquelin
2015-05-15 20:03 ` Arnd Bergmann
2015-05-09 7:53 ` [PATCH v8 16/16] MAINTAINERS: Add entry for STM32 MCUs Maxime Coquelin
2015-05-15 19:58 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555F247F.9060100@linaro.org \
--to=daniel.thompson@linaro.org \
--cc=Nikolay.Borisov@arm.com \
--cc=afaerber@suse.de \
--cc=akpm@linux-foundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=crope@iki.fi \
--cc=cw00.choi@samsung.com \
--cc=daniel.lezcano@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=joe@perches.com \
--cc=jslaby@suse.cz \
--cc=keescook@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=mchehab@osg.samsung.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mmarek@suse.cz \
--cc=nicolae.rosia@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=pawel.moll@arm.com \
--cc=pebolle@tiscali.nl \
--cc=peter@hurleysoftware.com \
--cc=pmeerw@pmeerw.net \
--cc=rev13@wp.pl \
--cc=robh+dt@kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=stefan@agner.ch \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vladimir_zapolskiy@mentor.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).