From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: "Thomas Niederprüm" <niederp@physik.uni-kl.de>,
plagnioj@jcrosoft.com, maxime.ripard@free-electrons.com,
kernel@pengutronix.de, shawn.guo@linaro.org, robh+dt@kernel.org
Cc: <linux-fbdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv6 00/10] Cleanup and add support for SSD1305
Date: Wed, 27 May 2015 13:15:30 +0300 [thread overview]
Message-ID: <55659942.9060400@ti.com> (raw)
In-Reply-To: <1427826436-21783-1-git-send-email-niederp@physik.uni-kl.de>
[-- Attachment #1: Type: text/plain, Size: 3681 bytes --]
On 31/03/15 21:27, Thomas Niederprüm wrote:
> Hi,
>
> this patch series is the result of making the ssd1307fb driver work with
> a Newhaven OLED display using the Solomon SSD1305 controller. To achieve
> this the intialization code for the SSD1306 and the SSD1307 is merged
> and based on DT configuration to reflect the various possible wirings
> of the SSD130X controller (04/10). Based on these changes it is straight
> forward to add support for the SSD1305 controller (06/10).
>
> While working on the driver I realized that it was not possible to
> correctly mmap the video memory from userspace since the address handed
> to the userspace app is a logical one where it should be a physical one.
> Patch 01/10 fixes this. Furthermore the memory reserved by kzalloc is
> not page aligned while the address handed to userspace is aligned to the
> next page frame. This problem is fixed by using __get_free_pages() in 02/10.
>
> Furthermore a module parameter is added to set the delay for the
> deferred io update (07/10). Also the backlight class is implemented to make
> the contrast setting available in userspace (09/10).
>
> changes since v1 (thanks to Maxime for the feedback):
> - dedicated patch for fixing smem_start address
> - remove page reserve upon vmalloc
> - remove return value check upon display turn-off at module unload
> - use a module parameter refreshrate rather than delaydivider
> - allocate fbdefio dynamically
> - use sysfs_create_groups to create sysfs entries
> - remove contrast, vhcom and dclk properties from DT since they are
> not part of hw description. The contrast module parameter was added
> to set contrast at load time. vhcom and dclk stays at it's default
> values for now.
> - add new DT properties to in tree users of ssd130X
> - rebased to apply on top of linux-next
>
> changes since v2 (thanks to Maxime again):
> - free memory allocated by vmalloc on driver unload
> - set default values in the init code to the ones of the existing ssd1307
> init code
> - added two ACKs (Maxime Ripard)
>
> changes since v3:
> - use backlight class rather than dedicated sysfs files to set the
> contrast (Thanks to Tomi Valkeinen)
> - remove [PATCHv3 08/10] fbdev: ssd1307fb: Add module parameter bitsperpixel
> - add new patch to blank the display (unreviewed)
> - allocate video memory through __get_free_pages() rather than vmalloc
> (Thanks to Geert Uytterhoeven)
> - minor rewordings of the commit messages
>
> changes since v4 (thanks to Maxime):
> - added two ACKs (Maxime Ripard)
> - fixed typo: s/REFRASHRATE/REFRESHRATE
> - updated the documentation to make clear the unit of com-offset
> - move addition of the module parameter contrast to a separate patch (09/11)
> - fix indentation errors
> - get rid of device_id in the device_info struct
>
> changes since v5:
> - remove [PATCHv5 09/11] fbdev: ssd1307fb: Add module parameter to set
> the initial contrast
> - remove unnecessary variable initialization in the deviceinfo struct as
> pointed out by Maxime
> - make the variable dclk_div hold the actual divider rather than the
> corresponding bit value
> - remove ret variable in ssd1307fb_blank() (thanks to Olliver Schinagl)
> - fixed bit mask for com_invdir as indicated by Olliver
> - change initialization of the charge pump as suggested by Olliver
> - change the default value for prechargep2 to 0x2 (thanks to Olliver)
> - change DT property name "com-sequential" to "com-seq"
> - added one ACK (Maxime Ripard)
> - added Tested-by Olliver Schinagl
I have queued this version for 4.2, with all the acks.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-05-27 10:16 UTC|newest]
Thread overview: 138+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 22:28 [PATCH 0/8] Cleanup and add support for SSD1305 niederp
2015-02-06 22:28 ` [PATCH 1/8] Documentation: dts: add missing Solomon Systech vendor prefix niederp
2015-02-06 22:28 ` [PATCH 2/8] fbdev: ssd1307fb: Unify init code and make controller configurable from device tree niederp
2015-02-07 10:42 ` Maxime Ripard
2015-02-07 14:59 ` Thomas Niederprüm
2015-02-07 15:19 ` Noralf Trønnes
2015-02-09 10:37 ` Thomas Niederprüm
2015-02-12 16:58 ` Maxime Ripard
2015-02-12 16:41 ` Maxime Ripard
2015-02-14 16:12 ` Thomas Niederprüm
2015-02-23 9:43 ` Maxime Ripard
2015-02-06 22:28 ` [PATCH 3/8] fbdev: ssd1307fb: Add support for SSD1305 niederp
2015-02-06 22:28 ` [PATCH 4/8] fbdev: ssd1307fb: Use vmalloc to allocate video memory niederp
2015-02-07 11:18 ` Maxime Ripard
2015-02-07 15:35 ` Thomas Niederprüm
2015-02-12 15:11 ` Maxime Ripard
2015-02-14 14:22 ` Thomas Niederprüm
2015-02-14 15:36 ` Maxime Ripard
2015-03-10 11:28 ` Tomi Valkeinen
2015-03-13 21:31 ` Thomas Niederprüm
2015-03-14 22:02 ` Geert Uytterhoeven
2015-03-20 11:37 ` Tomi Valkeinen
2015-03-20 12:12 ` Geert Uytterhoeven
2015-03-20 14:47 ` Maxime Ripard
2015-03-20 15:24 ` Geert Uytterhoeven
2015-03-20 20:27 ` Thomas Niederprüm
2015-03-20 15:25 ` Tomi Valkeinen
2015-03-20 20:36 ` Thomas Niederprüm
2015-02-06 22:28 ` [PATCH 5/8] fbdev: ssd1307fb: Add module parameter bitsperpixel niederp
2015-02-07 11:20 ` Maxime Ripard
2015-02-07 16:05 ` Thomas Niederprüm
2015-02-14 15:54 ` Maxime Ripard
2015-03-10 10:45 ` Tomi Valkeinen
2015-03-13 19:25 ` Thomas Niederprüm
2015-03-25 10:56 ` Olliver Schinagl
2015-03-25 16:02 ` Maxime Ripard
2015-02-06 22:28 ` [PATCH 6/8] fbdev: ssd1307fb: Add module parameter to set update delay of the deffered io niederp
2015-02-07 11:26 ` Maxime Ripard
2015-02-07 16:12 ` Thomas Niederprüm
2015-02-09 9:03 ` Maxime Ripard
2015-02-06 22:28 ` [PATCH 7/8] fbdev: ssd1307fb: Add sysfs handles to expose contrast and dim setting to userspace niederp
2015-02-07 11:43 ` Maxime Ripard
2015-02-07 16:42 ` Thomas Niederprüm
2015-02-09 8:52 ` Maxime Ripard
2015-03-10 10:49 ` Tomi Valkeinen
2015-03-13 19:21 ` Thomas Niederprüm
2015-02-06 22:28 ` [PATCH 8/8] fbdev: ssd1307fb: Turn off display on driver unload niederp
2015-02-07 11:45 ` Maxime Ripard
2015-02-07 16:49 ` Thomas Niederprüm
2015-03-01 22:27 ` [PATCHv2 00/10] fbdev: ssd1307fb: Cleanup and add support for SSD1305 Thomas Niederprüm
2015-03-01 22:27 ` [PATCHv2 01/10] fbdev: ssd1307fb: fix memory address smem_start Thomas Niederprüm
2015-03-03 7:17 ` Maxime Ripard
2015-03-01 22:27 ` [PATCHv2 02/10] fbdev: ssd1307fb: Use vmalloc to allocate video memory Thomas Niederprüm
2015-03-03 8:52 ` Maxime Ripard
2015-03-03 19:04 ` Thomas Niederprüm
2015-03-01 22:27 ` [PATCHv2 03/10] Documentation: dts: add missing Solomon Systech vendor prefix Thomas Niederprüm
2015-03-01 22:27 ` [PATCHv2 04/10] fbdev: ssd1307fb: Unify init code and obtain hw specific bits from DT Thomas Niederprüm
2015-03-05 21:49 ` Maxime Ripard
2015-03-01 22:27 ` [PATCHv2 05/10] fbdev: ssd1307fb: fix in tree users of ssd1306 Thomas Niederprüm
2015-03-03 9:31 ` Maxime Ripard
2015-03-01 22:27 ` [PATCHv2 06/10] fbdev: ssd1307fb: Add support for SSD1305 Thomas Niederprüm
2015-03-01 22:28 ` [PATCHv2 07/10] fbdev: ssd1307fb: Add module parameter to set refresh rate of the display Thomas Niederprüm
2015-03-05 22:12 ` Maxime Ripard
2015-03-01 22:28 ` [PATCHv2 08/10] fbdev: ssd1307fb: Add module parameter bitsperpixel Thomas Niederprüm
2015-03-01 22:28 ` [PATCHv2 09/10] fbdev: ssd1307fb: Add sysfs handles to expose contrast and dim setting to userspace Thomas Niederprüm
2015-03-01 22:28 ` [PATCHv2 10/10] fbdev: ssd1307fb: Turn off display on driver unload Thomas Niederprüm
2015-03-03 9:40 ` Maxime Ripard
2015-03-09 22:22 ` [PATCHv3 00/10] fbdev: ssd1307fb: Cleanup and add support for SSD1305 Thomas Niederprüm
2015-03-09 22:22 ` [PATCHv3 01/10] fbdev: ssd1307fb: fix memory address smem_start Thomas Niederprüm
2015-03-09 22:22 ` [PATCHv3 02/10] fbdev: ssd1307fb: Use vmalloc to allocate video memory Thomas Niederprüm
2015-03-09 22:22 ` [PATCHv3 03/10] of: Add Solomon Systech vendor prefix Thomas Niederprüm
2015-03-09 22:22 ` [PATCHv3 04/10] fbdev: ssd1307fb: Unify init code and obtain hw specific bits from DT Thomas Niederprüm
2015-03-09 22:22 ` [PATCHv3 05/10] ARM: mxs: fix in tree users of ssd1306 Thomas Niederprüm
2015-03-09 22:22 ` [PATCHv3 06/10] fbdev: ssd1307fb: Add support for SSD1305 Thomas Niederprüm
2015-03-09 22:22 ` [PATCHv3 07/10] fbdev: ssd1307fb: Add module parameter to set refresh rate of the display Thomas Niederprüm
2015-03-09 22:22 ` [PATCHv3 08/10] fbdev: ssd1307fb: Add module parameter bitsperpixel Thomas Niederprüm
2015-03-09 22:22 ` [PATCHv3 09/10] fbdev: ssd1307fb: Add sysfs handles to expose contrast and dim setting to userspace Thomas Niederprüm
2015-03-09 22:22 ` [PATCHv3 10/10] fbdev: ssd1307fb: Turn off display on driver unload Thomas Niederprüm
2015-03-16 17:11 ` [PATCHv4 00/10] Cleanup and add support for SSD1305 Thomas Niederprüm
2015-03-16 17:11 ` [PATCHv4 01/10] fbdev: ssd1307fb: fix memory address smem_start Thomas Niederprüm
2015-03-16 17:11 ` [PATCHv4 02/10] fbdev: ssd1307fb: Allocate page aligned video memory Thomas Niederprüm
2015-03-18 17:38 ` Maxime Ripard
2015-03-16 17:11 ` [PATCHv4 03/10] of: Add Solomon Systech vendor prefix Thomas Niederprüm
2015-03-16 17:11 ` [PATCHv4 04/10] fbdev: ssd1307fb: Unify init code and obtain hw specific bits from DT Thomas Niederprüm
2015-03-18 19:27 ` Maxime Ripard
2015-03-20 21:12 ` Thomas Niederprüm
2015-03-24 15:24 ` Maxime Ripard
2015-03-16 17:11 ` [PATCHv4 05/10] ARM: mxs: fix in tree users of ssd1306 Thomas Niederprüm
2015-03-16 17:11 ` [PATCHv4 06/10] fbdev: ssd1307fb: Add support for SSD1305 Thomas Niederprüm
2015-03-16 17:11 ` [PATCHv4 07/10] fbdev: ssd1307fb: Add a module parameter to set the refresh rate Thomas Niederprüm
2015-03-19 13:18 ` Maxime Ripard
2015-03-20 21:16 ` Thomas Niederprüm
2015-03-16 17:11 ` [PATCHv4 08/10] fbdev: ssd1307fb: Turn off display on driver unload Thomas Niederprüm
2015-03-16 17:11 ` [PATCHv4 09/10] fbdev: ssd1307fb: add backlight controls for setting the contrast Thomas Niederprüm
2015-03-19 13:22 ` Maxime Ripard
2015-03-16 17:11 ` [PATCHv4 10/10] fbdev: ssd1307fb: Add blank mode Thomas Niederprüm
2015-03-24 21:23 ` [PATCHv5 00/11] Cleanup and add support for SSD1305 Thomas Niederprüm
2015-03-24 21:23 ` [PATCHv5 01/11] fbdev: ssd1307fb: fix memory address smem_start Thomas Niederprüm
2015-03-24 21:23 ` [PATCHv5 02/11] fbdev: ssd1307fb: Allocate page aligned video memory Thomas Niederprüm
2015-03-24 21:23 ` [PATCHv5 03/11] of: Add Solomon Systech vendor prefix Thomas Niederprüm
2015-03-24 21:23 ` [PATCHv5 04/11] fbdev: ssd1307fb: Unify init code and obtain hw specific bits from DT Thomas Niederprüm
2015-03-24 22:14 ` Maxime Ripard
2015-03-25 20:03 ` Thomas Niederprüm
2015-03-25 15:49 ` Olliver Schinagl
2015-03-25 22:14 ` Thomas Niederprüm
2015-03-24 21:23 ` [PATCHv5 05/11] ARM: mxs: fix in tree users of ssd1306 Thomas Niederprüm
2015-03-24 21:23 ` [PATCHv5 06/11] fbdev: ssd1307fb: Add support for SSD1305 Thomas Niederprüm
2015-03-24 21:23 ` [PATCHv5 07/11] fbdev: ssd1307fb: Add a module parameter to set the refresh rate Thomas Niederprüm
2015-03-24 21:54 ` Maxime Ripard
2015-03-24 21:23 ` [PATCHv5 08/11] fbdev: ssd1307fb: Turn off display on driver unload Thomas Niederprüm
2015-03-24 21:23 ` [PATCHv5 09/11] fbdev: ssd1307fb: Add module parameter to set the initial contrast Thomas Niederprüm
2015-03-24 22:16 ` Maxime Ripard
2015-03-25 20:10 ` Thomas Niederprüm
2015-03-24 21:23 ` [PATCHv5 10/11] fbdev: ssd1307fb: add backlight controls for setting the contrast Thomas Niederprüm
2015-03-24 21:23 ` [PATCHv5 11/11] fbdev: ssd1307fb: Add blank mode Thomas Niederprüm
2015-03-25 15:50 ` Olliver Schinagl
2015-03-25 20:33 ` Thomas Niederprüm
2015-03-25 22:00 ` Maxime Ripard
2015-03-31 18:27 ` [PATCHv6 00/10] Cleanup and add support for SSD1305 Thomas Niederprüm
2015-03-31 18:27 ` [PATCHv6 01/10] fbdev: ssd1307fb: fix memory address smem_start Thomas Niederprüm
2015-03-31 18:27 ` [PATCHv6 02/10] fbdev: ssd1307fb: Allocate page aligned video memory Thomas Niederprüm
2015-03-31 18:27 ` [PATCHv6 03/10] of: Add Solomon Systech vendor prefix Thomas Niederprüm
2015-04-01 20:33 ` Rob Herring
2015-03-31 18:27 ` [PATCHv6 04/10] fbdev: ssd1307fb: Unify init code and obtain hw specific bits from DT Thomas Niederprüm
2015-04-01 16:00 ` Maxime Ripard
2015-03-31 18:27 ` [PATCHv6 05/10] ARM: mxs: fix in tree users of ssd1306 Thomas Niederprüm
2015-05-07 10:55 ` Tomi Valkeinen
2015-05-07 11:28 ` Shawn Guo
2015-05-08 13:31 ` Maxime Ripard
2015-05-26 7:08 ` Tomi Valkeinen
2015-05-27 3:03 ` Shawn Guo
2015-03-31 18:27 ` [PATCHv6 06/10] fbdev: ssd1307fb: Add support for SSD1305 Thomas Niederprüm
2015-04-01 16:01 ` Maxime Ripard
2015-03-31 18:27 ` [PATCHv6 07/10] fbdev: ssd1307fb: Add a module parameter to set the refresh rate Thomas Niederprüm
2015-03-31 18:27 ` [PATCHv6 08/10] fbdev: ssd1307fb: Turn off display on driver unload Thomas Niederprüm
2015-03-31 18:27 ` [PATCHv6 09/10] fbdev: ssd1307fb: add backlight controls for setting the contrast Thomas Niederprüm
2015-03-31 18:27 ` [PATCHv6 10/10] fbdev: ssd1307fb: Add blank mode Thomas Niederprüm
2015-05-27 10:15 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55659942.9060400@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=kernel@pengutronix.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=niederp@physik.uni-kl.de \
--cc=plagnioj@jcrosoft.com \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).