From: Byungchul Park <byungchul.park@lge.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: peterz@infradead.org, mingo@kernel.org,
akpm@linux-foundation.org, tglx@linutronix.de,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-block@vger.kernel.org, kernel-team@lge.com, jack@suse.cz,
jlayton@redhat.com, viro@zeniv.linux.org.uk, hannes@cmpxchg.org,
npiggin@gmail.com, rgoldwyn@suse.com, vbabka@suse.cz,
mhocko@suse.com, pombredanne@nexb.com, vinmenon@codeaurora.org,
gregkh@linuxfoundation.org
Subject: Re: [PATCH v2 0/4] lockdep/crossrelease: Apply crossrelease to page locks
Date: Tue, 5 Dec 2017 15:19:46 +0900 [thread overview]
Message-ID: <55674f0a-7886-f1d2-d7f1-6bf42c1e89e3@lge.com> (raw)
In-Reply-To: <0aad02e4-f477-1ee3-471a-3e1371ebba1e@lge.com>
On 12/5/2017 2:46 PM, Byungchul Park wrote:
> On 12/5/2017 2:30 PM, Matthew Wilcox wrote:
>> On Mon, Dec 04, 2017 at 02:16:19PM +0900, Byungchul Park wrote:
>>> For now, wait_for_completion() / complete() works with lockdep, add
>>> lock_page() / unlock_page() and its family to lockdep support.
>>>
>>> Changes from v1
>>> - Move lockdep_map_cross outside of page_ext to make it flexible
>>> - Prevent allocating lockdep_map per page by default
>>> - Add a boot parameter allowing the allocation for debugging
>>>
>>> Byungchul Park (4):
>>> lockdep: Apply crossrelease to PG_locked locks
>>> lockdep: Apply lock_acquire(release) on __Set(__Clear)PageLocked
>>> lockdep: Move data of CONFIG_LOCKDEP_PAGELOCK from page to page_ext
>>> lockdep: Add a boot parameter enabling to track page locks using
>>> lockdep and disable it by default
>>
>> I don't like the way you've structured this patch series; first adding
>> the lockdep map to struct page, then moving it to page_ext.
>
> Hello,
>
> I will make them into one patch.
I've thought it more.
Actually I did it because I thought I'd better make it into two
patches since it makes reviewers easier to review. It doesn't matter
which one I choose, but I prefer to split it.
But, if you are strongly against it, then I will follow you.
--
Thanks,
Byungchul
next prev parent reply other threads:[~2017-12-05 6:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 5:16 [PATCH v2 0/4] lockdep/crossrelease: Apply crossrelease to page locks Byungchul Park
2017-12-04 5:16 ` [PATCH v2 1/4] lockdep: Apply crossrelease to PG_locked locks Byungchul Park
2017-12-04 5:16 ` [PATCH v2 2/4] lockdep: Apply lock_acquire(release) on __Set(__Clear)PageLocked Byungchul Park
2017-12-04 5:16 ` [PATCH v2 3/4] lockdep: Move data of CONFIG_LOCKDEP_PAGELOCK from page to page_ext Byungchul Park
2017-12-04 5:16 ` [PATCH v2 4/4] lockdep: Add a boot parameter enabling to track page locks using lockdep and disable it by default Byungchul Park
2017-12-05 5:30 ` [PATCH v2 0/4] lockdep/crossrelease: Apply crossrelease to page locks Matthew Wilcox
2017-12-05 5:46 ` Byungchul Park
2017-12-05 6:19 ` Byungchul Park [this message]
2017-12-05 7:45 ` Matthew Wilcox
2017-12-05 8:58 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55674f0a-7886-f1d2-d7f1-6bf42c1e89e3@lge.com \
--to=byungchul.park@lge.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=jack@suse.cz \
--cc=jlayton@redhat.com \
--cc=kernel-team@lge.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=pombredanne@nexb.com \
--cc=rgoldwyn@suse.com \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
--cc=vinmenon@codeaurora.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).