From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753978AbbFAX1m (ORCPT ); Mon, 1 Jun 2015 19:27:42 -0400 Received: from lists.s-osg.org ([54.187.51.154]:45910 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751468AbbFAX1f (ORCPT ); Mon, 1 Jun 2015 19:27:35 -0400 Message-ID: <556CEA65.5090900@osg.samsung.com> Date: Mon, 01 Jun 2015 17:27:33 -0600 From: Shuah Khan Organization: Samsung Open Source Group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Andy Lutomirski CC: Andy Lutomirski , Ingo Molnar , Jan Beulich , X86 ML , "linux-kernel@vger.kernel.org" , Shuah Khan Subject: Re: [PATCH] x86_32, entry, selftests: Add a selftest for kernel entries from vm86 mode References: <09a9916761e0a9e42d4922f147af45a0079cc1e8.1432936374.git.luto@kernel.org> <556C8209.1030007@osg.samsung.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/01/2015 04:54 PM, Andy Lutomirski wrote: > On Mon, Jun 1, 2015 at 9:02 AM, Shuah Khan wrote: >> On 05/29/2015 03:58 PM, Andy Lutomirski wrote: >>> Test a couple of special cases in 32-bit kernels for entries from >>> vm86 mode. This will OOPS both old kernels due to a bug and and >>> 4.1-rc5 due to a regression I introduced, and it should make sure >>> that the SYSENTER-from-vm86-mode hack in the kernel keeps working. >>> >>> Tests: 394838c96013 x86/asm/entry/32: Fix user_mode() misuses >>> Tests: 7ba554b5ac69 x86/asm/entry/32: Really make user_mode() work correctly for VM86 mode >>> Signed-off-by: Andy Lutomirski >>> --- >>> >>> Ingo, Shuah: I think this should go in through -tip. (In general, I think >>> new x86 tests that don't have interesting interactions with the kselftest >>> infrastructure should go in through -tip, especially tests such as this one >>> that are related to recent regressions.) >> >> No problem going through tip. Could you please make sure >> >> "make kselftest" run from top level and >> tools/testing/selftests/kselftest_install.sh >> >> don't break? > > Both 'make kselftest -j12 TARGETS=x86' and > ../../../tools/testing/selftests/kselftest_install.sh work for me. > (The .. thing is annoying -- would it make sense to fix it to work > from the kernel tree root?) > What is annoying about it and how would it get solved by making it run from the kernel tree root? -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978