From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753348AbbFBGhz (ORCPT ); Tue, 2 Jun 2015 02:37:55 -0400 Received: from mga03.intel.com ([134.134.136.65]:47291 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751542AbbFBGhr (ORCPT ); Tue, 2 Jun 2015 02:37:47 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,538,1427785200"; d="scan'208";a="739217025" Message-ID: <556D4F2B.5040107@linux.intel.com> Date: Tue, 02 Jun 2015 14:37:31 +0800 From: Jiang Liu Organization: Intel User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Dave Jiang , Dan Williams , Vinod Koul , Jarkko Nikula , "Rafael J. Wysocki" CC: David Woodhouse , Tony Luck , x86@kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org Subject: Re: [RFC Patch V1] ioatdma: Ignore IOAT devices under hotplug-capable PCI host bridge References: <1433226969-8748-1-git-send-email-jiang.liu@linux.intel.com> In-Reply-To: <1433226969-8748-1-git-send-email-jiang.liu@linux.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ccing Rafael, it's ACPI hotplug related. On 2015/6/2 14:36, Jiang Liu wrote: > The dmaengine core assumes that async DMA devices will only be removed > when they not used anymore, or it assumes dma_async_device_unregister() > will only be called by dma driver exit routines. But this assumption is > not true for the IOAT driver, which calls dma_async_device_unregister() > from ioat_remove(). So current IOAT driver doesn't support device > hot-removal because it may cause system crash to hot-remove an inuse > IOAT device. > > To support CPU socket hot-removal, all PCI devices, including IOAT > devices embedded in the socket, will be hot-removed. The idea solution > is to enhance the dmaengine core and IOAT driver to support hot-removal, > but that's too hard. > > This patch implements a hack to disable IOAT devices under hotplug-capable > CPU socket so it won't break socket hot-removal. > > Signed-off-by: Jiang Liu > --- > drivers/dma/ioat/pci.c | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/drivers/dma/ioat/pci.c b/drivers/dma/ioat/pci.c > index 76f0dc688a19..3b8c9b03f4b3 100644 > --- a/drivers/dma/ioat/pci.c > +++ b/drivers/dma/ioat/pci.c > @@ -27,6 +27,7 @@ > #include > #include > #include > +#include > #include "dma.h" > #include "dma_v2.h" > #include "registers.h" > @@ -148,6 +149,34 @@ alloc_ioatdma(struct pci_dev *pdev, void __iomem *iobase) > return d; > } > > +/* > + * The dmaengine core assumes that async DMA devices will only be removed > + * when they not used anymore, or it assumes dma_async_device_unregister() > + * will only be called by dma driver exit routines. But this assumption is > + * not true for the IOAT driver, which calls dma_async_device_unregister() > + * from ioat_remove(). So current IOAT driver doesn't support device > + * hot-removal because it may cause system crash to hot-remove inuse IOAT > + * devices. > + * > + * This is a hack to disable IOAT devices under ejectable PCI host bridge > + * so it won't break PCI host bridge hot-removal. > + */ > +static bool ioat_pci_has_ejectable_acpi_ancestor(struct pci_dev *pdev) > +{ > +#ifdef CONFIG_ACPI > + struct pci_bus *bus = pdev->bus; > + struct acpi_device *adev; > + > + while (bus->parent) > + bus = bus->parent; > + for (adev = ACPI_COMPANION(bus->bridge); adev; adev = adev->parent) > + if (adev->flags.ejectable) > + return true; > +#endif > + > + return false; > +} > + > static int ioat_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) > { > void __iomem * const *iomap; > @@ -155,6 +184,11 @@ static int ioat_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) > struct ioatdma_device *device; > int err; > > + if (ioat_pci_has_ejectable_acpi_ancestor(pdev)) { > + dev_dbg(&pdev->dev, "ignore ejectable IOAT device.\n"); > + return -ENODEV; > + } > + > err = pcim_enable_device(pdev); > if (err) > return err; >