From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752786AbbFCBQo (ORCPT ); Tue, 2 Jun 2015 21:16:44 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:11398 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752516AbbFCBQh (ORCPT ); Tue, 2 Jun 2015 21:16:37 -0400 Message-ID: <556E5544.2010404@huawei.com> Date: Wed, 3 Jun 2015 09:15:48 +0800 From: "Wangnan (F)" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Arnaldo Carvalho de Melo CC: , , , , , , , , , , , , , , Subject: Re: [RFC PATCH v5 03/30] tools build: Add feature check for eBPF API References: <1433144296-74992-1-git-send-email-wangnan0@huawei.com> <1433144296-74992-4-git-send-email-wangnan0@huawei.com> <20150602221156.GT624@kernel.org> In-Reply-To: <20150602221156.GT624@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.66.109] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/6/3 6:11, Arnaldo Carvalho de Melo wrote: > Em Mon, Jun 01, 2015 at 07:37:49AM +0000, Wang Nan escreveu: >> In this patch, eBPF API is checked by compiling a c source file which >> uses fields in bpf_attr which will be used by libbpf. > Something is missing, where is the message saying that I need to install > something to have bpf support? Look at the liblzma one at config/Makefile:556: > > [acme@zoo linux]$ rm -rf /tmp/build/perf ; mkdir -p /tmp/build/perf ; m > make: Entering directory '/home/git/linux/tools/perf' > BUILD: Doing 'make -j4' parallel build > > Auto-detecting system features: > ... dwarf: [ OFF ] > ... glibc: [ on ] > ... gtk2: [ on ] > ... libaudit: [ OFF ] > ... libbfd: [ on ] > ... libelf: [ OFF ] > ... libnuma: [ OFF ] > ... libperl: [ on ] > ... libpython: [ OFF ] > ... libslang: [ OFF ] > ... libunwind: [ OFF ] > ... libdw-dwarf-unwind: [ OFF ] > ... zlib: [ OFF ] > ... lzma: [ OFF ] > ... bpf: [ OFF ] > > config/Makefile:245: No libelf found, disables 'probe' tool, please install elfutils-libelf-devel/libelf-dev > config/Makefile:325: Disabling post unwind, no support found. > config/Makefile:366: No libaudit.h found, disables 'trace' tool, please install audit-libs-devel or libaudit-dev > config/Makefile:381: slang not found, disables TUI support. Please install slang-devel or libslang-dev > config/Makefile:466: No 'Python.h' (for Python 2.x support) was found: disables Python support - please install python-devel/python-dev > config/Makefile:556: No liblzma found, disables xz kernel module decompression, please install xz-devel/liblzma-dev > config/Makefile:569: No numa.h found, disables 'perf bench numa mem' benchmark, please install numactl-devel/libnuma-devel/libnuma-dev > MKDIR /tmp/build/perf/util/ > CC /tmp/build/perf/util/abspath.o Those messages are printed by perf's makefile. I'll add them in patch 23/30 'perf tools: Make perf depend on libbpf'. I think error message in this patch is not required, because other feature checks are also silent when it found something is missing. > > Applied the first two patches in this series, will push them soon. Do you want me to repost a full v6 series with those error messages added or only repost a v6 of 23/30 by replying the v5 patch? Thank you. > > - Arnaldo