From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Tony Lindgren <tony@atomide.com>, Thomas Gleixner <tglx@linutronix.de>
Cc: Keerthy <j-keerthy@ti.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Tero Kristo <kristo@kernel.org>
Subject: Re: [PATCH 1/2] clocksource/drivers/timer-ti-dm: Prepare to handle dra7 timer wrap issue
Date: Mon, 22 Mar 2021 16:55:31 +0100 [thread overview]
Message-ID: <556d55af-0b30-8751-6aef-2e1bb9db1a76@linaro.org> (raw)
In-Reply-To: <20210304073737.15810-2-tony@atomide.com>
On 04/03/2021 08:37, Tony Lindgren wrote:
> There is a timer wrap issue on dra7 for the ARM architected timer.
> In a typical clock configuration the timer fails to wrap after 388 days.
>
> To work around the issue, we need to use timer-ti-dm timers instead.
>
> Let's prepare for adding support for percpu timers by adding a common
> dmtimer_clkevt_init_common() and call it from dmtimer_clockevent_init().
> This patch makes no intentional functional changes.
>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
[ ... ]
> @@ -575,33 +574,60 @@ static int __init dmtimer_clockevent_init(struct device_node *np)
> */
> writel_relaxed(OMAP_TIMER_CTRL_POSTED, t->base + t->ifctrl);
>
> + if (dev->cpumask == cpu_possible_mask)
> + irqflags = IRQF_TIMER;
> + else
> + irqflags = IRQF_TIMER | IRQF_NOBALANCING;
Can you explain the reasoning behind the test above ?
[ ... ]
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2021-03-22 15:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 7:37 [PATCH 0/2] Fixes for for dra7 timer wrap errata i940 Tony Lindgren
2021-03-04 7:37 ` [PATCH 1/2] clocksource/drivers/timer-ti-dm: Prepare to handle dra7 timer wrap issue Tony Lindgren
2021-03-22 15:55 ` Daniel Lezcano [this message]
2021-03-22 16:33 ` Tony Lindgren
2021-03-22 18:23 ` Daniel Lezcano
2021-03-23 6:31 ` Tony Lindgren
2021-03-04 7:37 ` [PATCH 2/2] clocksource/drivers/timer-ti-dm: Handle dra7 timer wrap errata i940 Tony Lindgren
2021-03-22 10:15 ` Daniel Lezcano
2021-03-22 10:17 ` Tony Lindgren
2021-03-23 7:43 [PATCHv2 0/2] Fixes for for " Tony Lindgren
2021-03-23 7:43 ` [PATCH 1/2] clocksource/drivers/timer-ti-dm: Prepare to handle dra7 timer wrap issue Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556d55af-0b30-8751-6aef-2e1bb9db1a76@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=j-keerthy@ti.com \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).