From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753857AbbFDU37 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 4 Jun 2015 16:29:59 -0400
Received: from terminus.zytor.com ([198.137.202.10]:50585 "EHLO mail.zytor.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752433AbbFDU35 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 4 Jun 2015 16:29:57 -0400
Message-ID: <5570B51F.4060908@zytor.com>
Date: Thu, 04 Jun 2015 13:29:19 -0700
From: "H. Peter Anvin" <hpa@zytor.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Rusty Russell <rusty@rustcorp.com.au>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        Xen-devel <xen-devel@lists.xen.org>
CC: David Vrabel <david.vrabel@citrix.com>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        x86@kernel.org, linux-kernel@vger.kernel.org,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>, lguest@lists.ozlabs.org,
        stable@vger.kernel.org
Subject: Re: [PATCH] x86/cpu: Fix SMAP check in PVOPS environments
References: <1433323874-6927-1-git-send-email-andrew.cooper3@citrix.com> <556FF270.5060306@zytor.com> <5570131C.1000704@citrix.com> <873827uu2i.fsf@rustcorp.com.au>
In-Reply-To: <873827uu2i.fsf@rustcorp.com.au>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/04/2015 12:55 PM, Rusty Russell wrote:
> 
> Yeah, hard cases make bad law.
> 
> I'm not too unhappy with this fix; ideally we'd rename save_fl and
> restore_fl to save_eflags_if and restore_eflags_if too.
> 

I would be fine with this... but please document what the bloody
semantics of pvops is actually supposed to be.

	-hpa