From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932348AbbFIHJu (ORCPT ); Tue, 9 Jun 2015 03:09:50 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:33883 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752650AbbFIHJm (ORCPT ); Tue, 9 Jun 2015 03:09:42 -0400 Message-ID: <55769132.6070601@monstr.eu> Date: Tue, 09 Jun 2015 09:09:38 +0200 From: Michal Simek Reply-To: monstr@monstr.eu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Julia Lawall , Michal Simek CC: Paul Bolle , Kedareswara rao Appana , dan.j.williams@intel.com, vinod.koul@intel.com, michal.simek@xilinx.com, soren.brinkmann@xilinx.com, appanad@xilinx.com, punnaia@xilinx.com, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Srikanth Thokala , Greg Kroah-Hartman , Joe Perches , Fengguang Wu Subject: Re: [PATCH v4 2/2] dma: Add Xilinx AXI Central Direct Memory Access Engine driver support References: <1432228035-6569-1-git-send-email-appanad@xilinx.com> <1432290653.27695.97.camel@x220> <557681A7.7080202@monstr.eu> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IQoStNdsXBeKNNOT756jpjWMKn8kjwMfs" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IQoStNdsXBeKNNOT756jpjWMKn8kjwMfs Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 06/09/2015 08:10 AM, Julia Lawall wrote: >=20 >=20 > On Tue, 9 Jun 2015, Michal Simek wrote: >=20 >> Hi Paul, >> >> On 05/22/2015 12:30 PM, Paul Bolle wrote: >>> Again, just a nit: a license mismatch. >>> >>> On Thu, 2015-05-21 at 22:37 +0530, Kedareswara rao Appana wrote: >>> >>>> + * This program is free software: you can redistribute it and/or mo= dify >>>> + * it under the terms of the GNU General Public License as publishe= d by >>>> + * the Free Software Foundation, either version 2 of the License, o= r >>>> + * (at your option) any later version. >>> >>>> +MODULE_LICENSE("GPL v2"); >>> >>> As I said in the message I sent a short while ago: here too I think t= hat >>> either the comment at the top of this file or the ident used in the >>> MODULE_LICENSE() macro needs to change. >> >> This is not just the problem with this driver but with others too. >> Have you sent any patch to add GPL v2+ to license.h? >> >> Also sort of checking for this will be great. Julia? >=20 > If this requires checking the contents of comment, Coccinelle currently= =20 > can't help with that. Perhaps an idea would be to just do a grep on th= e=20 > file. So if I find MODULE_LICENSE("GPL v2") and then grepping for "eit= her=20 > vresion 2" gives success, then there is a problem? It's obviously not = > foolproof, but perhaps it could be helpful. Having some sort of checking somewhere will be great. checkpatch? zero-day testing system? Thanks, Michal --=20 Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform --IQoStNdsXBeKNNOT756jpjWMKn8kjwMfs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iEYEARECAAYFAlV2kTIACgkQykllyylKDCEyPwCgimG8atylL+kMnvri0uG4Aut0 8HQAoIbZNQmp+BgZo0QxGX5q9XfgWgPG =tOjZ -----END PGP SIGNATURE----- --IQoStNdsXBeKNNOT756jpjWMKn8kjwMfs--