From: Jeffrey Hugo <jhugo@codeaurora.org>
To: Lina Iyer <lina.iyer@linaro.org>, ohad@wizery.com
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Gross <agross@codeaurora.org>
Subject: Re: [PATCH RFC v2 1/2] hwspinlock: Introduce raw capability for hwspinlocks
Date: Tue, 09 Jun 2015 10:59:50 -0600 [thread overview]
Message-ID: <55771B86.4050708@codeaurora.org> (raw)
In-Reply-To: <1433867020-7746-2-git-send-email-lina.iyer@linaro.org>
Two minor nits I noticed.
On 6/9/2015 10:23 AM, Lina Iyer wrote:
> The hwspinlock framework, uses a s/w spin lock around the hw spinlock to
> ensure that only process acquires the lock at any time. This is the most
Should this be "ensure that only one process"?
<snip>
> Introduce hwcaps member for hwspinlock_device. The hwcaps represents the
Technically you added it to the hwspinlock struct, not
hwspinlock_device. Mentioning that the hwcaps member was added to
hwspinlock_device in the description here may be slightly confusing.
--
Jeffrey Hugo
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum, a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-06-09 17:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 16:23 [PATCH RFC v2 0/2] hwspinlock: Introduce raw capability for hwspinlock_device Lina Iyer
2015-06-09 16:23 ` [PATCH RFC v2 1/2] hwspinlock: Introduce raw capability for hwspinlocks Lina Iyer
2015-06-09 16:59 ` Jeffrey Hugo [this message]
2015-06-09 16:23 ` [PATCH RFC v2 2/2] hwspinlock: qcom: Lock #7 is special lock, uses dynamic proc_id Lina Iyer
2015-06-10 17:33 ` Bjorn Andersson
2015-06-10 20:13 ` Lina Iyer
2015-06-27 3:05 ` [PATCH RFC v2 0/2] hwspinlock: Introduce raw capability for hwspinlock_device Lina Iyer
2015-06-27 11:25 ` Ohad Ben-Cohen
2015-07-02 20:30 ` Lina Iyer
2015-07-18 11:31 ` Ohad Ben-Cohen
2015-07-28 21:51 ` Lina Iyer
2015-08-13 6:34 ` Ohad Ben-Cohen
2015-08-13 15:25 ` Andy Gross
2015-08-14 10:52 ` Ohad Ben-Cohen
2015-08-14 13:52 ` Lina Iyer
2015-08-14 15:24 ` Lina Iyer
2015-09-20 13:02 ` Ohad Ben-Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55771B86.4050708@codeaurora.org \
--to=jhugo@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=lina.iyer@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).