From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753629AbbFIRIg (ORCPT ); Tue, 9 Jun 2015 13:08:36 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:36203 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932095AbbFIRI2 (ORCPT ); Tue, 9 Jun 2015 13:08:28 -0400 Message-ID: <55771D88.4050603@linaro.org> Date: Tue, 09 Jun 2015 18:08:24 +0100 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Mark Brown CC: alsa-devel@alsa-project.org, Rob Herring , Patrick Lai , Banajit Goswami , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kwestfie@codeaurora.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v5 1/2] ASoC: qcom: document apq8016 sbc machine driver bindings References: <1433854702-23654-1-git-send-email-srinivas.kandagatla@linaro.org> <1433854769-23807-1-git-send-email-srinivas.kandagatla@linaro.org> <20150609165718.GH14071@sirena.org.uk> In-Reply-To: <20150609165718.GH14071@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/06/15 17:57, Mark Brown wrote: > On Tue, Jun 09, 2015 at 01:59:29PM +0100, Srinivas Kandagatla wrote: > >> >+Optional CPU/CODEC subnodes properties: >> >+- external : flag to indicate if the I2S is connected to external codec >> >+Example: > Missing blank line between the property and the "Example:". I'm still I will fix it in next version. > not sure I understand why we need a boolean property indicating if an > external CODEC is in use - what is the consequence of setting this > property? As of today, the consequence of setting this flag is to setup correct dai_link names. Also there are some limitations on which MI2S can be configured to external or internal codecs, this flag can be used in future to validate such configurations, if required. --srini