From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751907AbbFMIpN (ORCPT ); Sat, 13 Jun 2015 04:45:13 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:34038 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751127AbbFMIpG (ORCPT ); Sat, 13 Jun 2015 04:45:06 -0400 Message-ID: <557BED8C.6050406@monom.org> Date: Sat, 13 Jun 2015 08:45:00 +0000 From: Daniel Wagner User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Steven Rostedt , Tom Zanussi CC: daniel.wagner@bmw-carit.de, masami.hiramatsu.pt@hitachi.com, namhyung@kernel.org, josh@joshtriplett.org, andi@firstfloor.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 01/10] tracing: Update cond flag when enabling or disabling a trigger References: <20150612140107.4ced7f75@gandalf.local.home> In-Reply-To: <20150612140107.4ced7f75@gandalf.local.home> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/12/2015 06:01 PM, Steven Rostedt wrote: > > Why v3 in the subject? This patch has not changed since v3 I guess. > > On Mon, 8 Jun 2015 16:32:00 -0500 > Tom Zanussi wrote: > >> When a trigger is enabled, the cond flag should be set beforehand, >> otherwise a trigger that's expecting to process a trace record >> (e.g. one with post_trigger set) could be invoked without one. >> >> Likewise a trigger's cond flag should be reset after it's disabled, >> not before. >> >> Signed-off-by: Tom Zanussi >> Signed-off-by: Daniel Wagner > > Why is Daniel signed off by here? I have reported the issue and send a fix for this patch https://lkml.org/lkml/2015/4/21/161 I would have complained if I wasn't okay with it. cheers, daniel