From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756136AbdKCR2I (ORCPT ); Fri, 3 Nov 2017 13:28:08 -0400 Received: from mail-ve1eur01on0071.outbound.protection.outlook.com ([104.47.1.71]:4993 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751381AbdKCR2G (ORCPT ); Fri, 3 Nov 2017 13:28:06 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=cmetcalf@mellanox.com; Subject: Re: [PATCH v16 10/13] arch/arm: enable task isolation functionality To: Russell King - ARM Linux Cc: Steven Rostedt , Ingo Molnar , Peter Zijlstra , Andrew Morton , Rik van Riel , Tejun Heo , Frederic Weisbecker , Thomas Gleixner , "Paul E. McKenney" , Christoph Lameter , Viresh Kumar , Catalin Marinas , Will Deacon , Andy Lutomirski , Mark Rutland , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Francis Giraldeau References: <1509728692-10460-1-git-send-email-cmetcalf@mellanox.com> <1509728692-10460-11-git-send-email-cmetcalf@mellanox.com> <20171103172316.GP9463@n2100.armlinux.org.uk> From: Chris Metcalf Message-ID: <557d6ff4-a52a-01d8-92fd-e971f28a8b39@mellanox.com> Date: Fri, 3 Nov 2017 13:27:49 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171103172316.GP9463@n2100.armlinux.org.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [216.156.69.42] X-ClientProxiedBy: BN6PR0101CA0001.prod.exchangelabs.com (2603:10b6:405:2a::14) To AM4PR0501MB2754.eurprd05.prod.outlook.com (2603:10a6:200:5b::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 753b76ea-fa92-41bc-4c60-08d522e03bdf X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603199);SRVR:AM4PR0501MB2754; X-Microsoft-Exchange-Diagnostics: 1;AM4PR0501MB2754;3:DHnexmkTY9R+uVMR5FgTYA+ol6rtwiMfwvx36YRxEjl8D7AOg8OFINJONN0khMGfLyeULQs2de5NHA1d+GdWZrA7eD5H1Yz/MvJ0tRHPptjr3q7VA8sz5ko39vxMlm8VhlLbTgrG7A50z9ABEP4uX/RlioIPyevCoeO5Qhv64bYuoLfQTD3DJglqNqeihOfYg94ww5r4ziYKFK6rYY3pnbovwXLLtKfh9qfTz/WhhFGVDq9O6snTSotexBFQEiJz;25:nO+8v1J3x41x6ckUV1t6JiJ6MDAZQeeiz9sP0NXuw3ilvFH0LqkXe7Xu01Bi6oAgv+VG5Emm085dXJR6bbIJEZ4Q8OFx64DgRtSbESmxVjrQcFAvPFWbA0tgdLV2Ua++pfl2Ki3vzPg6e7vQ6exvOvo3SVFBdaZEve6ZQaWesjTI58ngFu8ial7Cq0HJHKa0mTDVSTU4hLqbK58mCIWx8PZdY5+uBNZbtorqDj0P/WI11hXdtroHVjfHfhBYJg9nITYsNknQTC8PTtIwpHj012Lmr1r+/nrMWEdsi7RoYauo/F0PvsrAaztxZ7IO6JBVcxOdrrL539ljtS10/YP41Q==;31:NLzIeacim/HfNMTvFfNBldVI8vG74alFowwPdeKLWUpsv+uUIdIhh7jnw/ssNbCtOHde07fif4h57iVQvOgk0ldMtBAAPPFe8FLbjGlPCED4gEhM5vd8DSxf5/GN0OWmegVJI24AQ70pCMSpQV5NKcp1Q+Tbi9+hBWDZS3lyfhCdt2bmXvp7u2qEV2XE0xTDlqRiBEqc4bgVscSACZdP2evab0+XuRgEUkKKVzsflAw= X-MS-TrafficTypeDiagnostic: AM4PR0501MB2754: X-Microsoft-Exchange-Diagnostics: 1;AM4PR0501MB2754;20:mswpQ1ihspUit0otn8MeQhM2oeXm+GpZTFOAG0f5ETsM6pdP3baczXr+ioCWCN15V3GyTol5QJHfCsWRTqyuZ+0TOu1XP91aw/TtT74FCz12/wUSk6rhy3aGMdqlQrKlCLbjUy96CrrWZ7AAx3Y+o0oK15hesfIssW+uXA4lb2wEzFdJ9xq401hzkWdyLYSlYtXQp3oS9M+OgF1ckuM+9pKXzA0b+qi0Yvr6B/6r8XHlTBFR30HPdxwLbto0ec+Ie9cUW/hwLNmvHBxgH/rRSyn6ANzpxd37Vyjy2nhW1qnXvUsJonqUq8cZZd6pmxERkqnVzV5dROrduE3tiIeXJkzWnImxKzLedcNiIad/nTe7qpwn1gd/koh4sm4Y8ilxhdcf7qmoYMhJ9fiy0E0W1ply8DYBqAhbwz2OfadtBRNPtL5SX7UOlimBwG9R2x23Id8D0nv7gcJneuoReIhv29n8oLJ9LyboXgf/qY/VPC5/cu8eNmZ3bHX3FHNM68CX;4:51x2fgJTTVB7AzYqZJPmlFYeIDiqLtFU5tgwB9vWHC/HwStIFNrjNqRshJqEmoYpXZT3U4aVbABdn8Viw/Bkb91IX40Cd9yNJdBhgJkqb9/K5bVwPW6NsEgD8+4Gn1nTuRS/MumoS2AfFA7mrp2T4HkS5dcHLmbeZNePssSK7zxT4oxnLFy/0hEjnG+cLzJbljvXRmA0sNXJUw+w8JV0DubTWgrlSuZ0HkW1CPIIYUR42ZC2UPCj+B3V7vQRdvvtCHB01vaClCOprFqG7GokOxCR59t9GPJITrXCYA7RpcrwuhZzhkjaRVIs2I/AKcq4 X-Exchange-Antispam-Report-Test: UriScan:(171992500451332); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231021)(100000703101)(100105400095)(10201501046)(3002001)(6055026)(6041248)(20161123558100)(20161123555025)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AM4PR0501MB2754;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AM4PR0501MB2754; X-Forefront-PRVS: 0480A51D4A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(346002)(376002)(39860400002)(24454002)(189002)(199003)(6116002)(2906002)(3260700006)(105586002)(25786009)(7736002)(50466002)(106356001)(8676002)(54356999)(189998001)(2870700001)(478600001)(101416001)(8936002)(68736007)(966005)(76176999)(33646002)(50986999)(81156014)(81166006)(54906003)(5660300001)(3846002)(65826007)(16526018)(83506002)(77096006)(6486002)(6306002)(316002)(16576012)(58126008)(97736004)(86362001)(36756003)(229853002)(53546010)(47776003)(66066001)(65956001)(39060400002)(6246003)(23676003)(67846002)(7416002)(65806001)(31686004)(4326008)(31696002)(6666003)(6916009)(64126003)(2950100002)(53936002)(305945005)(18886065003);DIR:OUT;SFP:1101;SCL:1;SRVR:AM4PR0501MB2754;H:[10.15.7.185];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTRQUjA1MDFNQjI3NTQ7MjM6OEE3Z2ExOFRHNitRdFN3TWtlaDFPOEQr?= =?utf-8?B?VnpTdDJRa1paR2p1aTdueHlPK3hYZEVQZTRHNkNJa2oxRDE2UXY0Z0xhR1p5?= =?utf-8?B?OXpLTVBxYmVOZWx2TjZyNFZxR3p3YnphQWNYNFhVTWRUWGNBRmlDV1VORTB1?= =?utf-8?B?Wi94VDE0ZDl4U25ReHN4OEJ0OFR3V214cnBHNUNaYlZPd0xQSUJUdVpCNjQ4?= =?utf-8?B?Nk02YWttY1VBR09La0t3UXZTQVFyOXB3ZVBmSW5aZkY2OHZpeG4zYXlOY0RV?= =?utf-8?B?RVYvNFY0S2xSL0tMMFJwV3k5MVBjb2VDZTFBOWNSRDNtSXdHckZSVUhFUTUx?= =?utf-8?B?dUd6N2dnd1FNVm1CZzNGaFdGTStZeEFQeEl2elZpY1JpblVTWSt4VGY5RXZF?= =?utf-8?B?VmJ0amErNzhxV3JNazVTMGQ4Skd1cjRxRjhiMDByM1diNXhyaTQ4UzR0R3g2?= =?utf-8?B?dTVCOHJqTGRrVkM5YmRjRzhBVVA4NXhqYkNVZi8vd2JIaWw3blY3TzQvanNF?= =?utf-8?B?Um9jTFFJdVorMWM5eVhWdzBKd2kxR3lQTTIrMXhYZHRpK2lKTk0rOFFhOGgw?= =?utf-8?B?UUlFY2FsaTB0WEtHalNPYXFqVlJiWkpsdzlqM1huQ2JaMWJKYTZpaFIrSVdI?= =?utf-8?B?UUZQR2ZobWQyZnNmVHJBOTZTTUNHUVF6UktRWEJacCsrL0FOd0tNRk1YUXVw?= =?utf-8?B?U2VQN1F1OGxSUTh2SXR1QlZHeHl4NVRQQU5GQWE5TkdpYkc4Z2dzai8rUWRa?= =?utf-8?B?aDU0elBLUWxwZkU4N080YnI1UTdPd05icnBaVXJiY0JWcUpTKzFvYmsycksv?= =?utf-8?B?NE5OdUFZS3dpbFBaK1p4TWNMdkwxT0puQTBpR1c4aW9vbkt1ZDBWRUdUR09B?= =?utf-8?B?Yk11YjlDZ3RJTEJLSndqNUYzb0F1OTdkUlpITzdIVHF4OHNkejZQRTNsZ3Q4?= =?utf-8?B?VTllZy9zNDhSTlJKRzNreXR3ODQ5VkZPdE5mOHhMK1lTR1NHc0lHeFVyZlNp?= =?utf-8?B?K1l1ZGhCT1NZOVhKcnBrQzVrNkdQRSsxRGhRZUVVSk55SXhnYnJuMitrVFBn?= =?utf-8?B?Rk52OUZEMGJaR2NqMGJCemxzd2tKQS9RVy9abVJxa21SK3J1dEluVHFvVS8w?= =?utf-8?B?QmdYQUlTZlRyTTVGU1kzOWU2elN3VjZ6RDFJMnlRWlJTcHdpazRIL2dyeDdQ?= =?utf-8?B?TFZSNmF3ZzRReXM3SENVS2lidmVzakR2WXFtN1Y4UmRUeUJFUjN6TWRWazhs?= =?utf-8?B?MDlnVHl2MWZHM0JkdmYxZFNNanlmemlLZnNJTWs3SURmN3hWbGJzc05hL0kv?= =?utf-8?B?WnBudkkxOFBqRFo0VlF0Z1dUZ0IvNUI4RERvK0JQTkJGbFZOLytZY1ZuSUV6?= =?utf-8?B?b0FFZ2M2SldDamNJYjQvRVNycUpzSFc1TjVhbDBUM2x6RlNTeEx0RXpGMHhE?= =?utf-8?B?TjJlZndGRkxsSWt1OU14bnFYNTNVcmRmZnVHU01UMERhZXhQck9rQlJDdE5O?= =?utf-8?B?dk1tSCtySHpXcHphQW1udHFzRTFsNkxlUVdNVHVNMjhrVE1GUjNSSXk3QzdE?= =?utf-8?B?d3BkdEtjS1hPdHhoYjVOMS9LZTlvM1dkdkV0N2pGdVR1RUdMdkpDRVhGbUxJ?= =?utf-8?B?Wmt2WFlzTTFaRmVrUWtxMHpjR0xIZkd6c1JSUmR5cmpYRnZFQ2x0ZXQyWkp4?= =?utf-8?B?b1pzQ1ZZQmgzbGZvQkFKUnpaQ0hHWnhuZmJDZC90cDcrellneXp5Mk9UdEp2?= =?utf-8?B?dXhFNVJ6NmExaXFDb2hYL0k0clptK0ZpOHJkZEEyejVQaGlpMDQ5TWUyT0Zi?= =?utf-8?B?TDFKN0tHMzZNQmhMNkFjWEtHcnE5dnNtU1NWS0VpNkdNUnlhenkrYk90Ym54?= =?utf-8?B?djhaZHJHdEFsV1lQMmxma0I2VXlzZ3VKdkJsbFpjQmh6bjRLOWpHZHNKV00x?= =?utf-8?B?Mk43V09NMHgyVGRweXh3ZzdFdXMraERpSFJJZ1RpYmlyVHNTL1RrK2xTZGpP?= =?utf-8?B?bDlzalN4bkJMcHB2bHdzZktDQVhuNFNHbGxWTXd1cWlQWXFUWUVEOGs2QUdR?= =?utf-8?Q?7sAuDk=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM4PR0501MB2754;6:5avNVRhxk8o8JcA2AAeiTXXZ9eGsSzqxzwMIipm+FwaS5AWlR0I7A/C/HbP9FWriH4FtisG3WO62eBL0tfjbPXvE0UInyj3tDnrMnW4UIdizmynaBb4cILZP/dv6T+TifEH4FjzI0PUgiqXgN7w76sehKZWCfx/Br0Y7X59IxNdPGi9O8R3gTsGcPg3lS0KOaie7CRLexzycZhX5l9fdv/Y8rMm3dKrFVu3+oCh2WLh2Z6pBrVymAiC7gDg50rkPaBWdcvXf6A1BXUdp1CS+Tl3wfvN+qyEu7RtQgX2co3DJIJinHaE7HtIYgvQolUGR8+gTIAMQ4THKTFoL4UzkSTvxJxK46YqYmQbBn5PtD9M=;5:wV6ruuwHBfLkcOkVk41RuNW10cIeUzhcBzS6Xm9McGQ6klLsGFhPTmxEuPcSEM7kB2iSYgQ57V0G9uselobvDOS5xbK6CJ7VpMusX0S7qK8TOAPrIPwTux+CKZbdZh8LnsNuddBUSQ8PTEzNhMCtyUrRxnhy0tcAAWUuYa7IwpA=;24:pttSm0ndtRrZhauWoQXJJ+/qlayjNdnTe3l1tAZXHUXwQzn1kJBZo3W0cymHY3v1TLYtr1O+vsKoNXC7TFz9GPhGjEihKSD+97iokRXRjPA=;7:RBpdOYSEmV4mUdwWdXaebtIV+rfp+lgPzunxkUumcSM0MtMHoxv2xIzM0qKuOsSVpaqhVuDqbGzsjFWHx0rLR+GW6zSvsfHVy5wtgfGFjT/tCVClX+UFIWmTUDNmAVSZUtxbzXSHw758zW/tabAxU3U5DISjM3+5ylfIOWuBTxuh8/WLDyyTclSOlTagFuLcgZ7JtvFf020bup624oi7L8oQhaDx/aJlDpJy+umdrDSlL11o1fLjxFM2PS8/cGLf SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2017 17:27:58.5926 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 753b76ea-fa92-41bc-4c60-08d522e03bdf X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0501MB2754 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/3/2017 1:23 PM, Russell King - ARM Linux wrote: > On Fri, Nov 03, 2017 at 01:04:49PM -0400, Chris Metcalf wrote: >> From: Francis Giraldeau >> >> This patch is a port of the task isolation functionality to the arm 32-bit >> architecture. The task isolation needs an additional thread flag that >> requires to change the entry assembly code to accept a bitfield larger than >> one byte. The constants _TIF_SYSCALL_WORK and _TIF_WORK_MASK are now >> defined in the literal pool. The rest of the patch is straightforward and >> reflects what is done on other architectures. >> >> To avoid problems with the tst instruction in the v7m build, we renumber >> TIF_SECCOMP to bit 8 and let TIF_TASK_ISOLATION use bit 7. > After a bit of digging (which could've been saved if our patch format > contained information about what kernel version this patch was > generated against) it turns out that this patch will not apply since > commit 73ac5d6a2b6ac ("arm/syscalls: Check address limit on user-mode > return") has been applied, which means the TIF numbers have changed > as well as the assembly code that your patch touches. > > My guess is that this patch was generated from a 4.13 kernel, so > misses the 4.14-rc1 changes. Since we're potentially about to start > the merge window for 4.15 this weekend, the timing of this doesn't > work well either. What patch failure did you see?  The patch is based against 4.14-rc4, so while it's a few weeks out of date, it does include the commit you reference. > Once 4.15-rc1 has been published, please rebase against that version > and resend. Sure.  I was hoping to eke out a little bit of attention from kernel developers before the merge window actually opens :) -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com