From: "Jan Beulich" <JBeulich@suse.com>
To: "Julien Grall" <julien.grall@citrix.com>
Cc: "Ian Campbell" <ian.campbell@citrix.com>,
"Wei Liu" <wei.liu2@citrix.com>, <xen-devel@lists.xenproject.org>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format
Date: Wed, 17 Jun 2015 10:13:12 +0100 [thread overview]
Message-ID: <558156480200007800085EAB@mail.emea.novell.com> (raw)
In-Reply-To: <1434481848-26387-4-git-send-email-julien.grall@citrix.com>
>>> On 16.06.15 at 21:10, <julien.grall@citrix.com> wrote:
> Append 0x to all %x in order to avoid while reading when there is other
> decimal value in the log.
To save on the space taken by the format strings you should prefer
%#x over 0x%x (like we do in the hypervisor).
Jan
next prev parent reply other threads:[~2015-06-17 9:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 19:10 [PATCH v4 0/3] net/xen: Clean up Julien Grall
2015-06-16 19:10 ` [PATCH v4 1/3] net/xen-netfront: Correct printf format in xennet_get_responses Julien Grall
2015-06-21 16:41 ` David Miller
2015-06-16 19:10 ` [PATCH v4 2/3] net/xen-netback: Remove unused code in xenvif_rx_action Julien Grall
2015-06-21 16:41 ` David Miller
2015-06-16 19:10 ` [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format Julien Grall
2015-06-16 20:07 ` Sergei Shtylyov
2015-06-16 22:09 ` Joe Perches
2015-06-16 22:29 ` Sergei Shtylyov
2015-06-16 23:55 ` Joe Perches
2015-06-17 8:54 ` Ian Campbell
2015-06-17 9:13 ` Jan Beulich [this message]
2015-06-17 9:25 ` Ian Campbell
2015-06-17 9:30 ` Julien Grall
2015-06-17 9:37 ` Ian Campbell
2015-06-21 16:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558156480200007800085EAB@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=ian.campbell@citrix.com \
--cc=julien.grall@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).