From: Archit Taneja <architt@codeaurora.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org
Cc: robdclark@gmail.com, hali@codeaurora.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] drm/msm: dsi host: add missing of_node_put()
Date: Tue, 23 Jun 2015 10:32:02 +0530 [thread overview]
Message-ID: <5588E84A.2000509@codeaurora.org> (raw)
In-Reply-To: <5588311B.6030806@linaro.org>
On 06/22/2015 09:30 PM, Srinivas Kandagatla wrote:
>
>
> On 22/06/15 15:54, Archit Taneja wrote:
>> Decrement device node refcount if of_get_child_by_name is successfully
>> called.
>>
>> Signed-off-by: Archit Taneja <architt@codeaurora.org>
>> ---
>> drivers/gpu/drm/msm/dsi/dsi_host.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c
>> b/drivers/gpu/drm/msm/dsi/dsi_host.c
>> index de04009..1751659 100644
>> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
>> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
>> @@ -1582,6 +1582,8 @@ int msm_dsi_host_register(struct mipi_dsi_host
>> *host, bool check_defer)
>> node = of_get_child_by_name(msm_host->pdev->dev.of_node,
>> "panel");
>> if (node) {
>> + of_node_put(node);
>> +
>
> Atleast from the current state of code, It looks like the driver is
> going to refer to the node of_node_put?, So I think this is not the
> right place to have of_node_put.
That's right. I made the same mistake in the later patches too. I'll fix
these.
Thanks,
Archit
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2015-06-23 5:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-22 14:54 [PATCH 0/3] drm/msm: Use device graph to parse connected panels Archit Taneja
2015-06-22 14:54 ` [PATCH 1/3] drm/msm: dsi host: add missing of_node_put() Archit Taneja
2015-06-22 16:00 ` Srinivas Kandagatla
2015-06-23 5:02 ` Archit Taneja [this message]
2015-06-22 14:54 ` [PATCH 2/3] drm/msm: dsi host: Use device graph parsing to parse connected panel Archit Taneja
2015-06-22 14:54 ` [PATCH 3/3] drm/msm: mdp4 lvds: get panel node via of graph parsing Archit Taneja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5588E84A.2000509@codeaurora.org \
--to=architt@codeaurora.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hali@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).