From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751673AbbFXUsl (ORCPT ); Wed, 24 Jun 2015 16:48:41 -0400 Received: from mout.web.de ([212.227.17.12]:53596 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750865AbbFXUsc (ORCPT ); Wed, 24 Jun 2015 16:48:32 -0400 Message-ID: <558B1799.8040003@users.sourceforge.net> Date: Wed, 24 Jun 2015 22:48:25 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Heiko Carstens , Martin Schwidefsky , linux390@de.ibm.com, linux-s390@vger.kernel.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH] s390/process: Delete an unnecessary check before the function call "kfree" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:I8HkxNcisJlJmWaV+TUC/DGKC8THL6caKPFRo7UvXDMpRc5YhTd gpCzhE6o/OlGrYUCAh9jTS4smtbMT5vroQkXGN1Uylxr3oMM9IRCzC5/IWl/+cpOcCIHULd Ju+CaKhpAEYkxnFDqqIQeXidwtG8F3PUzAB03HxeZirKez/2v1es9c6iE8oFn4fE1Sz7D8U 8Cdz9spgVqfHcThGns+iQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:0A7GoWUDR8M=:CrabyWb2PA4ExRLV4eX2fg IDimj78AF3Ubg1hMmIz0u2Xdcls3gUuGF+JPVkLfBkthXUGOe8/Jb3YcJh7H9nDWj1iz/Zlw3 xX28GaxQxK3AHW35OAzbz0cWQg/NdK0VH8r2jq529PGlC0Cy67Nu1ZlG/25priYpq+OmI3LB/ OBIurSlTDHX7r8KJpsfb6dmvy2nR30suSPis8zMfpwTDbhK89wdIFegSAE2LzYNfqIi/PhJEQ gziiBG3r7cCgEjw+dRkMNi13yxcttRyL/Kjc9lIDitk0WHtVwehV5ah/dZDXdzBg3EDdwi7/B zSyRgHgQL8fAzvvB/gBavLEtE3Cr+26VWozFT4sc8uJ8qLSNgOkrEBsshvc0rhDHUyBJ0AhTp 7Q8NK5IX5wrQ/8JmPhwZ42JcSfpmgWiB+IaPb08Ipg3h+OFz3XgxJNH81BBJ21LuNEDtVe6gZ K7mBkqojygz9z0NRfb/AG1VFTzEi55qruLMN7rNv0rCiWEl3CiW5PynGMo4raD0vI3rH3LmE/ lQBq/PiJyT3mxKWF3sMHQz9Fsc1Zoje78ARf4PRHvk6leEcOD/bi0MUuj9HQXUlwjLEGU9w5n fh1lFb0UxfTF3VH8TMmpUiVNaC8JZdzGgsgZzp6HdsVfzPgjWBotRfHpeVut1xjzZAaGXSlrN 0wV1AjHT8uSjOKScEy2H0VRdBvKwPg25WwMY5zJBnziYYmlNgVbq1Mf6wEedbAyCmjdI= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 24 Jun 2015 22:40:30 +0200 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/s390/kernel/process.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/s390/kernel/process.c b/arch/s390/kernel/process.c index dc5edc2..22e6448 100644 --- a/arch/s390/kernel/process.c +++ b/arch/s390/kernel/process.c @@ -81,8 +81,7 @@ void release_thread(struct task_struct *dead_task) void arch_release_task_struct(struct task_struct *tsk) { - if (tsk->thread.vxrs) - kfree(tsk->thread.vxrs); + kfree(tsk->thread.vxrs); } int copy_thread(unsigned long clone_flags, unsigned long new_stackp, -- 2.4.4