From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752001AbbFYNbR (ORCPT ); Thu, 25 Jun 2015 09:31:17 -0400 Received: from mout.web.de ([212.227.17.12]:55118 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751069AbbFYNbI (ORCPT ); Thu, 25 Jun 2015 09:31:08 -0400 Message-ID: <558C028B.7020907@users.sourceforge.net> Date: Thu, 25 Jun 2015 15:30:51 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Russell King , linux-arm-kernel@lists.infradead.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH 1/2] ARM-kernel: Delete an unnecessary check before the function call "smp_set_ops" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <558C01C5.4060303@users.sourceforge.net> In-Reply-To: <558C01C5.4060303@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:5Z3A1iMg6kGy49hBKUFZzuWdlwsjac1+btm1FShIOpf71My3uIU 96LETBOx+I4mYSOt6AIvOmkBCoVvRQrii0uYgiRUdmwYqhRndVGfP4b0tYPQiRSlV68EHtH qYTjSnExcghYaCqjq9/wWmqfa/c8WrB3vWjoIMyoEbwc4MfY2PyLLoQU7cVs7aTyKFCAQUL +XqHM/7gZnygsWZU3DvUQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:4VOUlLUiaKc=:N6fosGiJiwmrrWphK1lTf7 iS/tlNoLVQqty/uNHi4nshvaL+URHJrA0cgp2qhMrESQGfE04R2EdHfD0JTAdBF0qGJFBSVwN NM+SGDQMijbPc0NRCW9OyA9WQWX/ZUWeJWRowOO96aC8HXHlmQU7o+57bmAnjcwYL7RpLcA0f 7ZnYOnTm8bmJ/s/vtVCaw/reY6sDEvdBfUo2cRq4vsM2Ls08r7wD7L2fULWp777YjZcIY9Rh5 tMntPCDSdUzrjM+zHmadd3aZojl8A1ge1o1AQlLBQUdf4JrkF6IoC4pUJ/tJZvOUmr4PmWoeV zI/eMmh2VDswfydAUwi0LZaFra+M7SWyeXnT0eJK93iRXjzLPaB0hOnt7wU4tc2e2ZR6ntPT9 wxbmrLoqpIQ7yXs7kIv+JmhSkFeevmC4xlRS9+2Fb1LWbrWYu1G4Umc+siO7hSjkuD1re7tH/ UC8YulcGVNoSnBOMOe6qPpelNsk19WTUjfXsOCLkxu0vUnWlyTB62LPMTrxEwlqMO3b3k66IU PUntGdMXWIixbjGLIp7UES3ryL89WmisQiJ5yed7bQwrPMynU5QjDzt0rq4lUfdH58VBsidbw aV3rrhUZtIwIWWIQEqSOkMNIih1UFFDd9mAKO9SOb3rkD5iS9KjTRYeDZ4h9xoqbywBoCa35h pAp9xUgwDxlyknZiDRrnUgx+RdElehiA0p9sFb+8jXuM+kACKl5dVQPFnanl6qpq7jdE= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 25 Jun 2015 15:00:17 +0200 The smp_set_ops() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/arm/kernel/setup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c index e6d8c76..9ac786d 100644 --- a/arch/arm/kernel/setup.c +++ b/arch/arm/kernel/setup.c @@ -977,7 +977,7 @@ void __init setup_arch(char **cmdline_p) if (!mdesc->smp_init || !mdesc->smp_init()) { if (psci_smp_available()) smp_set_ops(&psci_smp_ops); - else if (mdesc->smp) + else smp_set_ops(mdesc->smp); } smp_init_cpus(); -- 2.4.4