From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752278AbbFYNdH (ORCPT ); Thu, 25 Jun 2015 09:33:07 -0400 Received: from mout.web.de ([212.227.17.11]:61548 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750983AbbFYNdA (ORCPT ); Thu, 25 Jun 2015 09:33:00 -0400 Message-ID: <558C0304.6050204@users.sourceforge.net> Date: Thu, 25 Jun 2015 15:32:52 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Russell King , linux-arm-kernel@lists.infradead.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH 2/2] ARM-kernel: Delete an unnecessary check before the function call "unwind_table_del" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <558C01C5.4060303@users.sourceforge.net> In-Reply-To: <558C01C5.4060303@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:v+JK0g+uqVB2J8bteHoQpMg34WJCbZQvsJB7Bkm4yx0muqjR/3k Emvzx78aq1LqcM3AK3MAP5aJrEhDF3GuY/EZ2e7dnV0h2t2uLqwgr9y+qHWvE4nhTvQZps0 3kTJxqURiJ7uaLZo5ZnQ8kiPweslpfTs5hT/bTLQWnjHDJtU4AzySZ+rrGfeq5ux0iXkzYx dAkTn2wMVO3q9Iyulk8jw== X-UI-Out-Filterresults: notjunk:1;V01:K0:GTzpt24/BUI=:gOdxXirHG1gh55AoDgh19v kTETmgHYIsIzwZQnExAhQ4B9luD2ht3ViLyt8TbmmZNoEi9OBWfSTR7r/G1WwW2Rgp84Hqa8p +r3klM1N1ky4jWQA1jJKMWUt2cMLGdCJFUuvJ1g8NxQsoYMH2IA4FBZBHYAtVVlNGIO2lyhRP 5v3wOaszOD0wXD4kmfcYE8SK6ToAoPJRqkiopwXVlFn8leKYNIhPozlXVZdei7UwsxsHlvUoB qwxnyYSqsEArRfz2RuPMguBTZN+VQWKpWp9iezF7vk/A4gqu+oQVrq/R2fIZJVBV7hE0mEuoX rwenGqlo7Gl7VYUMZh/4yPUkFq6cnewrQOaxRN4OItHCrR503ntjBGeY88RiwcAnAZBNgCAkN zzY0hOuD5n9Wd8USVxXseaU9Q4Qi0imzwibJn1wU5dolhWMTpiPKGOwAEw6YYpI/QwjuoNKqJ mG87Hs+Wg5iOhQDlPIHizD6eIftFBuouzg94yQ3BcejDMATRqjwdhTUG2L4wwjrvcYlJTvVqV rATMFZUOX6TOIUmfpcAET51GJNUk/S5rFMSXgzTjua20iH8R00ABz7VNAJFic6+0HhEbV4Z/b pIt90tTdUZ9RYS18yOYvdPZkN0JSTLXZdM1ND1QfwD0D+IIATKgJPAsUHtuG+66ZOamLn4Sg+ 76nnRfksOOFurBl4fyE7xZORIhmsCTSNOvIhloBIdiCiEAta+od2pzxhZirl89ZoBmHM= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 25 Jun 2015 15:05:21 +0200 The unwind_table_del() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/arm/kernel/module.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/kernel/module.c b/arch/arm/kernel/module.c index efdddcb..0cc1afa 100644 --- a/arch/arm/kernel/module.c +++ b/arch/arm/kernel/module.c @@ -390,7 +390,6 @@ module_arch_cleanup(struct module *mod) int i; for (i = 0; i < ARM_SEC_MAX; i++) - if (mod->arch.unwind[i]) - unwind_table_del(mod->arch.unwind[i]); + unwind_table_del(mod->arch.unwind[i]); #endif } -- 2.4.4