From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751756AbbFYOSR (ORCPT ); Thu, 25 Jun 2015 10:18:17 -0400 Received: from mout.web.de ([212.227.17.11]:50359 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751241AbbFYOSH (ORCPT ); Thu, 25 Jun 2015 10:18:07 -0400 Message-ID: <558C0D9B.80903@users.sourceforge.net> Date: Thu, 25 Jun 2015 16:18:03 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: linux-kernel@vger.kernel.org CC: kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH] tools lib traceevent: Delete an unnecessary check before the function call "free_arg" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <5469FB58.4070205@users.sourceforge.net> In-Reply-To: <5469FB58.4070205@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:V419aiA8NMAncOQZ9QrAdaJ6ODQUYMCGMaq+UL0AidyMenVGVkO nY5HJhwkEO8lpGx9MX8CYp7BzT7zIBBuzCVK0/lunukxpY+z1sfZyrtc4pC5YMdHe90QzLI EbCGFYy/nMJc7R/izve9NCFJ+NM6hEyiKrsbGqHI1YDQMX9A/+wlBxi9JZWN9s+mjcWSm99 DdMF9JJeTuB7CxolU7kcw== X-UI-Out-Filterresults: notjunk:1;V01:K0:LHZ3ivU8zdA=:nRwpIWn0QHK8rZxdm5sSzk QRudm/xCoviE/702nFiGnBFWZ8qDh0dIDbMMYIno4CruxgOVOnsFL5imRmcLo+ZXvGxvtsLf8 LTMj8p1ymHAjEQfAJzBwOfNp/wCmQP9ouASwW25vjYH8/V8evjqaEr9vzB994dKbtQkj0pEtJ HBSQBEcLFyuCQeUtBEaJpY1DksAin3Z4QlhOhSygIKv26xh6lR48tvF5tScf2uf0oa+Baqx1A Qsb5nEQ1D4+XLSsL3aJAAYdjdoAoctJdYYN0l2zlIA1VC5A+riGfEv3dnOiVuI+tTVtFAEP+i lC0YeAEr14sF1EO3DwMtA2CvdFPyOBXo82tMzX+n1IvGIR/OOQTiQ8bRVfkyHtJiKH1M5f2Q/ iH0zuf2ROxmcd5lfFeVjbDxcC0pEi6fjWnRskK3UzrQEdU2uU7BqjATa2dYsdrG0fkmlSr7yn KG2D8GlELZv34LnEmkGwjz5wYf3/CPMm5RvlsBlbhFegX8mcdYB16R2Yfzdw4QJhfiQhubSgw lexXVPl6iNdoQiuUWyPwWkUFKoKLLHQHDTDRjArtj5j510deV9bgmNgGKFNEycoe00ulg6dr4 o+bAcGk/rffCqwyG8nosnJwGqVnauC5nXjj1hFVnDuvdjsl2TmYBvtCSMHfPEapJ0mZUfB9Ai YQJUdmhXL0MzQaaOet/SW0T/eODNLd4exR+seEgJUMw/YY4UC7r6CjEZiuRKF776H0Vg= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 25 Jun 2015 16:13:47 +0200 The free_arg() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- tools/lib/traceevent/parse-filter.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/lib/traceevent/parse-filter.c b/tools/lib/traceevent/parse-filter.c index 0144b3d..724a3be 100644 --- a/tools/lib/traceevent/parse-filter.c +++ b/tools/lib/traceevent/parse-filter.c @@ -1239,8 +1239,7 @@ filter_event(struct event_filter *filter, struct event_format *event, if (filter_type == NULL) return PEVENT_ERRNO__MEM_ALLOC_FAILED; - if (filter_type->filter) - free_arg(filter_type->filter); + free_arg(filter_type->filter); filter_type->filter = arg; return 0; -- 2.4.4