From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751732AbbFYQWh (ORCPT ); Thu, 25 Jun 2015 12:22:37 -0400 Received: from mout.web.de ([212.227.17.12]:54465 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751357AbbFYQWa (ORCPT ); Thu, 25 Jun 2015 12:22:30 -0400 Message-ID: <558C2ABA.3000603@users.sourceforge.net> Date: Thu, 25 Jun 2015 18:22:18 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH 1/2] perf header: Delete an unnecessary check before the function call "free_event_desc" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <558C29E1.2040909@users.sourceforge.net> In-Reply-To: <558C29E1.2040909@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:rVevUA3RbBkaD99cUiZ6Y4utyqBM/ukSSBWQsUDJkPf8taHpoYG tz991AOZtsfrRrvLL/wWbflLGqhwN8z7ewHDLjHkt8G3PM4VNKX0hgGU1b9s+XTvD9A8m4F /XHjtaa3jqowd3hsWvyYDHJ9/GsnrivtyydSnQx+uBS3KJIJzlUB4MnV1QwBJpNsbLaElmm o0ju3ws86v7ywOUwlrlNw== X-UI-Out-Filterresults: notjunk:1;V01:K0:3Y2nedvoAVc=:HFhQCpZZp303vpN8Sf8Dbm 67gL5EfM0u+f4YPFaLy6q7+aLmE1HNuob/gHU9zo1R4vcrATzxALiYw45txRkIJ0vPLCeeYiR heXPYv8C0Bi5sljtXCPYZlgEh6SxFffB3w0doOcxsjooVCLmkWgErTDkC5YZVI3EBRiBvDaUm Hf+HjG3xApu81fKJE4b7Le0eIljLzTMiNyuxTZ5p4rDbIKn9QHtKUk1v5VaiRPi6GOEzLyjXd EFqCJ60pL7iNuySL21mGLHsRjv+1tV+3r7ZWClcarNiA3xFGLzjElwdoOmy+jZPlhmoLdgQyX cWzatN81MRlDgBfXwXlqdg4vxIAEHqdt0vvaFi6ddlPY/jeHzxnQ4Lluvf9J9qxT1BDvPFvys T8trsNV1+9No+/l2XRVZKF5b1YEon5NhjKJV3HNU1c+ut00z+b8JNKEbjueKYetP1jUlOeAsX PzqPvy+zAtAUKeEFIY1W5a6DcwZq0bn4ew0eQrzglfP3rXEk6fQ3rttMpmsYiIImpqNXl0Gjq I43sUzVLAelaVbfu3AFnWXksu6PhYNsBoMrCoMRoK3LsrBnGN2WDN5uOOMnc36bHLjP4o8fLn dk7GVVr883rKeqCfG3lBJc2I3fkKXYeyUyy+0hS3ZXIF+aVxMs8hCc5kztBSdpFAjyH8FxEJg XWo5Cz7DgtdkJeL8Bt2iiIuGmRVSeFrpQkTFwBljyOptTMb0ewK99yXOyrfEMMHOgu5U= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 25 Jun 2015 17:12:32 +0200 The free_event_desc() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- tools/perf/util/header.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c index 21a77e7..03ace57 100644 --- a/tools/perf/util/header.c +++ b/tools/perf/util/header.c @@ -1063,8 +1063,7 @@ out: free(buf); return events; error: - if (events) - free_event_desc(events); + free_event_desc(events); events = NULL; goto out; } -- 2.4.4