From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752187AbbFZJPs (ORCPT ); Fri, 26 Jun 2015 05:15:48 -0400 Received: from mout.web.de ([212.227.17.11]:63337 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751827AbbFZJPj (ORCPT ); Fri, 26 Jun 2015 05:15:39 -0400 Message-ID: <558D1833.3080009@users.sourceforge.net> Date: Fri, 26 Jun 2015 11:15:31 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Dave Chinner , xfs@oss.sgi.com CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH] XFS: Delete unnecessary checks before the function call "xfs_qm_dqrele" References: <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <5479F823.60900@users.sourceforge.net> <20141130230904.GF16151@dastard> In-Reply-To: <20141130230904.GF16151@dastard> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:EEJ95qkRBtwM3xRJqEvYqbh88A9pWIKFfVMexTG1WbBuxp9nqO5 w7Ucx+50u04sFDXrIwsJvzZF8BwxjeAA+kjk0urrdOuvRrwjoNDCyqiAqVmz/HYxHIfHO8o 1+j5jLO8WmR6H1LsGMdFCuCR2qTYxb3EngCHDffvsgn+wiQ801AY7eIku4UbhP3nAOQGlh8 m5QHJDdtsBqNVj5lQnRlg== X-UI-Out-Filterresults: notjunk:1;V01:K0:Wsn9iKFiK9Q=:D9STzHzClbClpw/XlqSIIX R1Snj00V1Kg9na5Hdf9Dxvpa5Ap62lOkGcDHidKHtNybOKv3V/hK+ZTCIlCwyV/sM9W9VuD1e gPSItsQGr0Y9Wm1cmrg4g0c+AWra9fsFPCodxM00iNaWbG2oREYdkls75Bkh/3byZueq3i8le NQV88X9JwKQSQDpBmZf/np+dpdVF516NGRkpM/q7KHX3Dt1k+6CILo6WfUZa0IvtIaOOJo1bi DSXKvBcf9RbIn3RZWnoILcpZ85NjvxkUd3RzrTBagtxUuiDDUqL/mqEIRkMvXW1xWJzR1mLfA PX0hoxtNLjK+0upZ7/g76nubEBdzqi+IPGmxyWo6MsLhK8+IlgfnmXk4Owih3qtWmhm1SWmRu 92V2k+f5uOzOE0FA6XkFOts/E4adiDkWSh1vq5CB9nxLWVTplx8SFvR96iTFeS9v4SOaxABYm MiZ4lk9tHB0hSVuerSiGF9fUDYUw6+VaKudoN8twPOAbuWRCrQq5KYUv3qmU91wQxFY7XwpdI 5fl5Ica1+MqaFnvvzdn6u3vaFw7NgWg7+c4erub7IjzPocGmrLmKqVc3TuAIUnASrpXSBdcDZ /glyZcgmlGNSZ00nwVfxpKFoDy3T9wmcsUNJdDUVjkzUSYNYEUqQllq8D2c5rN91BWfmhSowm tA/1NknvqAaxerc/g50gayJk9mfXCgf4W2c0y814YZfnxU9vD1XWERQwe/QUUhe/eZn8= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 26 Jun 2015 11:05:41 +0200 The xfs_qm_dqrele() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/xfs/xfs_qm_syscalls.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/xfs/xfs_qm_syscalls.c b/fs/xfs/xfs_qm_syscalls.c index 3640c6e..6deee1e 100644 --- a/fs/xfs/xfs_qm_syscalls.c +++ b/fs/xfs/xfs_qm_syscalls.c @@ -735,15 +735,15 @@ xfs_dqrele_inode( } xfs_ilock(ip, XFS_ILOCK_EXCL); - if ((flags & XFS_UQUOTA_ACCT) && ip->i_udquot) { + if (flags & XFS_UQUOTA_ACCT) { xfs_qm_dqrele(ip->i_udquot); ip->i_udquot = NULL; } - if ((flags & XFS_GQUOTA_ACCT) && ip->i_gdquot) { + if (flags & XFS_GQUOTA_ACCT) { xfs_qm_dqrele(ip->i_gdquot); ip->i_gdquot = NULL; } - if ((flags & XFS_PQUOTA_ACCT) && ip->i_pdquot) { + if (flags & XFS_PQUOTA_ACCT) { xfs_qm_dqrele(ip->i_pdquot); ip->i_pdquot = NULL; } -- 2.4.4