From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752982AbbFZPsc (ORCPT ); Fri, 26 Jun 2015 11:48:32 -0400 Received: from mout.web.de ([212.227.15.14]:59552 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751740AbbFZPsX (ORCPT ); Fri, 26 Jun 2015 11:48:23 -0400 Message-ID: <558D7433.6030304@users.sourceforge.net> Date: Fri, 26 Jun 2015 17:48:03 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Boaz Harrosh , Benny Halevy CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Boaz Harrosh Subject: Re: [osd-dev] [PATCH 1/1] exofs: Deletion of an unnecessary check before the function call "ore_put_io_state" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546B0D08.2070305@users.sourceforge.net> <546B0DBB.7080000@gmail.com> In-Reply-To: <546B0DBB.7080000@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:kHPxczz6ROcOOE4JW4QNUjMay5x2k7goF4EWFbiY3NtrE733dyF p0uZa3092ejVwACd/g5rQ3jFKjBVQKL8B5MFz+DwB6bMrWa69Lzs0wKsaG68u3mkN2XLmdS ZLgGm5hWbgSwWLbOsLNZYoU3fJ4VRR0FAE/kWjWjNEtIVp80fuyN0of6JeF67gtW6amNyIl 2v0aIMO0m7NB49l7FoqqA== X-UI-Out-Filterresults: notjunk:1;V01:K0:p3oTldJtopQ=:epGxO/8SDBOHPp7m1a1geN quHbS9rIuOlFBI+G7sNEDU1qkDiZQcE11e1/T271cddHrbfiw+ZLSOeJtOrN/1tjTUZzyHGMW Jdtg74z6sUUPrOLLUx1DwNFxumb1vxplVhQUIyA+7r+jRMOYqIZpB9bb6l0FzdSWIr3dLvOe8 kiuCqxzzKfEB+OBtBU8ymM+o2nmULVJLcRzoemKw20j3jgA6MuEhddwqMiPMgy4ESk2gUcLsJ /YI+aRMicIhM1mfIBzLDXZUJ9DTyKHf93lpjtbkRiQTxw7gXK1nYw9U4ePBPaqHYjwZT/XoJ1 ybwHE8aEnvkpXYGI5Za35l7c4ANCJu24kIuibNXu6QobdtQt4BuH2VhTjMMEo6yxEKRmOFImc HPMyRw8/6jKcimOTz5GDmZi3ZKoo8Ad6XhJeVwU+vWV/OyJP8WL1n9IqGyMHRXBIeOUp7C2w0 jya1erTOK8DE5cXNryqVzslme2eCzJhJ6BJCP07z3VgluNy8krd3LBdfElZdrZYevgr/3wHSL wLq1qFHzGHtzWCVyQ4eUQxNiy0r0eCU26hcef3K4F+nXKXdwRcYNlz4SF0sWjurvwvZ8MH8e9 ZoAyl3Rg1q6Mh2p2xOtcfKQnNSei2c+NGytCcXcVI7d/ulzTZ7Yo7tdroEQm+zcDCakcPLqL+ bEerZt9oelbqOvc4vrQOqNxc+hfGb7aEChZgELylF3JfVZtFXCE9Vc7xd0HkOqdgLarI= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> From: Markus Elfring >> Date: Tue, 18 Nov 2014 10:05:19 +0100 >> >> The ore_put_io_state() function tests whether its argument is NULL and then >> returns immediately. Thus the test around the call is not needed. >> >> This issue was detected by using the Coccinelle software. >> >> Signed-off-by: Markus Elfring >> --- >> fs/exofs/ore_raid.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/fs/exofs/ore_raid.c b/fs/exofs/ore_raid.c >> index 84529b8..5dc7c4c 100644 >> --- a/fs/exofs/ore_raid.c >> +++ b/fs/exofs/ore_raid.c >> @@ -716,6 +716,5 @@ void _ore_free_raid_stuff(struct ore_io_state *ios) >> if (ios->extra_part_alloc) >> kfree(ios->per_dev[0].sglist); >> } >> - if (ios->ios_read_4_write) >> - ore_put_io_state(ios->ios_read_4_write); >> + ore_put_io_state(ios->ios_read_4_write); >> } >> > > Thanks will submit for next Kernel Is this small update suggestion still in the waiting queue for further software improvements? Regards, Markus