From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752372AbbFZRm0 (ORCPT ); Fri, 26 Jun 2015 13:42:26 -0400 Received: from mout.web.de ([212.227.17.12]:61147 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752052AbbFZRmR (ORCPT ); Fri, 26 Jun 2015 13:42:17 -0400 Message-ID: <558D8EF5.9030701@users.sourceforge.net> Date: Fri, 26 Jun 2015 19:42:13 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Alexander Viro , linux-fsdevel@vger.kernel.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH] fs-eventpoll: Deletion of unnecessary checks before the function call "__pm_stay_awake" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546B04E2.80000@users.sourceforge.net> In-Reply-To: <546B04E2.80000@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:G9rj0dRqGrLnDEe4mXiTUI0VW9d3DQ1QQ2wEX0/+lPxhV6eNDGG AmvuYKrYCF6G7qTol1990Q11gunA8eGDbgYQP/0DjCCv//dyeSOPJSZtgkiomU/0iuzTajm vl2UWk3tzXtR+OTNVZt8QWRUOPlVghIWsltCtPF2zuWrLV/W03JgtA/6iF1GHGUNTa8hSPP MzYhkpGh13U6xSO0cXIVQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:ZWfoHLWbjPE=:leHyra+XMhQPGfxweJdctu e5Hj1xlRIhT/LEvmBdMMkPKIjovzFOtWFSqO7yViBSF/sb2fwK+oQMMtTu+VH1zm24mg3yK9g +9y55MNpOjF7I9WDyAQOkrJLNcNifY96RiSd/RG/Lr1kisgTz8uSeJ2we6Y3865+HGP6gSH5V 8obObLLaeVhd8f3QwJyXydtbwNhv+yD1vxspP+Cd8l/Y+camP9hVnWawKxdvOIcFSzvsx42Uy XYnwHO63b5hHi1Ll090cIGeFuVAZmDjg40Q5El5v1e3AuwX3AJ1Xi3RZF4vkE8mwSBeTYnVHa 24keqIc4/wZCpYkdIqt+tMKxMeymug3Z6FOca8UdA0nAvmv1jpcTGaxb8XAqQM22KG3neqyoW H+mK6oUbjbbLJh5bErCoZKdPJ9HFtt/yN2ZUruSodWb3xydsdhM+nj3RyF8fIHta+DUwbNBce uoKD7MW3a4YqcjPG0inevhcZBtE186oyK4e8ZUW1WGz1lZC5/JhfMkdwaI3gDyj9NNsYffFRY gvhfbttNMtQed9RkbjbxiH7pPH1j9hP7rH5tf+xg/bEoj+LvYcGvBufIlBt3A5u2NJe5jL6Pz iLXS3Erdg4lsMAreuG7YXgJaVdHatdZK+qBMIx/ECjjZbWGwbKZGr2xUswq5RiwGX7hqFT4A8 oS6vUHmSW3pTmbtgEAWrykLGRRt+g0oZdaLtXleG2Ggu7bhXk7BGSIhWZQXSj4PNTz2Y= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Markus Elfring > Date: Tue, 18 Nov 2014 09:27:16 +0100 > > The __pm_stay_awake() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > fs/eventpoll.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/fs/eventpoll.c b/fs/eventpoll.c > index 7bcfff9..eec2e85 100644 > --- a/fs/eventpoll.c > +++ b/fs/eventpoll.c > @@ -555,8 +555,7 @@ static inline void ep_pm_stay_awake(struct epitem *epi) > { > struct wakeup_source *ws = ep_wakeup_source(epi); > > - if (ws) > - __pm_stay_awake(ws); > + __pm_stay_awake(ws); > } > > static inline bool ep_has_wakeup_source(struct epitem *epi) > @@ -571,8 +570,7 @@ static inline void ep_pm_stay_awake_rcu(struct epitem *epi) > > rcu_read_lock(); > ws = rcu_dereference(epi->ws); > - if (ws) > - __pm_stay_awake(ws); > + __pm_stay_awake(ws); > rcu_read_unlock(); > } > > How are the chances to integrate this update suggestion into another source code repository? Regards, Markus