From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753503AbbFZT2a (ORCPT ); Fri, 26 Jun 2015 15:28:30 -0400 Received: from mout.web.de ([212.227.15.3]:53905 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753312AbbFZT2N (ORCPT ); Fri, 26 Jun 2015 15:28:13 -0400 Message-ID: <558DA7C8.6060003@users.sourceforge.net> Date: Fri, 26 Jun 2015 21:28:08 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Darren Hart , platform-driver-x86@vger.kernel.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH] tc1100-wmi: Delete an unnecessary check before the function call "kfree" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:jLw1pm5JumPH4Z6MxnDuNLst7elzpBIwLT+SIVKSbukuEnaE7oF CtqZAw9Mr3zwf8YZbSVVcIElox3naZoid0ZZ8+D1/KLToioFh9OMuej7PXjECCqGeD/HRvk pj/SeOvW9PTb/d19WQ+7OYYgh6QCHZUEOJnC4jR3auf03BJmSo1cuHEHwyH/UTIWNiPsnII BICJZ2ZfIwM9YEE+VgsOQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:9qJpLnUgmd0=:4n4vgu16DAr1O0Xkc9h9K4 /DonpU7AIOnY9rmGwhB6YVroxgAqCNVBYSINz72MFTwsJPb8w3Lzkywo2+WjVT18LHaUOEcw7 Is+Z17sQcIwkt9XVtOaJZJ7X4dJjR0oDZ0fGtGb5Z9OV1czX+uqaSAuUNc237Emrry8UEphjl 2CDdSnxVi7il9lOD08uxJ//mMQYKGiInmzn9odceULG8FInckooB19RIeIemTTEcQlXjbaFDi OAc/FuJAtU/1yC/juM9pPZqJ3SzmgQL7RwovTDWPurb6Cl7ZyqQwlvz9Fsskla/Hr72Z1I/Fe Ky3lniRDyGwEPvbEf9hBt/dU+SvE46QWMSnCXQ5j/4+WJj2XP9cKL7UK4f9sWkYGH2m7sgYnC SwgXFsfyJ3S1v4DjbuFoZjvrjGE65iS+m6iQnNViWzqPFRA/oFSbNtU/F6KQPxslIAOKnM7KE iMnLqUUt4W+eCHTNTv4rK0+2OGPbch1Sq0Xi8JopodZs1D+tsWJVpTvxNzRxqMMYq+IDMASrd ROhqQb1+xeN5bc4Yahl+7BkugvwicIlXurieBY37oYszcUjXL0qJi6jJQGzQ59mCHum5q+xne vj2/xXplu3fUuMUhZso9Tqk/FxNL0MRBoU+usSBxcMaWU/iKtbUyTHU6+rIpv2qVZgBVk1MCW VecBg+oc+i4GOUaJJoDtzCT3xeUWon0iq9xgjwfJGBWXQ78azOBVBmIfspdj4Ps8MKjo= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 26 Jun 2015 21:21:16 +0200 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/platform/x86/tc1100-wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/tc1100-wmi.c b/drivers/platform/x86/tc1100-wmi.c index e365425..89aa976 100644 --- a/drivers/platform/x86/tc1100-wmi.c +++ b/drivers/platform/x86/tc1100-wmi.c @@ -82,7 +82,7 @@ static int get_state(u32 *out, u8 instance) tmp = 0; } - if (result.length > 0 && result.pointer) + if (result.length > 0) kfree(result.pointer); switch (instance) { -- 2.4.4