From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755248AbbF0QSh (ORCPT ); Sat, 27 Jun 2015 12:18:37 -0400 Received: from mout.web.de ([212.227.17.11]:56837 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753597AbbF0QSa (ORCPT ); Sat, 27 Jun 2015 12:18:30 -0400 Message-ID: <558ECCC3.1020907@users.sourceforge.net> Date: Sat, 27 Jun 2015 18:18:11 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Corey Minyard , openipmi-developer@lists.sourceforge.net CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH] ipmi: Delete an unnecessary check before the function call "cleanup_one_si" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:eEwosuNzRYIy4heEAPTDLeLSwlyp8I/aafvfIDVZQ214cY3brb3 Z2vmppWai3baJxk+jkKKp3YuyHPHj3Ohtn+5O+MixcGSl97zCg7aaGQ6e+10zp9JQ6ozDwz JrxCDkzYv1ndGPctiy1WWGMNoAF8qUWNIY+MrlJEm/S71TitwWRlL09M4cfGVP2NpovSubg u7wI5QIVAqKhfaMQ9IDQQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:M8lOpSXQ8FQ=:3K4U74zWXkVPUx4alTjbXG fDrsdVg+doHYr4yDxSWfEiIZdcEpp8F6ssavXSxcQO3SlDEbua48w7A+Me43sSyjK3uzfm69Y nt0r3aAI240Kt5sDX2qhiIQI5yA52tP5s7yzlrlYqTovGiNA8xTeodeCgEMPxVxZmOgBTWX3j ahehtQA9rYmzXx3q/QIYj6ifv+L0o1CCIMgY9sohSCsZVo89sqb9Y10bhN81/asr56VbFwLG0 ze3AiYdQ4YIATAeTPIl4IpzAt68fDlWaP61qYZHKYEPTbUw4/RAIRlA5ffhBoyeCAIMWd7c+V c1OJ4asWdhGWkCIri5JFz79kSoYB+4dbulIsuZP++COEH9zyFwCgOfuQohMP3aZGZT7Lm/eFP 0S0nWk/QP+Oi4Led0fS7iEBBuSDxqYnXvJSv2Mi7Kj/sBUidSq6Yw2W78OxD5WyWqY1KPnCnZ gv5e1hUtiwQQnPZmvBGBxxdUJzOsBX1cISJKdQZ61HCLsF+EslQOvtTpEeJyTCIQtcqqT4aLn I+iBo9mK38NSSLxi+DRolxyRE4oJAAvJfQZtqzT7zrPnYjFizpatuvdZhPng4kxYXYpXUSy4t 6ZEeOWbIVKhFU+ECSBkH/35UgLXYDXdN2VL4fm5Dfg2jFkoBbwynNHWNXzMJbD29FrqdkSY4i h7VuHD9PFZyhvS3PF+c4drs1DGkdWHMyfW48G45AXtLWXv6mIIZKB+sj3dtzzWUFi0sg= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 27 Jun 2015 18:12:14 +0200 The cleanup_one_si() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/char/ipmi/ipmi_si_intf.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c index cb90f76..fbfed36 100644 --- a/drivers/char/ipmi/ipmi_si_intf.c +++ b/drivers/char/ipmi/ipmi_si_intf.c @@ -2778,9 +2778,7 @@ static int ipmi_remove(struct platform_device *dev) { struct smi_info *info = dev_get_drvdata(&dev->dev); - if (info) - cleanup_one_si(info); - + cleanup_one_si(info); return 0; } -- 2.4.4