From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753648AbbF0SvQ (ORCPT ); Sat, 27 Jun 2015 14:51:16 -0400 Received: from mout.web.de ([212.227.17.12]:57933 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750861AbbF0SvL (ORCPT ); Sat, 27 Jun 2015 14:51:11 -0400 Message-ID: <558EF095.8020106@users.sourceforge.net> Date: Sat, 27 Jun 2015 20:51:01 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: David Airlie , dri-devel@lists.freedesktop.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH] drm/bridge: ps8622: Delete a check before backlight_device_unregister() References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:v2r1kg6slcMi42q2H8x4ewbYHtnS2usZ+sWgN6O9oTeKLhtnXF/ N7uJLBOAfawi15a16+dImu3/hch7N/K4D1kjsLgqM+tm6o9f8p0fdUse3BuRtARD1fewGa2 YBaTUdN85bd8Y8uBiHqro+ufgvbMFuANLtgwNB8YQFhfOuTgDrxU/gkwQCq6TTC5XV3vdub IicdqRGe6FbPBpc0nMYdQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:07IwcUVND5M=:9vm5r7iN0rm8kR/+eyN6bR C1/++fNb1ElhSxym/0MNmgDqudS6xgBDH5Atx8jO8Fnc5st1JLvkk+L5O5xjyrjZen77a1Y6J 3FrwYsJeYOGHVHFTo3/AdKumLrHVdp4zLn0lgYVvLp0Tvumj3r/U78RZ6KPcCeNu0ST9+jQlL eVxNBwdPcI0lq/mEdu5evamrLy5mp19c3c3kcxZokl8ioGj4u1iimDPYlHYFY6aMlegcIlADN dJAA6dlNZr5XyMTZsTZaRmAo5Qr0PswsgS/J3xhRZTboZ3ned6OiZ9wWup2nxTwBtGSjicyPx eayUn5W0kDz29wB5FOj17UQorpum2jOsCkDwNXHMy67cCgc2hEEvSDXrOCmtdYD+DGmBtHtIb LkqaxJpVXjvJtWHd1lf6v69ObItpP3wC0phv8ePauAeTn/1iZAmYeaYYA78WwuKPymBQuImBt 37YLuaqcoMRrAeRx07tXmHa03GPtVZAa+BnbAMWYyrAqlfqGJCeTGmiZX4okEJnfUbDv0SF2K J+B+C5x610mHUJ5GemFKXNkTRhhMnBMTdopwc12+BcO2XbieZ2JF1QaNq1lo/RMB2jV+PlAq1 zbxA8h+hVdjfKaLzP0ebLwiqarkQ07PAwk0TbdXwP7g6Tk2r6v89+sMYhH/GFyZ6HrEPSw6SZ Ij7hGvduirsgSgYVU02/aZqURy8a16hDkoMZUrDyJXs0Q5J1N8+ZC5klaS3zAk85cPc0= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 27 Jun 2015 20:44:49 +0200 The backlight_device_unregister() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/bridge/ps8622.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/ps8622.c b/drivers/gpu/drm/bridge/ps8622.c index 1a6607b..70dacb8 100644 --- a/drivers/gpu/drm/bridge/ps8622.c +++ b/drivers/gpu/drm/bridge/ps8622.c @@ -646,9 +646,7 @@ static int ps8622_remove(struct i2c_client *client) { struct ps8622_bridge *ps8622 = i2c_get_clientdata(client); - if (ps8622->bl) - backlight_device_unregister(ps8622->bl); - + backlight_device_unregister(ps8622->bl); drm_bridge_remove(&ps8622->bridge); return 0; -- 2.4.4