From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752291AbbF0VVN (ORCPT ); Sat, 27 Jun 2015 17:21:13 -0400 Received: from mout.web.de ([212.227.17.12]:63565 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751268AbbF0VVG (ORCPT ); Sat, 27 Jun 2015 17:21:06 -0400 Message-ID: <558F13B5.6080602@users.sourceforge.net> Date: Sat, 27 Jun 2015 23:20:53 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: David Airlie , Hai Li , dri-devel@lists.freedesktop.org CC: LKML , kernel-janitors@vger.kernel.org, Rob Clark , Julia Lawall Subject: [PATCH 1/2] drm/msm/dsi: Delete an unnecessary check before the function call "dsi_destroy" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <558F12BA.60709@users.sourceforge.net> In-Reply-To: <558F12BA.60709@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:P7lSvF6+mzmonG6SEsey/B4D2LjzuQRTSuUDzMU2fbAbB6+0/nT xEW2/VWGKv3VYtMp7rvSHOyZaZmRd5sMfKndFzQR33DYrz3QmCFRGvTJ3ensd1Z1CcXKa2V +SBEGnwphD8vGSEoTBxMV6sgxhmgcpNuOZYiqhXGOifE56azWLCaknznaeSz8Lxcc9WKSug BWE5gN26141uRNjPYpcBQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:QKVAnuAcuOA=:kdkNhqCaHraopCu0TB9Xmd PSPfre4iACvJ6CtahSJNz8V/TJoi7u0HxRgISR/9xdVacokN2MUUJH/ZgRQfULqme38Ebp7RH iGnlrFBcQ/ZU+GRzViRM72YxodOcdWSJ8krlls7xQHvYYaAmhzl5kXN0RCtFlakEJM1c5nZ97 Cmdr22M1LcbdQlNmF8Qlgc/06YPvcRHVNo6yc36l/kTpcYIv24AfKH8gueLbGa9mJIRPIog/j DIPwJ9261/mTSuAfYB/UnOANsWfPxBcER2dLlwDtZoL/0ftfq43EF4nbhdHdAUZZKV3PercVW ssgVaTPx2A6qfzy0BceGPCqY5D+0lsr8pDiQupnwF4qPTOiyniFZV1YB7VlK1szO3I0LZiDS1 OEl9aMK/OvqzGWnpE6ZKX/JZoRlkD3iAnDL7LZCR/ShiVVJ/iLhdXYJCXnjtV2unAJ2vjAmB8 /oi9qDYdHgops/86p8BvSOim16qOp0nOKp4hjLTSM3SzYGqa3EjrSmE14KVs4I83LeIqoN1Fa WU2H/+155OXn6GJXaBGL6VpKrR8YLjZk7vimnHJYn+SNLszMLiiCYm2ybO62uW6/kcJV4ukDa O+miaTwuvPsWed13qB+qWH6jOFMXL6ZH0OQCll3/C4DOPDmr2wbtu9mKWeXvxhwjdJ0qTEK2j n738KW/YWTLmkxZLpA/1xjtleu7WSYF1KV5As3cSaJHutVYY9v0aDxx4mZXNfohxAKVc= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 27 Jun 2015 22:05:31 +0200 The dsi_destroy() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/msm/dsi/dsi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi.c b/drivers/gpu/drm/msm/dsi/dsi.c index 1f2561e..dc4f38f 100644 --- a/drivers/gpu/drm/msm/dsi/dsi.c +++ b/drivers/gpu/drm/msm/dsi/dsi.c @@ -110,9 +110,7 @@ static struct msm_dsi *dsi_init(struct platform_device *pdev) return msm_dsi; fail: - if (msm_dsi) - dsi_destroy(msm_dsi); - + dsi_destroy(msm_dsi); return ERR_PTR(ret); } -- 2.4.4