From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752514AbbF1LVB (ORCPT ); Sun, 28 Jun 2015 07:21:01 -0400 Received: from mout.web.de ([212.227.15.3]:52056 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752467AbbF1LUv (ORCPT ); Sun, 28 Jun 2015 07:20:51 -0400 Message-ID: <558FD88E.6070304@users.sourceforge.net> Date: Sun, 28 Jun 2015 13:20:46 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Lars Ellenberg , drbd-user@lists.linbit.com CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH] drbd: Deletion of an unnecessary check before the function call "lc_destroy" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546C9076.2030500@users.sourceforge.net> In-Reply-To: <546C9076.2030500@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:5xOp87YenBl7riyugFal1oCbI4MlJDX7go6Sk8ln+jLNWqygCkc a/K9vtom1td7qveETX5VDKNRiMV0oCEIUFReFSS0E7qbevTiJJkn3203S6VkCS7AOgoD0nz 79uYCCi1xYtsg/5jg2hAPXagU1hsX7VmUCQq893xovbUjTxW7MqjEQXXl+UJgvG2ukTyQSX vx2kOkcmpkU0W7IZ7ox6A== X-UI-Out-Filterresults: notjunk:1;V01:K0:EigGgu8Xkps=:P1h/suRMnYODrjBF9s4WAt 8xu/ZsoTX/rpmTB9dLTMsNULhae01Kc8CT3rhMh0ZaybNaMsnBejpR6UW672VLQwPpmJZQTYx Y5NHa9DqQvO5lZE6tJh+ss9X3WRT44XPEiRvTdzxY1qW1xqtb6KjqUw2y0Rj3VDrBcaF+f+cj Tldb8kWqKzKpJFzkU12fvrisehPvR16KDRznDW52aJLQMoYrjmeAwWQLhj/VL8tmop968Ruxp YLwL1700yFQ/kSG/PVp/dvOXLzcTNcGwFuCJHq2Aa3zJJ249/OWIxr/hRUIB8ExTNo22YSEEF cob7/RLQ4WekPTLllizp8E1/hNSBJf0w4z05Ri+1A+B/on8+NjNcVvInVDnj95ncNBlxh98b/ /mVqvOUR1ND5sN/W6Oqxn3Taevvb77wQIlNjPHXe0NefBaLMlpbeoxv62nufsuyra4K/aTLVH H1A2BNWOcDyUhufsUqKwi6rGnjV7QzKVs5hqNy2EJfucUFBfcniBJfYlm83VbJqvFBkSf/Ecv 7aUmAN5heagapJhpPjkMWlsk0+fr+UZ+3B/p3p5yD6ZV47w2GpDcdr5FsP6n9UYhQ297idZ9T +CxOtFhwFThRpR6pMzPsjaQRPbTpfAI/mrSipGuGm6tWVnwz3Qaq2F7jpBoWtYCjRtNvHsMT3 UA91Yo2PSR+c2qlB6Kb8OAPQOD1c43eQoIqPz0iBXUXsRneNC4e+SQHvk+leLPFbqrFc= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Markus Elfring > Date: Wed, 19 Nov 2014 13:33:32 +0100 > > The lc_destroy() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/block/drbd/drbd_nl.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c > index 1cd47df..0bcb3e0 100644 > --- a/drivers/block/drbd/drbd_nl.c > +++ b/drivers/block/drbd/drbd_nl.c > @@ -1115,8 +1115,7 @@ static int drbd_check_al_size(struct drbd_device *device, struct disk_conf *dc) > lc_destroy(n); > return -EBUSY; > } else { > - if (t) > - lc_destroy(t); > + lc_destroy(t); > } > drbd_md_mark_dirty(device); /* we changed device->act_log->nr_elemens */ > return 0; > Would you like to integrate this update suggestion into another source code repository? Regards, Markus