From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751233AbbF1Le3 (ORCPT ); Sun, 28 Jun 2015 07:34:29 -0400 Received: from mout.web.de ([212.227.17.11]:57184 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752124AbbF1LeU (ORCPT ); Sun, 28 Jun 2015 07:34:20 -0400 Message-ID: <558FDBB7.3030301@users.sourceforge.net> Date: Sun, 28 Jun 2015 13:34:15 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Linux Kernel Mailing List CC: kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH] block-skd: Deletion of an unnecessary check before the function call "kfree" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <547CA303.9000001@users.sourceforge.net> In-Reply-To: <547CA303.9000001@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:+YtkooXDBPmkbKfuC+MYHkTTBt5l3Sjm9xp5pOkOGAB7fPDXQ0n icgKkHFWaVVirZnMckVdaDqQLieSVXdiBbzP0Q6fLKIoMxn9Kv1uOLR2b5B2KHFxxkiGLaU Su4z8dux7Gj84Qjqt2muxpZZG9NJfV4an1plMDD7lciRnEE1w70wC9Cl2fgEfyTbmhNE+G2 Lonj35S+voa0oGy46XvEQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:KDQMHDiZ3YU=:ostgGomuE8Q/59RE4Q9Aib KzZbjg4i8gX4HfA6CJXMTRnIz3+K5RterL1j8w3niELgfQ6xRho9MfNpjOYKQmkfc7RCrhqZQ 4BtL58HmzR83l0gmPSmzP90T1wztlfQKO8zLcq96Q2XqSmW9Z0qsJ6i1Ve9Pchm6LbdwEK0Bd 7wZ7ca8AMgySGdwUaBvxhNBEzuMuq2Np2ItRs/jl6Qd3h0L4Xs/8lgRFZLserQXS7WsAZPbns JYgQmVI4w3XhFyALNsegEiSRsggbaw2HfFXSckxIPR0XL4yhwNZ0P44n6SfzSWGI0xYWobdxu EYFZsBp8gSMOha77q5bRc+YBRutT+gwUtZgwJKtOdBY8TGrx1C3Ghawz1PmtwyhQ8pNdQ1bTC TEp3xG2HQuvsQ1we9EBCjE1nxnCIJ2spWc6TiQ5FB9cgxFYBvFt2AuXJDWJ+l6fVBpn7WuelO btdSaOC025rMMQahVFrW6v1S4gIQFviDBbSm6lMHaI2fJnvz0wWmIktEJq98N50SdKbJbPp40 mrSCo+y7YTCWAy7TAl9f6rhBMH6AzVA1nHh0cOBRbmHueiQvsVv7fqEuKJD6Pbi0F1AndkShw jFsk8HS9ra8LJi0kFjTgLQLvzLtitE7saDnPo+eDwqEY1gIBqsLJuEnq0x8xQ2amDNAaAf9Ga 6pap//6O3LFJsP4urJywgADEyb2twAvryaylFp857tq8tYCVbqN+sUejLpUEBXaeDOX0= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Markus Elfring > Date: Mon, 1 Dec 2014 18:15:46 +0100 > > The kfree() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/block/skd_main.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c > index 1e46eb2..c4b0259 100644 > --- a/drivers/block/skd_main.c > +++ b/drivers/block/skd_main.c > @@ -3998,8 +3998,7 @@ static int skd_acquire_msix(struct skd_device *skdev) > return 0; > > msix_out: > - if (entries) > - kfree(entries); > + kfree(entries); > skd_release_msix(skdev); > return rc; > } > Would anybody like to integrate this update suggestion into another source code repository? Regards, Markus