From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752551AbbF1Mgv (ORCPT ); Sun, 28 Jun 2015 08:36:51 -0400 Received: from mout.web.de ([212.227.15.4]:60700 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752360AbbF1Mgk (ORCPT ); Sun, 28 Jun 2015 08:36:40 -0400 Message-ID: <558FEA4D.9030108@users.sourceforge.net> Date: Sun, 28 Jun 2015 14:36:29 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Jean-Christophe Plagniol-Villard , Tomi Valkeinen , linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH] video: fbdev: omap2: displays-new: Delete a check before backlight_device_unregister() References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:IHy5nwK5Hq6KpqvYLWnDGqkCiqh2fwAwPnGde1qUJZLy1l3I4Fw mdCczAjufklti/Y+2oXwuvHffdI5SdQu08ab8uYVDmXRO4paagcab6ZACz+zeT42mvwvaRj 3XDfthi8uVJ7ozmhxT2nfLb/dSqA84ouBE1z9k7Bh3O8OLkK3V+HdYVsJwv8YKnT0MeFuIr 2o1LughgdtnjXY9rcmkVQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:U8sTunA2JG0=:e6E+t6yxYEykK9jsV4OjcX i10H6st0K23fiC5TmW1SIF/rkoCxvZivhmrvdJhIokuixBANPRuyXg0KmViUfcH3n/2PZgMee TYhHU5YPMf8nJUe0QlJYs9vKPNJYaPdIlLJIBG5NeGKQBn71unUex9Dn4fHJ+61y7xduONsEV 50uoZ2Bf4jo0dsHuC2tRqTLcG9SoeEQDC/bI1NWmI+eFODIVcR0KjtzY0QRgo4+bZ2IJXLvkx ov0wIEBNA4i+PvXdNe1x9l5aKfVnJBAQOOwDnqJ5NDpmmQ8OevpfbkggH/KJ/cRzB17G+gk5C MWZYKCe3g066tHKQw/7Fu/agnYVYJ8ixdJL2Kc3/7NF6WV+Y3QP9d9B8PDXi6fNUTHvS4YuwL zHqSTukvFDxAHyaejfm3Sd1XWhQ5HfhDPOiXXHGz+TMaBiBmACztEy6gc66/fCCLS1QFvQwwe IBZlbTiMbW2Im/RHd6h1zwRVNAc6a5ZvuxP1UaBCrzP7yMKKOtcvZB/LnPc4fFfyiW5fDJ4fd 2NfI3cFN/pRphu8QuaBYbInZc5SuIEU7by+bB/6oZj2JWv4AbPyWcGxcWTgkSjf3n6sTqM6NE MLxSVcbROqnvu1/9YxYOq70UU9tXHWm57tkVfCSB+nfyMr8cSXJ/lirhJdJkgP/pf4Eqg23yz caacbaDVUZl5eMqRG0JKZztlmNz/TKv1PVFegBDc80XsyuGxzU4VscGy9rC7StRRhDdY= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 28 Jun 2015 14:30:17 +0200 The backlight_device_unregister() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/video/fbdev/omap2/displays-new/panel-dsi-cm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/omap2/displays-new/panel-dsi-cm.c b/drivers/video/fbdev/omap2/displays-new/panel-dsi-cm.c index 3414c26..d2caa41 100644 --- a/drivers/video/fbdev/omap2/displays-new/panel-dsi-cm.c +++ b/drivers/video/fbdev/omap2/displays-new/panel-dsi-cm.c @@ -1323,8 +1323,7 @@ static int dsicm_probe(struct platform_device *pdev) return 0; err_sysfs_create: - if (bldev != NULL) - backlight_device_unregister(bldev); + backlight_device_unregister(bldev); err_bl: destroy_workqueue(ddata->workqueue); err_reg: -- 2.4.4