From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752260AbbF1OF3 (ORCPT ); Sun, 28 Jun 2015 10:05:29 -0400 Received: from mout.web.de ([212.227.15.4]:54271 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752611AbbF1OFU (ORCPT ); Sun, 28 Jun 2015 10:05:20 -0400 Message-ID: <558FFF19.1060402@users.sourceforge.net> Date: Sun, 28 Jun 2015 16:05:13 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: =?windows-1252?Q?J=F6rg_R=F6del?= , Will Deacon , linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH] iommu/arm-smmu: Delete an unnecessary check before the function call "free_io_pgtable_ops" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:8U8LjAimzbJYPMUEfyIzYjSOslIDYurEW0lZH5omRTqksuA4DbP 68lVa6DW7+/KfRXy6JSDjvxtUOppD++gylwGkIu3ahubh63JTdxX7dJ0yBoRQXem9BNsEQl 6bz1hmRW4zVVS2vdEA+SxRTjy21VHhbf/Co4o8LVCA2EkwJGCTp76H4SJ58qBvCZDj6wvEt HByjm8x7hXi3Tbqu25nrw== X-UI-Out-Filterresults: notjunk:1;V01:K0:nGT/MBFE8gc=:8JjwHgEcRS61FenNGTo0sv UmcUpG6vM6X6l88mEW8qgvlX9g0RDG1R2VLCcUR1a8T09EoRIAv9JWy8LTFagG9Zfe6KRrWeI PK8AnTLncoveaXAhOOg6t51DHyEDCCbMl+nIwgrka0NHJM9us+JWRsnPR26+n+gUpwWxPiHPZ hxoIOdvXam/lDpOjTY9qvp1R2Xw8IZ+Uh6mmJRV9AlnN8UFezcTIBlYyAjkIOXCE+jcDm+eF1 SrQ9UEBdjd0ZVQO1QaCr418kIif5FIDFm5jhEdnOqKaFhytZiBDgmgwXnwBoRX4K19u3Djvld cCYnq7etP+0wRI/xjRr5auF4CcjKNl3Tdt0Th6QqKSMRF6MRJqpzlL/3986Ix+rLvrszNdaoG b9DnKMnovjQDwmxt/YDEIMs7JKqijzsr3TizCn7+CPxQTyTNIkFHylxn4kkm8RNulJRzGyKtw B4GCDVwjZekVZDGER/tSymHbe6IxXwVP3dwa1/y/1a8znskLB5GjIRVAZXPCgMt7yNab6Ezgv gBWMN9pmef0tMMfg6rA7yXZS6xTDdl7G+jNftGBTLv/h/qA+lVUw9u7jurddTidqLvkyWhaQn kicwwd4TD/yJy/YCNcDQtSCwsP49BWeBopIUmD5hU9DQJ0EBdPZmmKe4sOlMHl3oX2tSoSqLA 1etUWHlKDWIiDttkA3BhcjeiNGGSors931eTm9cAPMjdud2s199gNlh7Bw2Qf3zQCXCg= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 28 Jun 2015 15:55:11 +0200 The free_io_pgtable_ops() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/iommu/arm-smmu-v3.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c index f141301..8e9ec81 100644 --- a/drivers/iommu/arm-smmu-v3.c +++ b/drivers/iommu/arm-smmu-v3.c @@ -1389,8 +1389,7 @@ static void arm_smmu_domain_free(struct iommu_domain *domain) struct arm_smmu_domain *smmu_domain = to_smmu_domain(domain); struct arm_smmu_device *smmu = smmu_domain->smmu; - if (smmu_domain->pgtbl_ops) - free_io_pgtable_ops(smmu_domain->pgtbl_ops); + free_io_pgtable_ops(smmu_domain->pgtbl_ops); /* Free the CD and ASID, if we allocated them */ if (smmu_domain->stage == ARM_SMMU_DOMAIN_S1) { -- 2.4.4